News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Questionmark in eksternal links URL disappearing

Started by torkil, March 29, 2005, 02:27:46 PM

Previous topic - Next topic

torkil

I have been running the standalone forum for a while now and just installed the bridge. I'm letting a few moderators test things out and they found a bug today.

The old standalone forum was located at www.kampforum.com/forum/
The bridged version is located at www.kampforum.com/index.php?option=com_smf&Itemid=26

The problem is in the bridged version, not the original, and it goes like this:

This link is ok:
http://www.kampforum.com/index.php?option=com_smf&Itemid=26&topic=5586.15

But these:
http://www.kampforum.com/forum/index.php?topic=5586.0
http://www.simplemachines.org/community/index.php?action=post;board=77.0

Are changed to this:
http://www.kampforum.com/forum/index.phptopic=5586.0
http://www.simplemachines.org/community/index.phpaction=post;board=77.0

So... in the old version all links work just fine, but in the new version the links that go outside the bridge URL seem to loose their '?'... Any advice?

jorgen

I've seen this om ny site also. But I have not had time to investigate any yet, so I'm glad you started ;)
I think this was introduced in 3.01 or 3.02, but am not sure.

Its not really a big deal for me, since I'm the only one that is supposed to be able to run the forum unwrapped. And I'm able to insert the "?" manually. But it's annoying, and it would be nice if it was fixed.

torkil

I will try to have a look at the forum code today and see what I can find out about where the URL parsing is happening.

torkil

#3
Well.. It took me just 5 minutes to find the error. Its in this file: /components/com_smf/smf.php.

The actual error is that all URLs that contain ?board, ?topic or ?action will be changed to just board, topic and action (without the ?'s)

The function that is doing this is ob_fixurls():

$buffer = str_replace('?board', 'board' , $buffer);
$buffer = str_replace('?topic', 'topic' , $buffer);
$buffer = str_replace('?action', 'action' , $buffer);


Basically this means that all links to all other standalone simplemachines-forums will be messed up.

Hm. Any fix suggestions are more than welcome.

torkil

The problem has apparently been identified by Cowboy and is being worked on. I asked him to post a solution in this thread: http://www.mambohacks.com/component/option,com_smf/Itemid,57/expv,0/topic,45.0/

Advertisement: