loadTheme() function called for 'dlattach' action if user is not guest

[Nathaniel]

SMF 2 RC2 only, with a clean install.

File: index.php
Line: 190

Problem: The loadTheme() function should not be called when 'dlattach' is the current action, as stated by the comment on line 179. The current logic will run that function for the 'dlattach' action as long as the user is not a guest.

Related bugtracker entry:
http://dev.simplemachines.org/mantis/view.php?id=3169

Suggested fix (code for line 190):

Code Select Expand

  if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && (!$user_info['is_guest'] || (!empty($modSettings['allow_guestAccess']) && $user_info['is_guest'])))

Edit: This code works as well, takes up less space...

Code Select Expand

   if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && !(empty($modSettings['allow_guestAccess']) && $user_info['is_guest']))

[Norv]

This seems to be already solved in svn. Thank you