Sqlite error - 'db_insert' function as 'Replace'. (SMF2)

[Nathaniel]

Same issue as below, but for Sqlite not Postgresql:
http://www.simplemachines.org/community/index.php?topic=340003.0

File: Subs-Db-sqlite.php
Function: smf_db_insert
Line: 505

Find:

Code Select Expand

$count = 0;
foreach ($columns as $columnName => $type)
{
// Are we restricting the length?
if (strpos($type, 'string-') !== false)
$actualType = sprintf($columnName . ' = SUBSTR({string:%1$s}, 1, ' . substr($type, 7) . '), ', $count);
else
$actualType = sprintf($columnName . ' = {%1$s:%2$s}, ', $type, $count);

// If it's a key we don't actally update it.
if (in_array($columnName, $keys))
$where .= (empty($where) ? '' : ' AND ') . substr($actualType, 0, -2);
else
$updateData .= $actualType;

$count++;
}

Replace:

Code Select Expand

foreach ($columns as $columnName => $type)
{
// Are we restricting the length?
if (strpos($type, 'string-') !== false)
$actualType = sprintf($columnName . ' = SUBSTR({string:%1$s}, 1, ' . substr($type, 7) . '), ', $columnName);
else
$actualType = sprintf($columnName . ' = {%1$s:%2$s}, ', $type, $columnName);

// If it's a key we don't actally update it.
if (in_array($columnName, $keys))
$where .= (empty($where) ? '' : ' AND ') . substr($actualType, 0, -2);
else
$updateData .= $actualType;
}

[Nathaniel]

Unfortunately its not quite that painless, that fix introduced another issue, which breaks quite a lot of calls to the 'smf_db_insert' function. (like the entire updateSettings function :S)

The change I posted above, forces that function to only accept data using the specfic column names (whereas it previously forced you not to pass any). For consistancy with the relevant Mysql function, it should allow both. The fix below should fix that (as well as the fix above).

Find:

Code Select Expand

// Try and update the entries.
if (!empty($updateData))
foreach ($data as $k => $entry)
{
$smcFunc['db_query']('', '
UPDATE ' . $table . '
SET ' . $updateData . '
' . (empty($where) ? '' : ' WHERE ' . $where),
$entry, $connection
);

// Make a note that the replace actually overwrote.
if ($smcFunc['db_affected_rows']() != 0)
unset($data[$k]);
}

Replace:

Code Select Expand

// Create an array consisting of only the columns.
$indexed_columns = array_keys($columns);

// Try and update the entries.
if (!empty($updateData))
foreach ($data as $k => $entry)
{
$smcFunc['db_query']('', '
UPDATE ' . $table . '
SET ' . $updateData . '
' . (empty($where) ? '' : ' WHERE ' . $where),
array_combine($indexed_columns, $entry), $connection
);

// Make a note that the replace actually overwrote.
if ($smcFunc['db_affected_rows']() != 0)
unset($data[$k]);
}

Edit: Removed debugging code (var_dump function call).

[Something like that]

http://dev.simplemachines.org/mantis/view.php?id=3853

[Norv]

Nath, can you please tell, a scenario in which you get the initial errors?

[emanuele]

resolved in tracker moving to fixed