[4924] Can´t install SMF2 RC 1.1 with passwords containing special characters

Started by McFly, June 16, 2009, 08:18:59 AM

Previous topic - Next topic

McFly

If the password for ftp contains special characters, it is not possible to chmod by the installation routine.

If the password for mySQL contains special characters, they´re stored in the "Settings.php" with a backslash before them. Further it is not possible to create an admin-account.

Mc Fly

SleePy

By special characters, I assume you meant things like ' " \ < >
Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

McFly


McFly


Norv

Sorry for the delay on this.
If you can please tell, does it still happen in RC3?
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

emanuele

Yes, this is still valid on SMF 2.0.1.
$_POST['password3']
is kept escaped, while it should not be. stripslashes should do the trick.

Sorry, can't track it right now, will do later unless someone else is faster... O:)


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

emanuele

commit ad054ff1601b7a761bf44c0bacdd4c4215213d3a
Author: emanuele
Date:   Sun May 27 2012

    [install] passwords should not be escaped [Bug 4924]

I'm still not sure why we escape everything else, but...it works, let's not break it. :P


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Advertisement: