Recycled icon

[ziycon]

More of a change request then a feature.

Occurs in 1.1.x and 2.0.x

Hi there.

I just found what seems to be a bug.

When i move an entire topic to the recycled section, the topic icon changes to recycled.gif. No problem here.
But when, for some reason, I move it back to where it was, the recycled icon stays on every message of that recovered topic.
Is this a normal behaviour? If so, is there a way to correct it?

Thanks in advance.

[Arantor]

While we're on the subject, there is a similar sort of issue with posts with attachments, they get a new icon because they have attachments and when the attachments are removed, they no longer have said icons.

[emanuele]

I think there is a bug report about the attachments somewhere (bug reports board most likely), I think this should better stay there too...

ETA: (so I don't bump) xref http://www.simplemachines.org/community/index.php?topic=447264.0

[Trekkie101]

I wouldn't call that a bug, but rather a feature of knowing that it was restored?

[Arantor]

Putting aside the attachments thing for now, restore icon has always bothered me.

I'd rather change it so it never forces the icon and updates it softly only while inside the recycle board. While that won't, obviously, fix old cases it should be a safe manuever to do in future.

[Kindred]

yes, I agree with you Arantor.

[Arantor]

Would like other opinions before I change it.

[margarett]

There was another discussion about this "soft-delete" option some time ago and, IIRC, it was found to be the best option. Can't find it now

[Arantor]

Well, it's not so much the soft delete aspect itself that's the problem here. It's specifically the issue around the icon not getting changed back when restoring a post, but I see no reason to change the icon in the first place when you can determine it consistently with outside means.

[margarett]

Ah, so you say just soft-display the recycled icon in the specific board, keeping the icon in the post itself (in the database)?
That is probably easier, also

[Arantor]

Yup, that's what I'm thinking.

[margarett]

Kewl

[Oldiesmann]

Sounds good to me as well. I also don't understand why the icon is changed.

[Arantor]

Fixed in 2.1