2.0.4 patch - Disabled ini_()set and package_readme file errors

[Mark S]

After installing the patch, I received these errors in the error log and an assistant moderator cannot access my add-on SMF Hacks Store admin panel (no idea if it's related but, the problem started right after installing the patch so I thought I'd mention it).

http://www.classicwinnebagos.com/forum/index.php?action=admin;area=packages;sa=install2;package=smf_patch_2.0.4.tar.gz;pid=02: ini_set() has been disabled for security reasons

File: /home/XXXXXX/public_html/XXXXXX/Sources/Subs-Package.php
Line: 2466


And a read me file error:


http://www.classicwinnebagos.com/forum/index.php?action=admin;area=packages;sa=install;package=smf_patch_2.0.4.tar.gz8: Undefined index: package_readme

File: /home/XXXXXX/public_html/XXXXXX/Sources/Packages.php
Line: 360

In addition, on the error log page, the area where the errors above are actually shown, the whole right side of the table goes off the right side of the viewing area, creating a slide bar at the bottom in order to view it now.

I uninstall the patch and delete the package and it stops

[LiroyvH]

Sounds like it's actually something in the SMF Store mod, I doubt it's a call in SMF itself.
Ini_set is disabled on many hosts because it can pose security/performance problems.

[MarkRH]

I got the same package_readme file error but that's it:

(removed)action=admin;area=packages;sa=install;package=smf_patch_2.0.4.tar.gz
8: Undefined index: package_readme
File: /(removed)/Sources/Packages.php
Line: 360

Everything seems to be working fine though.

[Kindred]

did you apply the patch package?

Have you seen the error after applying the patch?   usually, undefined index reports are nothing major and can mostly be ignored, unless they keep repeating.

[MarkRH]

I did apply the patch. I only saw the error after applying the patch and then looking at the error log in the Admin Section. It wasn't an error that showed itself during the actual patch process. It has not re-occurred since applying the patch.

My guess is it was trying to display some kind of readme information from the package file but none existed. Here's the bit of code in Packages.php causing the error:

Code Select Expand

elseif ($action['type'] == 'readme')
{
if (file_exists($boarddir . '/Packages/temp/' . $context['base_path'] . $action['filename']))
$context['package_readme'] = htmlspecialchars(trim(file_get_contents($boarddir . '/Packages/temp/' . $context['base_path'] . $action['filename']), "\n\r"));
elseif (file_exists($action['filename']))
$context['package_readme'] = htmlspecialchars(trim(file_get_contents($action['filename']), "\n\r"));

if (!empty($action['parse_bbc']))
{
require_once($sourcedir . '/Subs-Post.php');
preparsecode($context['package_readme']);
$context['package_readme'] = parse_bbc($context['package_readme']);
}
else
$context['package_readme'] = nl2br($context['package_readme']);

continue;
}

This is the specific line (360):

Code Select Expand

$context['package_readme'] = nl2br($context['package_readme']);

I'm probably just going to ignore it.