Mail queue bug

[Arantor]

There is a bug in the mail queue.

It pulls an item and if it is not able to send, it is pushed to the back of the queue as it should be. There are two problems with the reinsertion (ReduceMailQueue())

Firstly, no time is inserted, which means it will be listed as time-sent 0, or currently as being '15758.1 Days' old, which considering it was a test email from 10 minutes ago, it isn't.

Secondly, and far more importantly, the private flag is not reset. When an email enters the queue, a privacy flag can be set (this is primarily for PMs) and normally this will prevent the PM notification being read by the admin. Except in this reinsertion the flag isn't reset and if it fails the first time, it will become less private than it should be and the subject will become visible. This might not be a huge deal for some people but it is a bug in the software.


Reproducible in clean 2.0.4. Probably present in 2.1, haven't checked.

[LiroyvH]

This bug should already be known and I thought it was patched. We experienced the exact issue right here on sm.org a while back, making all emails look to be from err... 1974 or something. (Not 1970 for some reason.)

[emanuele]

Considering ScheduledTasks has not been touched that much it is there.. >_>
It may be worth a security release...or better a privacy release.

[Arantor]

This was already fixed in 2.1 and I've added it to the list of things covered by the patch file I have thus far for 2.0.7 should we find any other security issues (but I can see the validity of pushing the patch just for this)