News:

Wondering if this will always be free?  See why free is better.

Main Menu

Signature Limits Settings Mod

Started by SMF Customization Team, November 05, 2006, 08:59:06 PM

Previous topic - Next topic

wodema

No custom themes and English only. Just straight SMF with no fancy do-dads. This is why I'm so confused with this one.

Norv

Can you please verify if the edits were truly applied? If you go to the mod's page, and click 'parse', you should see a list with all edits the mod does to your files (or should have done). Please download a few of the files pointed out there, and open them, and check if the code of the mod was really added in them.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

I have no idea if they're loaded or not. I don't know anything about script. I copied a little piece of what I saw. Does this help:

$txt['whois_ripe'] = 'RIPE (Europe, the Middle East and parts of Africa and Asia)';$txt['profile_error_signature_max_length'] = 'Your signature cannot be greater than %1$d characters';$txt['profile_error_signature_max_lines'] = 'Your signature cannot span more than %d lines';$txt['profile_error_signature_max_image_size'] = 'Images in your signature must be no greater than %1$dx%2$d pixels';$txt['profile_error_signature_max_image_width'] = 'Images in your signature must be no wider than %1$d pixels';$txt['profile_error_signature_max_image_height'] = 'Images in your signature must be no higher than %1$d pixels';


As far as I can tell, this is the only section that has errors, but I could be wrong.

Norv

Can you please attach that file here?
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

Here's the whole thing. Hope it helps

Norv

That is not what I meant...
Please do this: look at this file or at the mod's page, after you clicked "parse" (what you attached, it's exactly the text on the mod's page after you clicked "parse", right?) and see everything it says, for example it says:

File Edits
./Sources/ModSettings.php
Code (find) Select

'karma' => array(
'title' => $txt['smf293'],
'href' => $scripturl . '?action=featuresettings;sa=karma;sesc=' . $context['session_id'],

Code (replace) Select

'karma' => array(
'title' => $txt['smf293'],
'href' => $scripturl . '?action=featuresettings;sa=karma;sesc=' . $context['session_id'],
),
'sig' => array(
'title' => $txt['signature_settings'],
'description' => $txt['signature_settings_desc'],
'href' => $scripturl . '?action=featuresettings;sa=sig;sesc=' . $context['session_id'],


So, what these instructions mean is that in your SMF folder, there's a file Sources/ModSettings.php, and you can download that file on your computer (using a FTP client, or your host's File Manager, if they offer one - How do I use FTP? / What is FTP?)
Then, open it in a code editor (like Notepad++ if you're on windows.) You can open it in other text editors, but please note that some editors, when they save files, they add some characters or code to the files, that wasn't there before (you may not see, but they do). And that code may break their functionality, so it's better if you consider using something simple like Notepad++ (that's not exactly Notepad).
And, search in it, exactly what the instruction above says: if you can find the first code, but not the second, then the instruction was not executed by the installation of the mod, even though it said it did...
Same for the next instruction (the next "find" and "replace" or "add" instruction you can see on the page).

The question is, were your files really edited?
If you want, you can post as attachment here your file ModSettings.php, and I can take a look to see if it has those first edits in it.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

Sorry about that. Let's try this one.

Norv

Can you please consider using a common format for the files posted? Like, please post the .php file(s) as they are, or, use .zip to archive them. Not .zipx, which is a quite new format and apparently only specific Windows proprietary tools can open it.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

Okay, next try. Wish I was better with computers. Let me know if this is what you need.

Norv

Thank you. :)
Okay, so as far as I can tell, the mod was not installed. Did you click "Apply mod" in Package Manager, and was the message that installation was successful... or were there errors?
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

This is what I get when I try to install it:

Error in Package Installation

At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
Installation Readme
This mod will add some settings for signatures. They can be changed in Admin -> Features and Options -> Signature Settings.

Error in Package Installation

At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
Installation Readme
This mod will add some settings for signatures. They can be changed in Admin -> Features and Options -> Signature Settings.

Install Actions
Installations actions for "Signature Settings Mod":
Installing this package will perform the following actions:  Type Action Description
1. Execute Code install.php 
2. Execute Modification ./Sources/ModSettings.php Test failed
3. Execute Modification ./Themes/default/Admin.template.php Test successful
4. Execute Modification ./Themes/default/languages/ModSettings.english.php Test successful
5. Execute Modification ./Themes/default/languages/Profile.english.php Test successful
6. Execute Modification ./Sources/Display.php Test successful
7. Execute Modification ./Sources/Profile.php Test successful
8. Execute Modification ./Sources/PersonalMessage.php Test successful
9. Execute Modification ./Themes/default/Profile.template.php Test successful
10. Execute Modification ./Themes/default/Display.template.php Test successful
11. Execute Modification ./Themes/default/PersonalMessage.template.php Test successful

 
Since I really don't know what I'm doing, I stopped here.

Norv

Ah, okay. So you didn't install the mod.

Please, then: Go in package manager in SMF.
Then, grab the file I attach to this post, and please use FTP to place it into SMF's Sources folder, replacing yours with this one. Please make a copy of yours first. It's not tested, it'd be good to keep a copy of your original file, and replace it back if there are problems.
Then, go back to SMF and hit "Apply mod", then hit install.
Even if another error is in ModSettings.php, please do install.

Then, see if it works.

If it does not work, and you are experiencing errors, there may be other problems than just these I saw for now.
In that case, option 1: please attach your ModSettings.php, after the installation, here, for us to see what is still missing in it, or not expected.
Option 2: check yourself all the edits the mod does in ModSettings.php (and if these are okay, check the rest of files from the mod's manual installation page), and if one of them is not done, please try doing it yourself. (how to do the edits: try finding the code the instruction says to "find", and replace it with the code it says to "replace", or add after it the code it says to "add after" or add before the code it says to "add before").
Option 3: try uninstalling the mod, even if it has some error in ModSettings.php, and then revert to ModSettings.php that you have right now (replace the copy of the current file).
Option 4: see that in the folder Packages/backups, in your SMF folder, there are some packages with names containing the name of mods and a date. One of them is the backup made by SMF when you try to install the Signature Settings mod. Download that file, de-archive it, and FTP the files in it back to your SMF folder, replacing your files with those from the archive. That should restore you back to the situation before the attempted installation.

I hope none of these last will be necessary. :)
I am mentioning them because tomorrow at least, I may be unable to be online at all, so it's just for you to know, the options to solve the common cases that may happen.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

Okay, I installed it and the Signature Settings icon is there, but when I press the icon it takes me back to Basic Features.


wodema

Here are the new php files.

Norv

Do you have errors in your error log? If so, please post them here.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

This is the only one I see but don't know what it relates to:

8: Undefined variable: filename2
File: /home2/ladyofth/public_html/forum-3/Themes/default/languages/Post.english.php (main sub template - eval?)
Line: 889

Norv

Please install this mod: http://custom.simplemachines.org/mods/index.php?mod=2054 and tick the checkbox as shown in its screenshot. Then eventually, please try going to the Signature Settings page again, then check the error log.
Please paste here the (new) error(s) in the log, if any.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

I didn't get any checkbox, it just installed by itself. Same error and still me back to basic features.

Norv

After you installed it, it adds a checkox in admin interface (please see the screenshots). After you check that box, and redo the operation perhaps there will be some other error in the log.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

wodema

Being the neophite that I am, I installed it but still can't find any screenshots. Can you give me exact directions as to where I find these?
Sorry to be so much trouble and I certainly appreciate your help with this.



Advertisement: