Comments on new SMF theme

[Grudge]

Thanks all for the comments/bug reports. We will be working through them all and trying to fix it all up - but this may take us a few days. In the mean time if anyone is having real trouble with the theme you can change to another theme from your profile.

[Daniel15]

And this is in Firefox Fox 2 - just look at the child-boards fontsize!!  

That's because the child boards are in a <h5> tag, which currently doesn't have any styles applied to it (so it's using the browser's default styling). We're working on fixing it

maybe in CSS you guys should use "px" instead of those "small, x-small" and so on.

As far as I know, using relative sizes (small, x-small, large, etc.) is better than using absolute sizes (numbers). I'm not quite sure why this is (I'll leave someone better at CSS than me to answer )

[Grudge]

Daniel,

I believe the problem with using pixels is that the browser accessibility features won't work properly. Browsers tend to support text resizing (IE does so with the mouse wheel) for people with poor sight (etc). This will resize only text which is sized as a non-absolute (i.e. x-small is relational, 6px is absolute).

I may be wrong but it's a good guess anyway

[Turklord.]

hxxp:img471.imageshack.us/img471/3037/tema2es1.gif [nonactive]

Demo: hxxp:www.forumavi.net/forum/index.php?theme=20 [nonactive]

Username: test
Pass: test

[bloc]

Its indeed much better to use relational sizes, it will scale nicely for all types of resolutions and browser types. CSS is powerful..but as you see, also needs much more care to look right. The goal is remove all - or most of - all inline styles, making it possible to change the looks considerable from the the stylesheet alone. Plus of course using html tags for what they are meant for, going away from using tables for layout. If they are used, its because the data within is tabular - for example the messageIndex template(the topics overview) - and not to solve a layout problem. This process is a lengthy one, because forums are in nature full of data laid out tabular-like..unlike for example a normal webpage. So the key will be to use them when its appropriate.

So while the overall look is more less there, the html underneath is not. So expect changes as things progress. That includes tweaks to colors and layout as well.

[a2h_]

Turklord - what a cheap rip. You weren't even given permission, were you now?

(btw I see searching for "easter egg" doesn't work anymore)

[Joshua Dickerson]

You can always use em.

[Daniel15]

I believe the problem with using pixels is that the browser accessibility features won't work properly. Browsers tend to support text resizing (IE does so with the mouse wheel) for people with poor sight (etc). This will resize only text which is sized as a non-absolute (i.e. x-small is relational, 6px is absolute).

I may be wrong but it's a good guess anyway

Yeah, I was guessing the same thing

[Teaberry]

My sentences and everything on the far right are getting snipped off.
Otherwise, I like the new look.

[Daniel15]

My sentences and everything on the far right are getting snipped off.
Otherwise, I like the new look.

Yep, known bug with Internet Explorer 7 - It will be fixed soon

[Defiant]

The fonts on the modifications section is still knackered for the worlds most popular browser IE7

[motumbo]

maybe in CSS you guys should use "px" instead of those "small, x-small" and so on.

I'll second that.  Those font sizes should definitely be done away with.

[Dannii]

You can always use em.

Definitely the best option

[motumbo]

First, as far as font sizes goes, using points will allow the fonts to scale up as the user adjusts his font size.  I still see no reason for "small, x-small".

Possible bug:

When I was in "post" view to make a new post, I hit the "back" button on my browser (Firefox 2.0.2) and the browser got stuck in an "infinite loop" of sorts.  It was like it tried to go back but SMF would take it back to the post page every time it tried to go back.

Probably a javascript error.

Edit:  The bug is not easy to reproduce.

Edit 2:  I did reproduce the error.  (I didn't read this whole thread so forgive me if this has already been mentioned.  Just trying to help.)

Edit 3:  In reference to the above mentioned bug, Firebug returns the following error:

Code Select Expand


uncaught exception:   [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMNSHTMLDocument.designMode]" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: http://www.simplemachines.org/community/Themes/default/scripts/editor.js :: InitIframe :: line 246" data: no]


Another issue:  After I made a post I went back to my other open tab which contained the main index page for the forum.  All the links were dead.  I couldn't right click nor left click on them.  Not only that, but my browser also froze up resulting in me having to go into Task Manager to kill Firefox.

In my view:  the less Javascript the better.

Edit 4:  When clicking on the "reply" link at the bottom of the post, it shifts to the right and doesn't bring up the post screen until I move my cursor back over it and click it again.

[Thantos]

The fonts on the modifications section is still knackered for the worlds most popular browser IE7

The mod site and theme site haven't been updated yet.

[Dannii]

Something more positive, I like the Reply/Notify etc menus. They look nice and work well.

[wahedmenelnas]

i didnt try it
i'll do it and see

[Joshua Dickerson]

Bloc: http://24ways.org/2006/compose-to-a-vertical-rhythm

This should work in all browsers:

Code Select Expand


body {
font-size: 75%;
}
 
html>body {
font-size: 12px;
}
 
p {
line-height 1.5em;
}


[Col]

Groundup,

The problem is accessibility with IE - it will not resize px values. In my opinion, that is correct way of handling px values, but IE is the only (main) browser that treats px as an absolute value.

[Joshua Dickerson]

Col: that will.