• Welcome to Simple Machines Community Forum. Please login or sign up.
January 28, 2022, 01:05:19 AM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


[SMF 2b3] Upgrading Database Index Names

Started by rsw686, March 30, 2008, 02:17:43 PM

Previous topic - Next topic

rsw686

March 30, 2008, 02:17:43 PM Last Edit: May 06, 2008, 11:45:08 PM by SleePy
I noticed the upgrade script does not change the database index keynames to the new field naming convention. Not that this is a big deal, just more of an aesthetic issue. Especially since a clean SMF 2 install has them named to the new convention.

The fix would just involve the script dropping and recreating the indexes.
The Reptile File
Everything reptile for anyone reptile friendly

Aquaria Talk
Community for freshwater and saltwater aquariums enthusiasts

rsw686

The Reptile File
Everything reptile for anyone reptile friendly

Aquaria Talk
Community for freshwater and saltwater aquariums enthusiasts

metallica48423

I don't see it causing any problems directly... But nonetheless it is is an inconsistency...

I do see a potential problem with larger boards dropping and recreating the indexes.

Bug #1883: Upgrade script doesn't update index keynames
Justin O'Leary
Ex-Project Manager
Ex-Lead Support Specialist

QuoteMicrosoft wants us to "Imagine life without walls"...
I say, "If there are no walls, who needs Windows?"


Useful Links:
Online Manual!
How to Help us Help you
Search
Settings Repair Tool

Grudge

This was purposely done. Whilst I agree that it would be ideal for them to be the same the problem is MySQL does not support renaming of indexes. If we drop and recreate every index it will cause huge potential upgrade problems for large boards such as this as some indexes take, literally, hours to create.
I'm only a half geek really...

rsw686

Quote from: Grudge on April 05, 2008, 02:20:32 PM
This was purposely done. Whilst I agree that it would be ideal for them to be the same the problem is MySQL does not support renaming of indexes. If we drop and recreate every index it will cause huge potential upgrade problems for large boards such as this as some indexes take, literally, hours to create.

Fair enough. Yeah I could see that being an issue on large boards. Just because I'm anal about these things I'll probably fix my board by hand.

Maybe an option to recreate indexes would be nice with a warning that it may take days to complete. ;)
The Reptile File
Everything reptile for anyone reptile friendly

Aquaria Talk
Community for freshwater and saltwater aquariums enthusiasts

metallica48423

Understood.  Bug tracked it to ensure that it was seen :) 

I closed the bug report to reflect the decision on it.

Thanks Grudge
Justin O'Leary
Ex-Project Manager
Ex-Lead Support Specialist

QuoteMicrosoft wants us to "Imagine life without walls"...
I say, "If there are no walls, who needs Windows?"


Useful Links:
Online Manual!
How to Help us Help you
Search
Settings Repair Tool

Advertisement: