Attachments In Message

[kai920]

Was Display.php properly edited? No changes were required from 1.2 on this mod, and I believe that's the part that parses those [attach... ] tags.

Is this a vanilla version of RC2 you're testing on?

[kai920]

Sure, PM me with a test account.

Those mod_aim_xxx errors sounds like it can't find language strings?

You got any other mods installed?

[C4G-TK]

I went ahead and deleted my replies.  I thought your XML was the only edits needed in order to install the MOD, so those were the only edits that I did.  Error in communication.  Will do all the edits and get back to you after my doctor's appt!   Sorry for the confusion!

[NeoXII]

Hi! Great Mod!
why my Attachments in message can't be open with Highslide Image Viewer....

Thank You 

[C4G-TK]

Kai 

In the original mod, for this edit it says ADD BEFORE... but yours says to ADD AFTER.  Could this be why I can't get the mod to work on my site?  Shouldn't it be ADD BEFORE?   I'm going to keep trying to get this working.

This is the edit I'm referring to...
     In your XML:

Code Select Expand

<file name="$sourcedir/Display.php">
<operation>
<search position="after"><![CDATA[
return $output;
}]]></search>

[kai920]

Where did you find that "before"? I just downloaded AttachmentsInMessage.1.3.0___SMF2RC1.zip from the mod site, and this is what it says:

Code Select Expand


<file name="$sourcedir/Display.php">
<operation>
<search position="after"><![CDATA[


And as mentioned, I didn't make any changes to the Display.php edits in the xml file.

[timned88]

i installed this on rc2 using the modified xml file from a few posts previous and now the attachments are rendering twice...
the first time is in the correct location, the second time is where it would show without the mod being used.  please help!

[timned88]

Cool!  Can't wait to check it out. 

[kai920]

Good stuff spuds, I'll test it out.

[C4G-TK]

Thanks Spuds.

Installed and am using on RC2.  Had no errors show in the log. 

Been busy going back through some old posts and changing the codes to [attch in order to show previous attachments though.  This is probably the only thing that I can find as being trouble since this mod doesn't keep the same coding.  If I updated, I probably would have used the same codes in order for it to be backwards compatible with the existing mod.

Nice work and thanks for the work!

[timned88]

i installed it as well.  so far so good.

[Spuds]

Been busy going back through some old posts and changing the codes to [attch in order to show previous attachments though.  This is probably the only thing that I can find as being trouble since this mod doesn't keep the same coding.  If I updated, I probably would have used the same codes in order for it to be backwards compatible with the existing mod.

That sounds a bit odd ... I thought I kept all the same codes as the original mod plus added some new functionality.  If you could provide a link or example post where you had to change things that would be very helpful.   I'll go through the code to see if I made a type somewhere.

I'm also attaching a new revision, you must uninstall the old version and then install the new one.  It has several bug fixes plus some new functionality.  I've been chatting with mouser, the author or the original mod, and have added some things to this version that were available in the original.

o + [attach] tag for quick entry [attach] some text  [attach] some more text is the equivalent of [attach=1] some text [attach=2] some more text.  The mod will always use the next unused attachment, unused being defined as not used by an attach=#.
o + the above quick entry works for all tags [attachurl=1] is the same as [attachurl]
o + check to allow [attach=#1] entries so [attach=#2] is seen as [attach=2]
o ! fixed what [attach=#] should be doing, or was doing?. If there is a thumbnail available [attach=?] will display it as a click-able thumb, if no thumbnail is available it will display the image in full size up to the allowed forum size (if bigger it will be click-able), if not an image just display the url link. 
o + first attempt at updating quoted text that has inline attachment tags to be links back to the post with the attachment or at least the top post.
o ! lost of small fixes that I did not keep track of

[C4G-TK]

http://www.channel4gaming.com/index.php?topic=1047.0

Here's a pic.  The attachments that were in there just show up as words now.  I modify the post and change the code and it shows them again.

[Spuds]

http://www.channel4gaming.com/index.php?topic=1047.0

Here's a pic.  The attachments that were in there just show up as words now.  I modify the post and change the code and it shows them again.

Got it ... I believe what was happening is that you had the configuration setting for max width of posted pictures set to zero (disabled), unfortunately I forgot to check for that variable being empty before using it in validation so it decided that the max image width was zero ... looking at the HTML of your page it looks like the mod did everything it should but the images in that space got set to width=0 doh!

Anyway here is a new version to test 1.02, should clean up that error.

[C4G-TK]

Ohhh, cool deal!
Will look at it tonight when I get ready to do work.
(If I get ready to do work today...lol)

[purper]

Spuds, I need to compliment on you're efforts here! Really good to see someone with knowledge to step in!
Thanks for you're time and help here!

Keep up the good work!

[timned88]

i really do love this mod.  great job once again.

[C4G-TK]

@Spuds

I'm just getting one error.  It isn't a major error pulling.  Just wanted to post it.  Seems to be pulling whether a person is guest or member.

[Spuds]

Thanks for the report, I had noticed the same thing in my logs the other day.  I made a fix and need to go check my logs to see if it fixed it, and if so I'll post an update.

Basically what I think is happening is when you view a post with no inline attachments then the exclusion array ($ila_dont_show_attach_below) is not set so PHP tosses out one of its warnings.

[Tanks]

I need to follow this - will try it out when you post the update