Clickable Avatars

[The Saviour]

Personally I could care less if it was in the package, as long as their is a fix. Its prolly more for the lazy people that can't use a search or read for that matter. But nice to see your updating it, just surprised that it worked with 3.1beta which says a lot about the package all together. Keep up the good work, can't wait what else you bring to the table for mods.

I'm sorry, but I take offense to this...

It's not that anyone is lazy...

If there's a problem with the mod that has been released to the public for use, then the coder should update the mod to fix the issue...not simply post a fix within the thread.

What if the thread becomes 100+ pages long?  Is it up to the "lazy" person to find the fix themselves and then make the correction?

I know these hacks are provided free...but if there's an issue, then the best thing a coder can do is re-release his hack with the update.  List the release log with the hack stating what change was made...thus resolving the issue with less questions cluttering up the thread.

Just my two cents...

P.S.  I had initially installed and uninstalled due to the bar issue, but since the change has been made...I'll try it again.

Thanks for a great mod!

[ccbtimewiz]

It is indeed the mod author's responsilbilty to update their modifications with bugfixes when they are addressed in the support topics. However people do have lives to attend to.

It's only respectful to show consideration for this as the mod authors are not being paid to do their work-- they are contributions to SMF.

[The Saviour]

I understand that these mods are contributed and no one is getting paid for them...

...and I do respect the author and the time it took them to create and submit.

I manage two websites of my own...and contribute to several others...all on my own time.  I ask for nothing in return.

The point I'm trying to make is this...

If you submit a mod as a contribution to the SMF community, you should stand behind your work...and offer support to those who download and install it.  After all..it's those members who use these mods that make them as popular as they are.

So your remark about "showing consideration" is a two-way street...

'Nuff said.

[Simplemachines Cowboy]

Excellent!
Nice mod, works like a charm on 1.1.6

[spearfish]

@The Savior,

If there's a problem with the mod that has been released to the public for use, then the coder should update the mod to fix the issue...not simply post a fix within the thread.....
I know these hacks are provided free...but if there's an issue, then the best thing a coder can do is re-release his hack with the update.

Isn't that exactly what I did?

What if the thread becomes 100+ pages long?  Is it up to the "lazy" person to find the fix themselves and then make the correction?

First, the search button exists for a reason.  Second, I stated in the readme which is displayed as the mod is installed AND when you are downloading the mod that I don't mind PMs concerning support for this, since there really isn't too much that can go wrong.  Also, in my experience people generally look at the first few pages and the last few pages of a very long thread.

This fix was on the first page.  Not to mention, this thread is on pace to hit 100 pages in about... 20 years... because like I said, this is a low support volume mod.  There's not all that much to sift through when looking at issues other people have had.

If you submit a mod as a contribution to the SMF community, you should stand behind your work...and offer support to those who download and install it.  After all..it's those members who use these mods that make them as popular as they are.

I feel like people should accept what they get for free... instead of asking for more.  It is, quite simply, what it is.  If I had sold this mod, the situation would be entirely different and that'd be horrible quality control.

I also disagree on your interpretation of what the mod author is responsible for doing.  Actually, as long as it's distributed through the mod site I believe the onus is on Simple Machines LLC since they are distributing the mod.  Now, we can talk ethics all day long - but in the end, the mod author is, in my eyes responsible for nothing.  The mod team makes sure it is secure, installs, and uninstalls correctly.  And then as long as all of that happens, really you can carry on as you would have before you ever came across the mod.

The end.

[The Saviour]

Look...this wasn't directed at you in particular...

It's funny how some can take offense over the littlest thing.  I was commenting on someone else's comment...and yes...you did a great job with this mod.

Please read my previous posts carefully...and I do agree with you spearfish...to a point.

Again, thank you for a great mod.

[matasanos]

hi all!!!

all works fine for me..except one thing..always in this life theres a thing xD


I have noavatar installed...and i want to implement this modification on it
so i write:

Code Select Expand


                       //No Avatar? Get the default Avatar! (Not that if it does not exist it will grow from some where :P)
                       elseif(!empty($modSettings['attachmentDefaultavatar']))
                                      echo '
<a href="'.$scripturl.'?action=profile;u='.$message['member']['id'].'"><img src="', $modSettings['attachmentDefaultavatar'], '" /></a><br />';`

but this display for everyone (user or guest) a link to the profile...and i want to make this works like with noavatar
and if user_is_logged and other if user_is_guest
if the person is guest..write a url to register page

i have tried...but no luck

[ccbtimewiz]

Try this then:

Code Select Expand

//No Avatar? Get the default Avatar! (Not that if it does not exist it will grow from some where :P)
elseif( !empty( $modSettings['attachmentDefaultavatar'] ) )
echo '<a href="'.$scripturl.'', $context['user']['is_logged'] ? '?action=profile;u='.$message['member']['id'].'' : 'action=register' ,'"><img src="', $modSettings['attachmentDefaultavatar'], '" /></a><br />';

[matasanos]

Try this then:

Code Select Expand

//No Avatar? Get the default Avatar! (Not that if it does not exist it will grow from some where :P)
elseif( !empty( $modSettings['attachmentDefaultavatar'] ) )
echo '<a href="'.$scripturl.'', $context['user']['is_logged'] ? '?action=profile;u='.$message['member']['id'].'' : 'action=register' ,'"><img src="', $modSettings['attachmentDefaultavatar'], '" /></a><br />';

uuuuuu!! thank you!!!
now all works fine
one more time, thanks

[Basie]

The link to this mod does not work.

[ccbtimewiz]

Link fixed.

[jdizine]

I get this error message:
!!Error in Package Installation

At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.

I am SMF 1.1.6.
I did a manual move of my avatars postion. If that makes a difference.

EDIT: It also shows this:
Installing this package will perform the following actions:  Type Action Description
1. Execute Modification ./Themes/default/Display.template.php Test failed

All others passed.

[spearfish]

This mod has been updated!  Finally!
Now works with 2.0 Beta 4 Public.  And it always has worked with 1.1.7, I just never bothered checking.

I am SMF 1.1.6.
I did a manual move of my avatars postion. If that makes a difference.

Yep, that'll do it.  I *believe* (don't shoot me if I'm wrong) that the package manager simply skips a file if the test fails and you override it.  So you could override that, and simply not have the avatar link to your profile in the header --- or you could override and then manually edit Display.template.php.

[editor1]

Hi,
where is the template. file php.. is that on cpanel?
Thanks.

[spearfish]

First.....

Make sure that the package installer doesn't work.  There's two copies of it there - one for SMF 1 and SMF 2.  If something fails, you could *then* consider a manual install - but I'd only suggest that if you know what you're getting into.

Package Manager

[brandonroy]

I have an error on install in my /themes/default/display.template.php file.

Here is the part of that file that I currently have:

Code Select Expand

           // Show avatars, images, etc.?
      elseif (!empty($message['member']['avatar']['image']))
                       echo '
                        <div style="overflow: auto; width: 100%;">', $message['member']['avatar']['image'], '</div><br />';
            }

// Show their personal text?
if (!empty($settings['show_blurb']) && $message['member']['blurb'] != '')
echo '
', $message['member']['blurb'], '<br />
<br />';

// This shows the popular messaging icons.
echo '
', $message['member']['icq']['link'], '
', $message['member']['msn']['link'], '
', $message['member']['aim']['link'], '
', $message['member']['yim']['link'], '<br />';

// Show the profile, website, email address, and personal message buttons.
if ($settings['show_profile_buttons'])

[InsaneneSs]

The mod is working for me but the avatar shows on the left! I have default avatar installed i don't know if it mess with someting or what

I made an exempl on paint, the avatar was supos to be on the middle :S

Someone help me please

[spearfish]

Brandon: Do you know how to do a manual package install?  This one isn't that hard, I'd be able to help you through it.

Became: Is this on a custom theme?  Could you post your Displate.template.php?  - I'll try to take a look.

[InsaneneSs]

yes is cargo from designer studio

thanks for helping

[spearfish]

OK.  I've attached 2 versions of it.  Try Display.template.php first, I think that'll work.  If it doesn't Display.template2.php should work (but be sure to rename it back to Display.template.php!).

Sorry it took so long to get back to you!