Author Topic: Stop Spammer  (Read 836332 times)

Offline live627

  • Developer
  • SMF Hero
  • *
  • Posts: 5,996
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: Stop Spammer
« Reply #2120 on: May 25, 2021, 05:25:45 AM »
I have updated this mod:

- Fixed error message "Undefined index: stopspammer_faildb_sub"
- Changes to make the installation work for version 2.0.17
- Changes to make the mod work with php 7.3
- Fixed: The "Check this member" link was visible to everyone in their own profile. Now it is only visible for moderators
- Added css class to the buttons
- Changed text string "Check these members" to "Check Selected Members"
- Changed text string "Report these members" to "Report Selected Members"
Which files have changed?  need to create an upgrade path for myself because several tests fail when I try to uninstall. My goal here is to eliminate  all failed tests from the dozens fo mods installed since 2011.

Online GL700Wing

  • Charter Member
  • Sr. Member
  • *
  • Posts: 730
  • Gender: Female
    • GL700Wing on GitHub
Re: Stop Spammer
« Reply #2121 on: July 06, 2021, 07:09:52 AM »
I have been struggling for hours today to get version 2.4.0 of this mod installed on four different forums (all on different shared servers) which have all been running version 2.3.9 without any issues.

The package file would upload without any issues but the installation kept timing out after 30-40 seconds when I clicked on the 'Install Mod' button in the Package Manager - no error messages logged in the forum, the system error log or the cPanel error log.  Weirdly I could reinstall version 2.3.9 immediately and without any issues on all four forums ...

I persisted with installing version 2.4.0 and basically I had to click the 'Install Mod' button in the Package Manager multiple times before the 'Install Mod' screen would display and even when it did there was sometimes an 'Modification parse error' error display for each of the package XML files (see attached image) - when this happened I then had to refresh the browser screen several times before the 'Modification parse error' error would disappear after which the mod would install within a couple of seconds without any further issues.

Having finally got version 2.4.0 installed on all four forums I then decided to try and work out what the difference was in the installation process for version 2.3.9 compared to version 2.4.0 and I discovered it was actually the 'readme' file for version 2.4.0 that was causing the timeout issues.

To show the supported languages the 'readme' file for version 2.4.0 loads the following 25 country flag image files from the Simple Machines website and I'm guessing the timeout issues are occurring because my forum servers are on the other side of the world - and across a very large, deep, and watery ditch - from the Simple Machines servers.

This is the code from the 'readme' file for version 2.4.0 that is causing the installation timeout issues:
Code: [Select]
[tr][td][b]Languages:[/b][/td][td][img][/img] [img][/img] [img][/img] [img][/img] [img][/img] [img][/img]
[img][/img] [img][/img] [img][/img] [img][/img] [img][/img] [img][/img]
[img][/img] [img][/img] [img][/img] [img][/img] [img][/img] [img][/img]
[img][/img] [img][/img] [img][/img] [img][/img] [img][/img] [img][/img]
[img][/img] [/td][/tr]

By comparison, the 'readme' file for version 2.3.9 does not load these images which probably explains why I was able to reinstall that version quickly and without any issues.

I strongly recommend that the 'readme' file for this mod be updated to simply list the supported languages rather than showing the country flags ...

That's about four hours of my life I'll never get back ...
Life doesn't have to be perfect to be wonderful ...

Offline landyvlad

  • Sophist Member
  • *****
  • Posts: 1,011
  • Gender: Male
    • Michael Reed on Facebook
    • GSX1400 Owners ORG
Re: Stop Spammer
« Reply #2122 on: July 13, 2021, 01:47:35 AM »
I've asked a general question elsewhere - but is there any chance of a 2.1 version being developed for this mod?
Please do not PM, IM or Email me with questions on astrophysics or theology.  You will get better and faster responses by asking homeless people in the street. Thank you.

To paraphrase Kindred: "There are no technical solutions to social problems."

Offline Alpay

  • Language Moderator
  • SMF Hero
  • *
  • Posts: 3,655
  • Gender: Male
  • test
    • Personal Web Page
Re: Stop Spammer
« Reply #2123 on: July 18, 2021, 10:52:22 AM »
   Very nice mod.. How can scan all members at once?

there is no way to do that....    and submitting 4000 pages of requests (at 50 per page, that would be 20,000 requests) would probably be a violation of the SFS database ToS. (In other words, don't do it... don't try to do it)

though a trigger would slowly test the back road with a worklist ?
maybe ... Forum Maintenance?
« Last Edit: July 18, 2021, 11:08:08 AM by Alpay »