Glossary

[Kindred]

did you do all of the database edits?

[Bancherd]

I finally got 2b3 to work with a fresh install of RC1+PortaMx on my local box(xampp+xp).

It appears that the program generated "word" in the database table _glossary_groups instead of "title".

I deleted the table and regenerated it using

Code Select Expand

CREATE TABLE `smf_glossary_groups` (
  `id` int auto_increment,
  `title` varchar(50) NOT NULL,
  PRIMARY KEY  (`id`)
);
per above instructions....

It worked! 

A little problem though, it does NOT work if I used "Post new Poll"; however, it will work with my subsequent post/answer in the poll.

I also got undefined index errors while working with defining categories, etc.  Some of the errors are:  glossary_group_error_submit, glossary_error_submit, glossary_action_status, glossary_update_group_error_submit, etc. 

Looked like I am missing some files?

[slinouille]

Hi!
You are right, my installdatabse.php file is bad ... I'm confused 
I've mixed up "word" and "title"!
I'll correct that in 0.2b4

I also got undefined index errors while working with defining categories, etc.  Some of the errors are:  glossary_group_error_submit, glossary_error_submit, glossary_action_status, glossary_update_group_error_submit, etc. 

Looked like I am missing some files?

No no files are missing ... it's "old" definition I was using in temporary releases !
I'll do a chech of that and will clean them

A little problem though, it does NOT work if I used "Post new Poll"; however, it will work with my subsequent post/answer in the poll.

Do you mean that glossary tooltips are not available in a Poll ?

[Bancherd]

Do you mean that glossary tooltips are not available in a Poll ?                      

I take it back....it works perfectly in poll.     I must have done something wrong. 

[slinouille]

beta4 is uploaded ... I really hope this one is the good one ... I've taken time to check some differents aspects that where curious when managing groups.

Just uninstall previous beta and isntall this new one 

[PfalzNacht]

Thanks!

Have you make changes in the database tables?

[slinouille]

Thanks!

Have you make changes in the database tables?

Just use your phpmyadmin to access "smf_glossary_groups" and change name of field "word" to "title"

[PfalzNacht]

The field was already "title", and it works since 0.2b2. 

[slinouille]

So it's ok ... use new 0.2b4 ... I think it's the good one

[ianus]

Greetings!

Thanks for the update.

Testboard: Fresh install of SMF2rc1 (+new database)
Glossary installs without problems.

Add words:
1.) Now I can chose a category while creating a new Glossary word. (nice!).
1.2.) But I'm not forced to set a category (while creating)
2.) I'm forced to set a category when I want to edit a word.

In my opinion, this could lead to confusions.
I think the user should be forced to set a category while creating a word (1) or the edit shouldn't require a category (2).
Maybe a "not categorized words" category is a good idea. This way a word is always categorized.

Add Glossary word to a thread:
While bold, italic and strikethrough are shown correct, others are breaking the function.

The first word inside bb-code that isn't working become the new G-word, the one that is in the Glossary becomes part of the post: ">codetest2
(Temporary example link: http://resmedia.info/smf21/index.php?topic=2.0)
bb-code inside the Glossary is working very well.

Mmh, I hope you understand what I am talking about.

[Garry1953]

Unfortunatley I'm still getting the same error using Glossary_0.2b4.zip when upgrading from previous Glossary v1.8.

However, when doing a clean instal on RC1, 0.2b4 works perfect.

Code Select Expand

Table 'xxxxxx_smf.glossary' doesn't exist
File: /home/xxxxxx/public_html/art-forum/Packages/temp/installDatabase.php
Line: 80 .

[Kindred]

yup...   still remove the call for installDatabase.php from the packageinfo.xml file and do the database edits manually...


The method used to create the tables in this mod is not supported on RC1

slinouille,

Odd behavior
http://www.40konline.com/community/index.php?action=glossary

some of the columns are correctly spaced, others seem to collapse
Look at I, J, K, N, O and W as compared tothe other letters.

I also notice that b4 is still not using theme specific CSS... so those of use with 1 dark and one light theme are in a bind.
(note: fixed on my installation by editing default_theme_url to be theme_url in glossary.template.php and load.php)


edit: Installed the new version.
The following errors:

Code Select Expand


http://SITE/index.php?action=glossary 
8: Undefined index: edit_group
File: /SITE/Themes/default/Glossary.template.php
Line: 112 

http://SITE/index.php?action=glossary 
8: Undefined index: enable_groups_in_glossary
File: /SITE/Themes/default/Glossary.template.php
Line: 86 

http://SITE/index.php?action=glossary 
8: Undefined index: 0
File: /SITE/Sources/Glossary.php
Line: 442 

http://SITE/index.php?action=glossary 
8: Undefined index: sa
File: /SITE/Sources/Glossary.php
Line: 335 

http://SITE/index.php?action=glossary 
8: Undefined index: action_on_word
File: /SITE/Sources/Glossary.php
Line: 218 

Also lines 202, 186, and 170



-edit further-

I recommend making a setting in the admin tool that allows you to define the default state of "show in message instead of forcing it to 1 (on)
I modified mine directly in the database to default it to 0 (off)

Also... the glossary options are getting enough that I would suggest creating a new glossary section under modifications rather than having them in the modifications toplevel.

hmmm.... looking in the database, how is the field "identical to" used?   It looks to be helpful for multiple entries referencing the same thing (i.e. "TWSS" is identical to "That's What She Said" but would get two separate entries)  but I don't see any way to USE that field.

[Bancherd]

I also notice that b4 is still not using theme specific CSS... so those of use with 1 dark and one light theme are in a bind.
(note: fixed on my installation by editing default_theme_url to be theme_url in glossary.template.php and load.php)

Thanks...I was trying to figure out how. 

[Kindred]

you will also have to make copies of the 3 css files in your alternate themes CSS directories.

[Rockas]

I'm having a problem with this fabulous mod.
if you have a word inserted which description contains another word inserted, the display in a topic gets screwed up.
ex.
Words inserted:

BUP: A bup file is a Back UP file of an IFO file. These files are commonly found on DVDs.

IFO: InFOrmation file commonly found on DVDs. Such files contain navigational information for your DVD player.

with those two inserted when you type BUP in a topic you get as result...

IFO file. These files are commonly found on DVDs.">BUP

Any clues to solve this?

thank you for the fantastic Mod.

edit: Typos

[slinouille]

@Kindred: many thanks for your ideas and recommandations, I'll take them into consideration for next release (I've got much work those days, so that I didn't take time for the Glossary).
Concerning field "identical to", your right it's exactely for what it should be used ... but I decided to put that on side for the moment (perhaps in a future version when the actually functions will be okay )

@Rockas: rhhaa ... I thaught I corrected that!!! I'll do some over tests ... in order to correct that in a next release.

[Rockas]

@slinouille
Any estimated time to have that glitch solved? :-)
It would be a bit frustrating adding BBC tags to all the key words inside the definitions (as my under construction forum deals with lots of connected terms) if only for a couple or days or so :-)

[slinouille]

@slinouille
Any estimated time to have that glitch solved? :-)
It would be a bit frustrating adding BBC tags to all the key words inside the definitions (as my under construction forum deals with lots of connected terms) if only for a couple or days or so :-)

I'll upload next release this evening or tomorrow.
Nevertheless if you can't wait  , you can do next modification manually
In Sources/Subs.php, find and replace

Code Select Expand

// Do the Highlight in the message
            $message = preg_replace(
                '/((<a.+/a>)|(('. preg_quote(strtr($word, array(''' => ''')), '/'). '(?=[^A-Za-z0-9&agrave;-ÖØ-öø-ÿ_-s])))|('.preg_quote(strtr($word, array(''' => ''')), '/').'$))/'. (!empty($modSettings['glossary_none_sensitive']) ? 'i' : '') .'e' ,
                "'$2' == '$1' ? stripslashes('$1') : '<span class="glossary" title="".addslashes($definition)."">$1</span>'",
                $message,
                (isset($modSettings['glossary_unique_word']) && $modSettings['glossary_unique_word']==1)? 1 : -1
            );
by

Code Select Expand

// Do the Highlight in the message
            $message = preg_replace(
                '/((<span.+/span>)|(('. preg_quote(strtr($word, array(''' => ''')), '/'). '(?=[^A-Za-z0-9&agrave;-ÖØ-öø-ÿ_-s])))|('.preg_quote(strtr($word, array(''' => ''')), '/').'$))/'. (!empty($modSettings['glossary_none_sensitive']) ? 'i' : '') .'e' ,
                "'$2' == '$1' ? stripslashes('$1') : '<span class="glossary" title="".addslashes($definition)."">$1</span>'",
                $message,
                (isset($modSettings['glossary_unique_word']) && $modSettings['glossary_unique_word']==1)? 1 : -1
            );

I also notice that b4 is still not using theme specific CSS... so those of use with 1 dark and one light theme are in a bind.

I don't see what you mean exactly? ... I'm not an expert in SMF 

[Rockas]

hummm... i get an error

Code Select Expand

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')' in /home/content/d/a/u/daudiok/html/forum/Sources/Subs.php on line 4142

I don't have a PHP editor here in the office, tried to visually find the missing ')' but couldn't find it... a lot easier when text gets different colors lol

[Kindred]

slinouille,

What I mean is that the mod, as installed ALWAYS uses the default_theme_url/css/CSSFILES

What it SHOULD use is theme_url/css/CSSFILES

it is then up to each admin to make updates for any theme specific changes to colors, etc.

i.e. I have one light theme and one dark theme.
Your default CSS works perfectly well on the dfeault/light theme
it looks horrible on the dark background theme...   

I need two different CSS versions, so I had to go in and change the default_theme_url to be theme_url and add the glossary CSS files into my CUSTOMTHEME/css folder in order to correctly support the two different CSS versions.