Bookmark Mod

[Leipe Po]

nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss

edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?

[winrules]

nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss

edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?

Could you upload it to your own site so we can use it before it's approved?

[JayBachatero]

nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss

I ask because I am having the same problem when I create an archive on Linux.  When passed to SMF it creates an empty file.  Owdy had the same problem with one of his theme.

edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?

No I have't looked at it.  Can't download it till it's approved.  Looking good though.

[Leipe Po]

nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss

edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?

Could you upload it to your own site so we can use it before it's approved?

well i could do that, but whats the point to having sutch a system at smf,
this is my first mod that gets released, that why i am that ciorious of how they like the coding, and thats also the reason that i dont release it on my site, i dont want you getting hacked and its my fault,
when i get more confident that my coding style meets smf standarts, i will pre-release mod(have some big ones in mind), but this as a first timer... nah...

[Goosemoose]

This mod has been approved and can be viewed here: http://mods.simplemachines.org/index.php?mod=350

Leipe Po, I fixed the bookmark.php problem. I fixed a few things so I'm not exactly sure what it was that fixed it. I believe it was the fact that your mod was within a folder in the zip. You were also missing CDATA for your readme inline. Anyways, it looks great, installs great, and I will be putting it on my own board soon

[Goosemoose]

One more thing. You should think about making it look similar to the notifications page, and increase the font size for the second column.

[Leipe Po]

what do you mean, that its asks if you really want to add a bookmark? before its added?

thank you allot for fixing up some stuff, never thought that its creates a new folder for it, but glad its just a simple thing!!!, what other stuff did you changed? i'm curious!!! 

but hey, my first mod is approved!!!! thanks allot, this calls for a little celebration!!!!

*Leipe_Po does the happy dance*

[sbarnes]

What a great mod, works really well apart from one main problem on my setup. Not sure if this a problem with the mod or a conflict with one of many other mods.

When I add a topic to the bookmarks, it adds the first post and also all replies to that post. So for a topic that has say 20 replies, I get the first post plus 20 RE: the first posts in the bookmarks.

If I can get that sorted I would be very pleased. Any ideas?

[Leipe Po]

ife replyed to your post on the mods and packages board, pleas adress the post there 

[kriskd]

Leipe Po -- congrats on completing your first mod!

Goose Moose -- your link to the mod didn't work for me. 

[Leipe Po]

yeah i accedenly deleted the mod, yeah i know, how stubid can you be, huh?

my greatest appologies, there were some bug's that needed sorted out, they are now corrected(version 1.2)
only dont know if they can un-delete it,

sorry for my n00bie-ness,

Leipe_Po

[Leipe Po]

i am really sorry for bouncing a topic this early,
but could somebody correct my mistake, i cant, cause i dont have right, or should i submit it again to the mod site?, cause now people have buggy bookmark, not just me 

[Thantos]

Restored.

[Leipe Po]

thank you, i you were i woman, i would kiss you!!! 

[sbarnes]

Excellant, works a treat. Thanks for your hard work.

[Leipe Po]

no problem, just wait whats comming!!!!
i should be carefull not to make it to bloated....

[Goosemoose]

Leipe Po, all the changes where in the main package file. Just compare it to your version.

[Leipe Po]

thank you Goosemoose and Thantos for your support!!!,
if you dont mind, i like to stay a while here if thats ok with you guy's 

[Thantos]

I dunno.... Did you bring ale and wenches?

[Leipe Po]

I dunno.... Did you bring ale and wenches?

what is ale and wenches?

i can code, and donate some good italian wine and food....



.... and cookies offcource