Signature Image Rotator

[OnlineFunCorner]

I Got The Solution
It Was A BUG
After A Long & Difficult Search
May Be It Helps Somebody Else
---
http://dev.simplemachines.org/mantis/view.php?id=3848
---
Thanks To SMF Team

[SoLoGHoST]

Hey Dr.IT, just want to note that this is an actual SMF Bug, as you have already linked to above, and doesn't relate at all to this mod.  Signature Image Rotator does not effect any of the BBC Tags and how they work within SMF.

Cheers

[OnlineFunCorner]

Thanks
I Realize It

[MLM]

Does this work on a custom theme?

I installed with no errors and enabled it. I put the code in my signature but get a broken image link..

They tell me to put this in my signature:

Code Select Expand

[img]http://www.madlittlemods.com/forums/index.php?sigrotator=mysig;sig=11288305008;name=MadLittleMods[/img]

[SoLoGHoST]

Yes, this mod should work fine in custom themes.  Are you having problems with this mod in ONLY this theme?  Make sure you have images uploaded into the Signature image rotator also.  Also try changing the setting for this to different options, such as user id or username and Remove all images and try again.  Make sure that the PERMISSIONS are also set correctly for this as well.

[MLM]

I can set my images and it gives me the code to put in my signature but it doesn't work. I am the admin and so I have all of the permissions. I have not tried it on other themes..

I have tried change the username, etc setting with no luck

I am not sure about the theme thing..

[MLM]

anyone?

[SoLoGHoST]

Well, you can try opening up SignatureImageRotator.php and there are many calls to the justDie(); function within the SigImageRotator() function.

You can begin removing these one at a time until it begins to work for you.

Note:  Removing these can cause security flaws in this mod.

Eventually, you should find the one that was causing the problem for you.

Good Luck, and if you find the one that was the problem, please post it up in here to let us know.

Cheers

[SgtMic]

Update for RC4?

[GazOutEast]

Echo SgtMic

Call for RC 4 version please

[SoLoGHoST]

Done!

[GazOutEast]

Thanks, but .....

http://custom.simplemachines.org/mods/index.php?mod=1851 is not showing the file for download - it's just blank

Edit - now it's showing

Thanks for that

[SoLoGHoST]

Was a small glitch while uploading the file the 1^st time, had to re-up it again.

Cheers

[Bugo]

I have found hardcoded text in package.

sigrotator.xml:
Line 401:

Code Select Expand


echo ' and/or ' . $txt['sig_rotator_max_height'] . '<b>' . $context['rotate_signature_limits']['max_image_height'] . '</b>px';

' and/or '

SigRotator.template.php:
Line 25:

Code Select Expand


<input type="submit" value="Yes" />&nbsp;&nbsp;&nbsp;<input type="button" value="Cancel" onClick="javascript:history.go(-1)" /></center>

"Yes" and "Cancel"

Please fix it

[SgtMic]

Done!

Awesome!! Thanks.

[SoLoGHoST]

Thanks Bugo, you're the BEST!  Getting on it now.

Cheers

[SoLoGHoST]

Ok, updated it with the hard-coded strings removed and placed into $txt variables.  Also restructured the language strings into their own files.

Cheers

[Bugo]

Thanks for cooperation Russian language files in attachments.

[SoLoGHoST]

Thank You very much!

Though in the russian.xml and russian-utf8.xml, you are missing this $txt variable for SMF 2.0 RC4 (which was an RC4 added option):

Code Select Expand

$txt['signature_allow_smileys'] = '<span style="padding-left: 8px;">Allow smileys in signatures</span>';

Should be just above $txt['signature_max_smileys'].  I like the concept of what you did actually, by placing it at the END, overwriting the current one's in there.  Actually never thought of that, and than applying the comment // Signature Image Rotator to it so that it knows how to remove it when uninstalled.  I like your style

Anyways, I have separated these into separate language files if you noticed (english_2.0.xml, english_rc4.xml, and english_all.xml) simply because RC4 has that added string that also needs to be changed so that it has the <span style="padding-left: 8px;"></span> surrounding it.

Would be best to make that 1 edit it a separate file for RC4 IMO.  Perhaps you can just do what I did and supply 3 of regular and 3 utf, like this:  russian_rc4.xml, russian_all.xml, and russian_2.0.xml and just make them exactly like I have it, but I actually like the way you apply it to the END of the ManageSettings.[language].php file much better than the way I use the replace on it.  Will have to update my english files in the same manner.

Thanks

[Bugo]

Though in the russian.xml and russian-utf8.xml, you are missing this $txt variable for SMF 2.0 RC4

Added.

I like the concept of what you did actually, by placing it at the END, overwriting the current one's in there.  Actually never thought of that, and than applying the comment // Signature Image Rotator to it so that it knows how to remove it when uninstalled.  I like your style

Ok. Do likewise