• Welcome to Simple Machines Community Forum. Please login or sign up.
December 04, 2021, 08:47:20 PM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


Tidy Child Boards

Started by Arantor, December 09, 2009, 04:00:36 AM

Previous topic - Next topic

Kimmie

k i uploaded it, and it said it uploaded fine, however, its not giving me an option to apply it:

http://i46.tinypic.com/2ik9wef.jpg


Arantor

No, because the version numbers are all geared to 2.0 RC2; I never tested it on 2.0 RC1.2 and never wrote it explicitly for it. It's just a happy by-product that the edits should be the same.

If you use the Advanced option in the lower right corner and supply 2.0 RC2 as the version to use it will probably work.
No good deed goes unpunished
All helpful urges should be circumvented

Kimmie

k I did that. When I go to apply it, I get test failed's on these two files:

7.   Execute Modification   ./Themes/core/BoardIndex.template.php   File not found
8.   Execute Modification   ./Themes/core/MessageIndex.template.php   File not found


It should still be ok tho right? (just wanna make sure, I dont want to screw my site up)  :)

Arantor

o.O I thought I made those edits optional.

It's absolutely fine to proceed if those files are not found. On RC2+, the old default theme is in Themes/core - but on RC1.2 that isn't the case of course.
No good deed goes unpunished
All helpful urges should be circumvented

Kimmie

I got everything done, all edits on my custom themes done, and everything works GREAT!!!!!!!!!!!!!


I love you I love you I love you I love you I love you I love you I love you I love you I love you I love you I love you I love you I love you I love you I love you



Arantor

Just glad it works out the way it's meant to :)
No good deed goes unpunished
All helpful urges should be circumvented

Sabre™

Do NOT give admin and/or ftp details to just anybody, see if they are trust worthy first!!  Do your homework ;)


coldy316


      arantor sent you that pm that you wanted....
Would you believe it that i live in gods country
Australia

Arantor

No good deed goes unpunished
All helpful urges should be circumvented

coldy316

Quote from: Arantor on December 10, 2009, 03:15:49 AM
And I replied :)

There was no problems at all with the install at all, didnt come up with any errors. just had trouble
locating where to activate the mod at the time... lol
Would you believe it that i live in gods country
Australia

Arantor

The mod is working precisely as it should. I can't be responsible for a) browser quirks due to CSS not related to my mod, b) use of 4 columns on boards with long names (which cannot ever actually be fixed without screwing the rest of the layout anyhow), c) you having it set to 3 column (since in the source, the relevant code was showing 33% width)
No good deed goes unpunished
All helpful urges should be circumvented

Sabre™

Closing the img tag and adding alt"" will validate it.
<img src="', $settings['images_url'], '/', ($child['new'] ? 'on' : 'off'), '.gif" width="12" height="12" alt="" />
Do NOT give admin and/or ftp details to just anybody, see if they are trust worthy first!!  Do your homework ;)


Arantor

Does it not pass validation? :o

* Arantor was sure he put that in.
No good deed goes unpunished
All helpful urges should be circumvented

Sabre™

Just a simple miss for the 1.1.x version

EDIT: in both
Do NOT give admin and/or ftp details to just anybody, see if they are trust worthy first!!  Do your homework ;)


Arantor

Confirmed for all three supported themes.

Fixed in version 1.1 :D as well as adding 2.0 RC1.2 support :D
No good deed goes unpunished
All helpful urges should be circumvented

coldy316

Hey if it wasnt for arantor we wouldnt be able to do this. it works fine in 3 column
Would you believe it that i live in gods country
Australia

Sabre™

Quote from: coldy316 on December 10, 2009, 03:35:52 AM
Hey if it wasnt for arantor we wouldnt be able to do this. it works fine in 3 column

People have been doing it for years buddy, it's just great that Arantor found a little time in between his 'record spam post' session(s) to package it ;)
Offline these days mate?
Do NOT give admin and/or ftp details to just anybody, see if they are trust worthy first!!  Do your homework ;)


Arantor

Actually I didn't just package it, this is a fresh build entirely, pushing some of it to Sources so it is easier to install on multiple themes.

As for offline, yeah, means I get less PMs. I'm now in the bracket of 1-5 unsolicited per day, which I'm more than happy with.
No good deed goes unpunished
All helpful urges should be circumvented

Sabre™

Quote from: Arantor on December 10, 2009, 03:42:52 AM
Actually I didn't just package it, this is a fresh build entirely, pushing some of it to Sources so it is easier to install on multiple themes.

Indeed. Actually meant the column display/layout of child/sub boards has been done, not the way you've offered it. ;)

Quote from: Arantor on December 10, 2009, 03:42:52 AM
As for offline, yeah, means I get less PMs. I'm now in the bracket of 1-5 unsolicited per day...

lol
Do NOT give admin and/or ftp details to just anybody, see if they are trust worthy first!!  Do your homework ;)


Arantor

Well, yeah, it has but the previous version didn't offer 4-column (which to be fair isn't useful all the time), nor did it let you configure too much, whether you want the [new] or not, bold or not etc.

To be honest, I mostly did it because people kept asking me where the original mod went, and it seemed easier to just make a brand new one than to either keep explaining why I removed the original mod package, or to try and fix its code.

Earlier in the year I was receiving over 50 a day unsolicited PMs. I don't mind people PMing me when I've asked them to do so, or if it's something specifically useful or interesting (e.g. someone PM'd me recently to throw me a link to a plugin for phpBB I'd expressed interest in, but a prebuilt package that had the plugin preinstalled), but PMing me for support, or to bump a topic, is very likely to be ignored and deleted.
No good deed goes unpunished
All helpful urges should be circumvented

Advertisement: