News:

Wondering if this will always be free?  See why free is better.

Main Menu

Conversion worked well.. but some small errors...

Started by roomeat, December 10, 2009, 03:57:04 AM

Previous topic - Next topic

roomeat

Quote from: Norv on December 17, 2009, 05:01:02 PM
Quote from: roomeat on December 17, 2009, 08:40:02 AM
Why would it be having these issues now.. when the original script went through without errors.. except for the slash's and smilies??

These errors appear because, very unexpectedly for the converter script, your database contains now some NULL values for fields which were filled before. Like, some posts have no value as to who modified the post last time. All your posts must have had such information before, when it all worked with no fatal errors, now some posts don't. I have no idea if that means invalid values for phpbb3, perhaps phpbb3 is happy with them, it could be that a user account was deleted, not sure. But they're most probably rare, probably never seen before in a conversion of phpbb3 to SMF 2.0, otherwise they would have been reported before.

Hmmm.. OK... I just done a couple more tests.

Test 1
Fresh SMF install, Fresh phpbb3 DB backup, and the convert script from the download section here.
Installed fine and converted without any errors except for the smilie and / issues

Test 2
Fresh SMF install, Fresh phpbb3 DB backup, and the convert script you have attached to this thread.
Gets to http://www.ozsuperbikes.com/convert.php?step=1&substep=19&start=59000   and stops with the error:
The database value you're trying to insert does not exist: poster_name

So the only difference between tests is the convert script.. one works fine (except for the original issues) and the modified script fails.
Now the only difference between those scripts was the line "$ignore_slashes = true;" that you added

I also done some searches on my phpbb3 database to find any NULL values.. but did not find any.

Do you still think it's empty values in the phpbb database??  Can you tell me what table some of these NULL values might be in, so I can check??
We were not given dreams, without also being given the power to achieve them.

Norv

Quote from: roomeat on December 18, 2009, 03:42:21 PM
I also done some searches on my phpbb3 database to find any NULL values.. but did not find any.

Do you still think it's empty values in the phpbb database??  Can you tell me what table some of these NULL values might be in, so I can check??

Yes, surely. The SMF 2.0 database framework is the only one affected by NULL / empty values, SMF 1.1.x sends them directly to the database as empty strings ('') while SMF 2.0 attempts to verify their validity and so on, and does *not* accept NULL/empty string values.

By NULL/empty values, I mean records with no value in the corresponding field(s), or NULL values.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

roomeat

Quote from: Norv on December 21, 2009, 02:09:26 AM
By NULL/empty values, I mean records with no value in the corresponding field(s), or NULL values.

Yes thats why I asked... As the phpbb table columns that seem to be playing up do NOT have any NULL/empty values.
Havent tried smf1.1  but the original smf2.0 converter runs through without problems.. except for the original errors with / and the smilies
We were not given dreams, without also being given the power to achieve them.

roomeat

We were not given dreams, without also being given the power to achieve them.

Norv

Ah, I see. I read your post wrong, I thought you tried SMF 1.1.x. I'll try to double-check, though this is strange.

Please also :
Code (find) Select

CASE p.post_edit_user WHEN 0 THEN 'Guest' ELSE m2.username END AS modified_name

Code (replace) Select

CASE p.post_edit_user WHEN 0 THEN 'Guest' ELSE IFNULL(m2.username, 'Guest') END AS modified_name
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

roomeat

Just running through that now.. will let you know how it goes :)
OH.. and I must apologize..  In my phpbb_users table, I have quiet a few rows that don't have email addresses or passwords but they do have usernames. These are all the search engine spiders.
We were not given dreams, without also being given the power to achieve them.

Norv

Quote from: roomeat on December 21, 2009, 04:07:58 AM
In my phpbb_users table, I have quiet a few rows that don't have email addresses or passwords but they do have usernames. These are all the search engine spiders.

Aha. Clearly, the converter should be able to work normally with those too, perhaps importing them as spiders if possible (SMF 2 has as core feature handling spiders). Is this core feature or a mod in phpbb? In any case, the converter should not fail.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

roomeat

the spiders are standard in phpbb3.
The converter (withh all the mods in this thread.. has worked fine this time :)
slash's are gone and smilies look like they will work as soon as I add all my extras back in to smf :)

Now I just have to figure out how to get rid of some other code from a phpbb mod..

I have a heap of posts with video links like the following:
[BBvideo 425,350:19kg1xnn]http://www.youtube.com/watch?v=-zHVW7Zy_vg&NR=1[/BBvideo:19kg1xnn]

need to know how to get rid of the first and last bits.. through phpmyadmin I would guess..
We were not given dreams, without also being given the power to achieve them.

Norv

I will have to ask again: :)
Is this a core feature or a mod in phpbb? (the [BBvideo] tags). I think I found a mod somewhere related to youtube when I used to test more phpBB but honestly I don't fully remember. (perhaps it was phpbb2 anyway)

So if it keeps the URL only, with no tags, it's an acceptable solution?
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

roomeat

Hi Norv. It's a mod for phpbb  called ABBC3 http://www.mssti.com/phpbb3/viewforum.php?f=21

Yes.. if I can get rid of everything and leave the URL that would be great
We were not given dreams, without also being given the power to achieve them.

roomeat

Hmmm.. after checking some posts.. it seems the slashes are still there :(
We were not given dreams, without also being given the power to achieve them.

Norv

Can you please tell the content of one of those posts as it was saved in phpbb3 database? I'm afraid I cannot reproduce it anymore, I'm not sure what content I should try.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

roomeat

I'm going to try one more completely fresh install / conversion tonight and see how it goes.. but if all else fails.. would a copy of my database be of any use to you??

I sort of knew it was going to be a mission to convert as my site originally started out as postnuke with the ported phpbb, then I converted it to the full phpbb then upgraded to phpbb3 lol
And on top of that I had quite a few mods installed.. :(
We were not given dreams, without also being given the power to achieve them.

roomeat

OK.. Seems the actual post content has been converted correct.. but any member signatures are still shown as \'  and so are the actual forum titles.
We were not given dreams, without also being given the power to achieve them.

roomeat

tried another test today.. converted to SMF1.1.11 then upgraded.
Seems to do a cleaner job apart from being missing avatars and smilies.
Would still like the converter to work better so I can upgrade straight to SMF2.0
We were not given dreams, without also being given the power to achieve them.

roomeat

OH.. Even converting to SMF1.1.11 still gives me the "Last Edit: January 01, 1970, 10:00:00 AM by membername"
But it only appears on posts that HAVE been edited.. not on EVERY post like the 2.0 converter.
Is the converter not able to keep the correct edit dates??
We were not given dreams, without also being given the power to achieve them.

roomeat

Hmm.. Just noticed also that the 2.0 converter has lost posts.. wheras the 1.1.11 conversion has not.
We were not given dreams, without also being given the power to achieve them.

Norv

To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

roomeat

#38
My Apology.. it was actually the theme I am testing on one of the conversions. It wasn't displaying the page number to be able to see the other posts.  :-[

So really.. only the following issues need to be sorted for me to be able to convert my live site:

1. Slashes still being shown in forum titles and descriptions
2. Slashes still being shown in member signatures
3. Last edit being shown on EVERY post.. but it's being displayed as ""Last Edit: January 01, 1970, 10:00:00 AM by membername"" (even for enything that has not actually been edited.. it shows this date)

They are probably the bigest things I can think of at the moment that are issues with converter.
Below is a couple of other issues.. probably only problems with my forum due to phpbb mods that I have been using.
1. I need to get rid of bbcode that is currently wrapping around urls to videos. (example given earlier in this thread)
2. Need to get rid of bbcode from signatures. I currently have a [img2] bbcode that restricts the size of images.. but I dont need that in SMF.
We were not given dreams, without also being given the power to achieve them.

roomeat

OH.. and if you ever want to follow along with my testing.. My test conversion can be seen at www.ozsuperbikes.com (SMF2.0 conversion) and www.ozchopper.com (SMF1.1.11 conversion)
Both the above sites are just testing purposes only at the moment.. although I might one day make them real sites lol
We were not given dreams, without also being given the power to achieve them.

Advertisement: