Highslide 4 SMF

Started by Spuds, May 01, 2010, 01:03:29 PM

Previous topic - Next topic

Spuds

#160
Here is a new file for you to test, I was able to reproduce some of the errors you were seeing and found a couple of things which were like likely problem .... Just replace the hs4smf-Subs.php file in your sources directory with this one and let me know what you find.

Eudemon

tested... still producing the same errors

Spuds

Please post the exact [img tag as is in that post

Eudemon

#163
[img width=102 height=160]http://i282.photobucket.com/albums/kk241/Eudemon_Randy/A11821-7.jpg[/img]

again, all the images in child board won't slide
maybe something has to do with message.template?

and still aeva is doing those extra pop ups

do u have these errors, or is it just me?

tested in default theme, got the same problems

Spuds

Strange ... just tried that on my test forum and it expanded just as it should with that IMG link ... don't know what else to tell you to try at this point  :-X

I've re-attached the file in the previous post in case I attached the wrong one last time, don't know what else to try

Eudemon

 O:) oh it's working now with ur re-attached file

both errors fixed

it didn't work bcuz i used the wrong one u attached

anyways, good job man

Spuds

 :D  awesome .... I must have uploaded the original file or something, it should also work (oh please) correctly with Aeva as well ...

Eudemon

yea, the aeva problem is fixed too

but unfortunately i found a new bug regarding to aeva
the images are not resized with respective width and height
all the images in aeva are little too wide

jdev21

#168
Thank you for making this amazing mod. It is working great except for one problem. When I attach an image that is scaled by its height, highslide (or smf) is creating the right size thumbnail (by height) but its displaying the thumbnail stretched by the width. I have been setting the max height to 50000 so that it only scales by width but it is making for some very long thumbnails. Any way to fix this?

Aside from that there is one modification I would like to do to this mod but I need help. I would like the images to clickable twice for full zoom rather than to close the image. Here is the example:
http://www.roadrash.no/hs-support/example-expand-twice.htm

I have added:
// Expand the extra large image when clicking the expanded image
hs.Expander.prototype.onImageClick = function() {
          if (this.custom) {
             hs.expand(this.content, { src: this.custom.large, allowSizeReduction: false });
             return false;
          }
       };

and
hs.registerOverlay({
html: '<div class="closebutton" onclick="return hs.close(this)" title="Close"></div>',
position: 'top right',
fade: 2 // fading the semi-transparent overlay looks bad in IE
});


but I also need to change the image links to come out like this:
<a href="images/009.jpg" class="highslide" onclick="return hs.expand(this, null, {large: 'images/009.large.jpg'})">
<img src="images/009.thumb.jpg" alt="Highslide JS"
title="Click to enlarge" height="120" width="120" /></a>


I'm assuming I need to edit the onclick tag and anchor link part of hs4smf-subs.php but I'm not sure what to change it to to get the desired results.
Please help me!



add:
I forgot to mention that I'm using highslide-full.js rather than highslide.js.

henrik1782

I spuds...

I want to kindly ask you if you can advise how to implement this great mod to work in SMF Gallery.

This mod is really fantastic and I have aksed thi developer of SMF Gallery if they you implement af this functionallity but they replied negative.

So I thought that you might have the ability to advice how and where to change.
My favorite mods: Forum Firewall, httBL, MessagePreviewOnHover, BoardHover Mod, VB Style Board Index, Separate Replies and Views Column, Realtime clock by Joker, ENotify, Topic Solved.

Spuds

Quote from: henrik1782 on March 11, 2011, 09:07:10 AM
I want to kindly ask you if you can advise how to implement this great mod to work in SMF Gallery.

I had posted a couple of changes you can make to SMF Gallery to work with HS4SMF, gives some of the functionality.  Those updates are

http://www.simplemachines.org/community/index.php?topic=379200.msg2874646#msg2874646

and

http://www.simplemachines.org/community/index.php?topic=379200.msg2875060#msg2875060

Give those a try and see if it gives you what you want.

henrik1782

Appreciate ...

Just what I was looking for... thanks
My favorite mods: Forum Firewall, httBL, MessagePreviewOnHover, BoardHover Mod, VB Style Board Index, Separate Replies and Views Column, Realtime clock by Joker, ENotify, Topic Solved.

Spuds

#172
Quote from: Eudemon369 on March 01, 2011, 08:12:53 PM
yea, the aeva problem is fixed too

but unfortunately i found a new bug regarding to aeva
the images are not resized with respective width and height
all the images in aeva are little too wide

Somehow I missed this bug report  :-[ ..... I've attached an updated hs4smf-Subs.php file that should fix the aspect ration issue you are seeing  in aeva when the aeva option is set in hs4smf.

Eudemon

Quote from: Spuds on March 15, 2011, 10:52:09 AM

Somehow I missed this bug report  :-[ ..... I've attached an updated hs4smf-Subs.php file that should fix the aspect ration issue you are seeing  in aeva when the aeva option is set in hs4smf.

yeah, good thing u found it
i was wondering why u ignored me for days :P

rower


Spuds

I have no idea what makes you mad and sad  ....

Leniek

are this fixed files included in installation package?

Eudemon

Quote from: Spuds on March 16, 2011, 03:41:36 PM
I have no idea what makes you mad and sad  ....
same here
i laughed when i saw this

Spuds

Quote from: Leniek on March 17, 2011, 12:52:47 PM
are this fixed files included in installation package?
Not yet, but you safely overwrite the hs4.php in your sources directory with the one a couple of posts above this one (it will not affect uninstalling the mod at all).

Quote from: Eudemon369 on March 17, 2011, 03:57:34 PM
Quote from: Spuds on March 16, 2011, 03:41:36 PM
I have no idea what makes you mad and sad  ....
same here
i laughed when i saw this
Glad it was not just me  :D  Hopefully they will provide more information.

RvG

thank you for your very beautiful mod. Installed and officially used as my standard feature.

Advertisement: