Advertisement:

Author Topic: GDPR Helper  (Read 1833 times)

Offline Obcy

  • Semi-Newbie
  • *
  • Posts: 33
Re: GDPR Helper
« Reply #20 on: June 17, 2018, 09:28:57 AM »
Not clear id_member in messages if gpdr helper installed.(option unchecked "Clear Member IP/Email,Username from posts on member delete") if deleted user. 

Offline ms_ukyankee

  • Full Member
  • ***
  • Posts: 531
  • Gender: Female
Re: GDPR Helper
« Reply #21 on: June 30, 2018, 09:04:53 AM »
Hiya, thanks for this mod, it was a great timesaver.

I have one issue which confuses me, the Privacy Policy link in the footer is duplicated on my forums on both custom themes (old/new) and Curve. No one else seems to have this as it's not reported. I can work around it and add my own policy link while commenting out the mod code from QueryString.php, but is it the mod or something else? it's the "something else" which concerns me.
SMF since 2004 <3

Offline vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,207
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: GDPR Helper
« Reply #22 on: June 30, 2018, 09:54:55 AM »
Probably something else such as part of the code being executed twice.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Shambles

  • SMF Hero
  • ******
  • Posts: 4,799
  • Gender: Male
    • i30 Owners Club
Re: GDPR Helper
« Reply #23 on: June 30, 2018, 01:08:35 PM »
Quote from: ms_ukyankee
... the Privacy Policy link in the footer is duplicated on my forums ...

Have a look in Subs.php and see if you have this:

Code: [Select]
// Start up the session URL fixer.
ob_start('ob_sessrewrite'); ob_start('ob_sessrewrite');

If so, change it to this:

Code: (Replace) [Select]
// Start up the session URL fixer.
ob_start('ob_sessrewrite');

Offline ms_ukyankee

  • Full Member
  • ***
  • Posts: 531
  • Gender: Female
Re: GDPR Helper
« Reply #24 on: June 30, 2018, 02:43:57 PM »

Have a look in Subs.php and see if you have this:

Code: [Select]
// Start up the session URL fixer.
ob_start('ob_sessrewrite'); ob_start('ob_sessrewrite');

If so, change it to this:

Code: (Replace) [Select]
// Start up the session URL fixer.
ob_start('ob_sessrewrite');

How bizarre, that was it! Fixed. Thank you, Shambles!
SMF since 2004 <3

Offline vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,207
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: GDPR Helper
« Reply #25 on: June 30, 2018, 02:48:58 PM »
Good to know haven't seen that occur before.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Shambles

  • SMF Hero
  • ******
  • Posts: 4,799
  • Gender: Male
    • i30 Owners Club
Re: GDPR Helper
« Reply #26 on: June 30, 2018, 03:26:25 PM »
Quote from: vbgamer45
Good to know haven't seen that occur before.

https://www.simplemachines.org/community/index.php?topic=559841.msg3974559#msg3974559   ;)

Offline vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,207
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: GDPR Helper
« Reply #27 on: June 30, 2018, 03:52:45 PM »
Strange not sure what mod is doing that I do not touch that line of code in this mod.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline @rjen

  • Jr. Member
  • **
  • Posts: 247
  • Gender: Male
Re: GDPR Helper
« Reply #28 on: July 02, 2018, 03:41:10 AM »
Quick question.

I am checking the acceptance of the privacy agreement using a query on the database, combining the 'gpdr_policydate' and the last login date. In a month or so we will delete all users that have not accepted.

I find that some users have a last login date LATER than the date the the policy was effected, but they do not have a value in de gpdr_policydate. This suggests that they logged in to the forum after the effective date, so they must have been presented with the agreement text...

Is this what happens when they login, but do NOT accept the policy? Or is is a glitch in the code somehow?
Running SMF 2.0 with Tinyportal 1.5.1 at www.fjr-club.nl
Testing SMF 2.1 beta 4 with Tinyportal 1.5.1 at http://test2.fjr-club.nl/

Offline vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,207
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: GDPR Helper
« Reply #29 on: July 02, 2018, 08:38:52 AM »
Yes, the  gpdr_policydate is only set if they agree to the new privacy policy. People can login and logout without accepting.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline @rjen

  • Jr. Member
  • **
  • Posts: 247
  • Gender: Male
Re: GDPR Helper
« Reply #30 on: July 02, 2018, 10:16:39 AM »
Ok, thanks
Running SMF 2.0 with Tinyportal 1.5.1 at www.fjr-club.nl
Testing SMF 2.1 beta 4 with Tinyportal 1.5.1 at http://test2.fjr-club.nl/

Offline Shambles

  • SMF Hero
  • ******
  • Posts: 4,799
  • Gender: Male
    • i30 Owners Club
Re: GDPR Helper
« Reply #31 on: July 04, 2018, 11:53:51 AM »
Strange not sure what mod is doing that I do not touch that line of code in this mod.

I think it's the Login Form Fix mod


See here
https://www.simplemachines.org/community/index.php?topic=558180.msg3979010#msg3979010

Offline confuseamuse

  • Jr. Member
  • **
  • Posts: 138
Re: GDPR Helper
« Reply #32 on: July 04, 2018, 12:15:05 PM »
I remember asking for a mod that let you change the registration agreement and force users to view the changes. Thankfully, the GDPR requirement essentially provided the functionality I'll need ;D

Offline vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,207
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: GDPR Helper
« Reply #33 on: July 04, 2018, 12:18:56 PM »
confuseamuse That works out! Thanks Shambles for figuring that out looks like that will be fixed soon.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,749
    • Arantor on GitHub
Re: GDPR Helper
« Reply #34 on: July 04, 2018, 12:21:32 PM »
Yeah, it’s an easy fix, I just was a bit sloppy in my packaging, because I haven’t written SMF mods in a while...
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

Offline vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,207
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: GDPR Helper
« Reply #35 on: July 04, 2018, 12:46:56 PM »
Thanks I have done that a bunch of times over the years.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,749
    • Arantor on GitHub
Re: GDPR Helper
« Reply #36 on: July 04, 2018, 01:58:56 PM »
And it's fixed now :)
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.