[4529][2.0 RC4/Subs.php] member awaiting approval notice

[Kolya]

Worked for me. Thank you Brettflan.

[billy2]

Hi
I just cant clear the "new members awaiting approval" from top left.
There are no items in the  Administration Center > Members >  View All Members > Awaiting Approval,
yet 'two are awaiting' -  which I cannot clear.
I did remove a spamming members account the other day - but did not notice if this issue happened at that point.
I updated from RC3 to RC4 with no issues
I use both FF 3.6.12 and IE8

Please see attached screen shot
Cheers
Billy

**sorry just noticed other posts - unchecked the require admin approval and error has cleared**

[booch_21]

I have placed that corrected code in.  Will report if I see it come up again.

[Norv]

Hey there,

I believe Brett has attached a package helping to correct an issue with this here:
http://www.simplemachines.org/community/index.php?topic=407686.msg2845083#msg2845083

[Jfdowim5]

I can't use the package since SMF's ftp option doesn't work for me.  The package doesn't show up despite having uploaded it manually to the right directory.  I know that I solved that once before, or at least it worked for a bit, but I can't recall how.

Editing it manually and then using the recount statistics function did get it to behave so I think that you might have cracked it. 

[Brettflan]

I just noticed that in hunting down that one problem, I somehow forgot about the other. 
To fix the "Awaiting Approval" menu link not showing up elsewhere in the Manage Members area, line 128 of ManageMembers.php:

Code Select Expand

$context['show_approve'] = (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2) || !empty($context['awaiting_approval']);
should be:

Code Select Expand

$context['show_approve'] = (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2) || !empty($context['awaiting_approval']) || !empty($modSettings['approveAccountDeletion']);

Attached is what should be the final version of my earlier fix package, which includes this additional fix.

[Jfdowim5]

Excellent.

[billy2]

Yes - thanks Norv
regards
Billy

[marinesct]

Thanks for the fix Brettflan!

[holodoc]

The package worked for me as expected and fixed the issue.

[Norv]

The Admin > Members > Awaiting Approval page should have a combo-box allowing to choose between the "Accounts awaiting approval" and "Accounts awaiting deletion".
The number in user information ("there are x members awaiting approval") should add up both.
That doesn't happen?

[Brettflan]

It works fine. It's just that with no members actually awaiting account deletion, those options weren't showing up (which is sensible enough). So when I was first seeing that screen, I saw no hint of the "awaiting approval" page actually supporting account deletion, particularly when navigating to other pages in that admin section and having the menu link to that page disappear.

[booch_21]

After making the changes listed above, when I reject users, either with or without e-mail, the notification at the top continues to say that I have x number of members awaiting approval.  When I go into maintenance and do a recount of forum stats, this clears that notification and goes back to normal.  I originally thought that the notification issue was completely fixed, but this at least allows us to clear it.

[Brettflan]

After making the changes listed above, when I reject users, either with or without e-mail, the notification at the top continues to say that I have x number of members awaiting approval.  When I go into maintenance and do a recount of forum stats, this clears that notification and goes back to normal.  I originally thought that the notification issue was completely fixed, but this at least allows us to clear it.

Are you sure you have all of the changes? I've had the above package (with all changes) installed on the TaleWorlds forum, and we've had account deletion requests show up several times now. The number has been updated correctly each time as they show up and the accounts are then deleted.

EDIT: though re-reading your message, I don't recall having testing rejecting any deletion requests. I'll look into it tomorrow.

[booch_21]

Accepted users don't create the notification issue, only when rejecting them.  Thanks for looking!

[Brettflan]

OK, I've had a chance to test it a couple of times on my test setup and I can't duplicate the problem you're having.
To be clear, this is what I'm doing:
With a member having requested account deletion, I click the link in "There is one member awaiting approval" and end up on the Awaiting Approval page, which lists the one member who has tried to delete his account (a test user I logged in as on another browser and made the request). I put a check in the checkbox for him on the far right, then on the "With Selected:" dropdown box I choose "Reject" (the only rejection option it lists for me). After confirming that, the message at the top indicating a member is awaiting approval goes away and the account is deleted.

Did you do anything significantly differently from that?

[booch_21]

I haven't tried approving an account deletion.  My issue comes up when I delete a new account.  New users register and are forced to wait for Admin approval.  When I do not approve the account, mainly from an IP that has no business on a very localized forum, I either pick Reject or Reject and Send Mail from the drop down on the right.  Let me show you in slide form:


This shows the new user waiting.






After rejecting the new user (yes, the user is checked in the previous screen).


Nothing in the approval list.


Notification is still up top however.


Reset the statistics will clear the notification.

Thanks for the help with this!

[Brettflan]

So, nothing to do with account deletion at all.
OK, I switched my test 2.0 RC4 forum over to requiring admin approval to activate accounts, then created a new account in another browser. With the admin account, I followed your steps exactly in choosing "Reject" for that account. It worked exactly as it should for me, the "one member awaiting approval" message went away. No problems.
I didn't get that database error you're showing, though. Might be from another mod package. The mod package and changes I provided for the problems related to account deletion approval do not include any changes to that file. You should check the line of the file it's indicating to see what it's trying to do there. In the unmodified 2.0 RC4 /Sources/Subs-Members.php file, there's no reference to an 'id_member' in the query at that line.

[Мel]

Brettflan
Thanx for the fix, this bug was bugging me

[[SiNaN]]

Fixed with rev 10331.