• Welcome to Simple Machines Community Forum. Please login or sign up.

A very tiny template 'bug'

Started by Felix J, May 02, 2011, 10:04:16 PM

Previous topic - Next topic

Felix J

What the hell, couldn't sleep due to throat problems...  :-[

Anyway found one new what could be called a bug using FF 4.0.1

Which could be added here?! - http://dev.simplemachines.org/mantis/view.php?id=4639

Now to the bug... if you look carefully the bottom corners doesn't look 100% good..

Screenshot - http://img600.imageshack.us/f/issue.png/ Not very easy to see on screenshot though.

Felix J

Opps my wrong....... Forget it!!

After looking at this forum where I am currently posting it looks allright. So no problem then...

mashby

I see what you're talking about though. A site with one board and the Info Center collapsed results in the footer_section div getting a brighter than expected edge. How many sites do you know of that has only one board? I guess yours and yes, it's not 100% perfect. Does it look 80% good though?
Always be a little kinder than necessary.
- James M. Barrie

Felix J

Quote from: mashby on May 02, 2011, 10:14:08 PM
I see what you're talking about though. A site with one board and the Info Center collapsed results in the footer_section div getting a brighter than expected edge. How many sites do you know of that has only one board? I guess yours and yes, it's not 100% perfect. Does it look 80% good though?

Ohh... then it is a bug after all?  :-X I thought at start that something was broken just at that site...

Ok then, well you're right. The bug show up when the info center is collapsed.

It's not my site though. I found it when checking out a mod...

mashby

It's not really a bug. Nothing is broken. It's more of a very minor display issue on a site with minimal content (or specifically boards). You won't see this on a site with at least two publicly accessible boards. I'd venture to say that the site you provided a screen shot of isn't being managed properly from the public eye anyway. Maybe there are other boards not visible to guests. In any case, this isn't a true bug in my opinion.
Always be a little kinder than necessary.
- James M. Barrie

Felix J

May 02, 2011, 10:29:29 PM #5 Last Edit: May 02, 2011, 10:33:04 PM by Felix J
Quote from: mashby on May 02, 2011, 10:24:24 PM
It's not really a bug. Nothing is broken. It's more of a very minor display issue on a site with minimal content (or specifically boards). You won't see this on a site with at least two publicly accessible boards. I'd venture to say that the site you provided a screen shot of isn't being managed properly from the public eye anyway. Maybe there are other boards not visible to guests. In any case, this isn't a true bug in my opinion.

That's why I wrote 'bug' in the title. Ok, but would it be 'complicated' in your eyes to fix this? I am more or less a perfectionist. I got no idea however to fix it...

mashby

Well, I would say add another board and be done with it to have the edge correspond with the background color. Another option though would be to edit the corners of this image:
http://www.simplemachines.org/community/Themes/default/images/theme/main_block.png
At the very bottom to remove the colors from the edges (making it transparent). But that would only be noticeable on a site with one board. Is it worth the effort. Heck if I know. I've attached a roughly done version. It isn't perfect, but you'll get the idea.
Always be a little kinder than necessary.
- James M. Barrie

Antechinus

If you make the corners transparent you'll get another problem, due to the way the divs are nested. ;) Now it is perfectly possible to get around this and use transparent corners, but it requires a slight re-arrangement of markup and css if you want to use the basic main block image. I've done this before for transparent themes. You can do it another way, without changing any markup, simply by slicing off a narrow strip from the main bock and calling that seperately in the outer div, with the standard main block called in the inner div. Using this method, you can have transparent corners on any element without getting overlap problems in the corners.

Illori


Antechinus

It's not something which has been changed in svn, if that's what you mean.

Illori

so then it has not been fixed at all? and it is not tracked?

Antechinus

No to both, but it was already known anyway. It's very minor and it only affects forums that have one board and the info centre collapsed. How many forums is that likely to be? TBH I really do not think it's worth worrying about.

Matthew K.

It's something that could be fixed, by using transparent images, or CSS3, but I don't think it's a big deal, it would occur in very rare scenarios.

Antechinus

No, you can't fix it just by using a transparent corner on the main_block. You have to use two separate sprites or change the markup. We didn't think that was worth doing at the time.

Joshua Dickerson

So are we going to consider this to be "not going to fix"?
Come work with me at Promenade Group



Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Antechinus

Not at this stage. We were thinking of some restructuring for the 2.1 theme anyway, so that should take care of it. Wouldn't bother tracking it at the moment.

Advertisement: