[4359] Wiki link error when it ends in parenthesis

Started by spiros, February 19, 2011, 04:59:33 AM

Previous topic - Next topic
Print
Go Down Pages1 2 All
User actions

spiros

February 19, 2011, 04:59:33 AM Last Edit: November 20, 2011, 01:48:33 PM by Joshua Dickerson
Links like this: http://it.wikipedia.org/wiki/Elio_(nome)

will not parse correctly. The parenthesis at the end is not parsed as part of the link. Applies to SMF 2 as well.

Illori

#1
February 19, 2011, 06:23:48 AM
it might be better to post this under bug reports.

spiros

#2
February 19, 2011, 06:24:43 AM
Well, in order not to double post, perhaps somebody could move it there.

Aleksi "Lex" Kilpinen

#3
February 19, 2011, 08:41:59 AM
Moved.
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

spiros

#4
February 22, 2011, 07:47:58 AM
Thanks. I guess this should be an easy fix, right?

Joshua Dickerson

#5
February 22, 2011, 02:22:12 PM
Come work with me at Promenade Group


Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

live627

#6
February 22, 2011, 02:30:01 PM
Try embedding the link in the [url] tag

Illori

#7
February 22, 2011, 02:36:48 PM
that way works fine, this issue only happens when the forum turns it into a link when not using url tags

live627

#8
February 22, 2011, 02:51:16 PM
Precisely. The RegEx doesn't take those characters into account fully.

spiros

#9
February 22, 2011, 05:09:25 PM
Quote from: live627 on February 22, 2011, 02:30:01 PM
Try embedding the link in the [url] tag


Yes, this is what I have been doing, but it is easier to just paste a link and have it work  :)

Arantor

#10
February 22, 2011, 05:11:32 PM
Though it's essentially a moot point, it will have other consequences by doing that.

QuoteSome random example, mentioning a website by name (and its address in parentheses just for readers, http://www.example.com/)

That now breaks. While *that* one was contrived, I know full well I've put links to things in parentheses before now...
Holder of controversial views, all of which my own.

Aleksi "Lex" Kilpinen

#11
February 23, 2011, 01:29:00 AM
Well, if people can't be bothered to add a space after an URL, it's their problem ain't it? :P

I've always added spaces after smiley codes, URLs and other stuff just to make sure they won't break...
So I think it would be OK to just parse everything after http: up until a space as an URL.
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Joshua Dickerson

#12
February 23, 2011, 01:38:49 AM
No, we should use the correct regular expression as far as the RFC is concerned.
Come work with me at Promenade Group


Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Aleksi "Lex" Kilpinen

#13
February 23, 2011, 02:26:39 AM Last Edit: February 23, 2011, 03:14:13 AM by LexArma
Quote from: Joshua Dickerson on February 23, 2011, 01:38:49 AM
No, we should use the correct regular expression as far as the RFC is concerned.
For what reason exactly? I'm just curious, since I've seen URLs with pretty much all other characters, but spaces I have not seen as part of an URL, regardless of the RFC, there are some wacky stuff we have missed other than this. For example http://www.tänään.fi/ Is actually VALID (and a working website) but doesn't parse as such.. ;)

( ADDED: See, http://dev.simplemachines.org/mantis/view.php?id=4623 Mantis understands it, SMF doesn't. )
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Joshua Dickerson

#14
February 23, 2011, 03:47:42 AM
See the other post regarding this. That is an IRI. The reason we should go with the RFCs is because as soon as we choose something that differs, it will be a bug. Then we'll be in a loop of fixing something with a bug.
Come work with me at Promenade Group


Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Joshua Dickerson

#15
November 13, 2011, 11:32:40 AM
I just tried this on this site and it parses that URL fine. Am I missing something?
Come work with me at Promenade Group


Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Illori

#16
November 13, 2011, 12:17:10 PM
check this link... the ) is not part of the link

http://it.wikipedia.org/wiki/Elio_(nome)

Joshua Dickerson

#17
November 20, 2011, 01:48:42 PM
Come work with me at Promenade Group


Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Sir Osis of Liver

#18
August 31, 2012, 02:31:14 PM

This happens in .1x and 2.0.2.  If a url ends with a closed parenthesis, it's not included in the link, and link is no good.  Try it -

http://en.wikipedia.org/wiki/Gale_(crater)

If you embed the url in bbc tags, it works.  Like this.

:P
When in Emor, do as the Snamors.
                              - D. Lister

emanuele

#19
August 31, 2012, 02:42:52 PM


Take a peek at what I'm doing! ;D



Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.
Print
Go Up Pages1 2 All
User actions
Advertisement: