Tagging System For Topics

Started by SMFHacks.com Team, December 19, 2006, 10:59:20 AM

Previous topic - Next topic

cookdandbombd

OOps, it's the latest version, SMF 2.1.4.  The only errors I got (apart from the 500 ones) were from the installation procedure, in Subs-Tags-Hooks.php

vbgamer45

Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

cookdandbombd

Quote from: vbgamer45 on May 27, 2024, 09:31:32 AMWhat error was that?

Quote/Sources/Subs-Tags-Hooks.php (Line 83)
8: Undefined index: smftags_menu

I'm also getting tags showing up like this: "i'm the tags man"

I think I need to change the encoding or something? I can't remember at all.



cookdandbombd

Anyone know how to fix apostrophes showing up like this please? 


vbgamer45

Posted an update which might help

4.1.2
For SMF 2.1.x
!Fallback string for menu item
!'s will now be shown properly for tags
!Change location of edit of message index source file location.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

cookdandbombd

Hmm, sadly not, thank you for trying though:

Quotetest'ng

vbgamer45

Strange it should be for display areas if using SMF 2.1
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

cookdandbombd

Quote from: vbgamer45 on May 29, 2024, 11:37:37 AMStrange it should be for display areas if using SMF 2.1

The new update seems to have broken something tbh, now I'm getting errors every time someone adds a tag:

Quote/forums/Sources/Tags2.php (Line 93)
8: Undefined index: tag

vbgamer45

Reposted the update with the fix.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

cookdandbombd

That fixed the latest error, thank you! 

Still can't get rid of the escape codes though.

cookdandbombd

#1330
Trying to look into this myself but I'm super rusty, and having to relearn a lot of stuff!

I have identified so far that the "tag" column in smf_tags is "tinytext" - is that correct?

I can see that the text is mangled when it's stored in the database:

Quote| 265572 | test'ng                                                   

But I do not know how to fix it.

Edit: This problem does not happen with old tags from back in the day, as you can see here:



The data is stored in the same way as you can see on the right, but is displayed correctly on the left when I look at the tag in SMF.  Another example of a new tag and how it is displaying wrongly:


Kindred

They are not the same.
The second one is double encoding...

The & should be &   not & in the database
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

FrizzleFried

I had the prior Tags system running in older 2.0... and as a bonus,  all those old tags came back to life.

This version has a nicer presentation and seems to be working fine EXCEPT for the "&" sign... which still throws up an escape code...

You cannot view this attachment.

One feature that would be nice is if the OP of the post received an alert when a TAG was added...

Thanks for the update @vbgamer45

FrizzleFried

Evidently there is a problem... a permissions problem.

I only see 3 permissions...

Add Tags to Own Topics       ✅
Delete Tags to Own Topics        ✅
Manage Tags

For general members I have ADD and DELETE set... however,   no one can add tags to other peoples posts aside from the admins. 

Is there a way to allow general members to ADD (not necessarily delete) their own tags to other peoples posts or do I have to give everyone MANAGE TAGS permissions which could get a bit ugly around here?


Diego Andrés

Having anyone delete or add tags to my own topics doesn't sound great user experience.
Eventually a user will maliciously mess around with that possibility and cause you to remove permissions from this user.

Essentially you need to consider which option gives you less of a headache, having moderated users, or users that moderate.

SMF Tricks - Free & Premium Responsive Themes for SMF.

FrizzleFried

My site is called "Asshats Anonymous".  It's sort of designed for asshattery. 

Now,  my users are telling me the old version of the Tags system worked the same... I didn't recall.

That said,  a perfect world would be a permission to allow users to ADD tags to any post and a permission to allow users to DELETE any tag in their own posts.  The best of both worlds.

That would be awesome.

:D

FrizzleFried

FWIW it appears that apostrophes also present as escape code...

You cannot view this attachment.

cookdandbombd

Quote from: FrizzleFried on June 05, 2024, 02:18:43 PMEvidently there is a problem... a permissions problem.

I only see 3 permissions...

Add Tags to Own Topics       ✅
Delete Tags to Own Topics        ✅
Manage Tags

For general members I have ADD and DELETE set... however,   no one can add tags to other peoples posts aside from the admins. 

Is there a way to allow general members to ADD (not necessarily delete) their own tags to other peoples posts or do I have to give everyone MANAGE TAGS permissions which could get a bit ugly around here?

Yeah, my site works as yours used to.

I disable delete tags, and enable manage tags.  That lets people add them anywhere, that's how we've always used this mod.

In the past this caused a lot of hassle as tags are anonymous by default, so people got very nasty. I ended up writing a script which would let people query who had made that particular tag, and it sorted things out. (I don't have this script to hand now, it was years ago.)

Advertisement: