Rank Image Drop Down

[Jade Elizabeth]

I have some questions.

1. My images are in images/badges, not in images/....is there a way I can specify that?

2. When you say default theme, you just mean it's loading from there, not that you're changing where they load from? Last I checked that was theme specific....so if I have different ones in each theme am I looking at loading only the defaults or is this only in the admin panel part?

3. Have you considered adding this to profiles?

[NanoSector]

1. Sure, five edits will have to be applied.

1. Sources/ManageMembergroups.php
Find:

Code Select Expand

if ($files = scandir($settings['default_theme_dir'] . '/images'))
Replace:

Code Select Expand

if ($files = scandir($settings['default_theme_dir'] . '/images/badges'))

2. Sources/ManageMembergroups.php
Find:

Code Select Expand

$ext = pathinfo($settings['default_theme_dir'] . '/images/' . $value, PATHINFO_EXTENSION);
Replace:

Code Select Expand

$ext = pathinfo($settings['default_theme_dir'] . '/images/badges/' . $value, PATHINFO_EXTENSION);

3. Sources/ManageMembergroups.php
Find:

Code Select Expand

$image_info = getimagesize($settings['default_theme_dir'] . '/images/' . $value);
Replace:

Code Select Expand

$image_info = getimagesize($settings['default_theme_dir'] . '/images/badges/' . $value);

4. Themes/default/ManageMembergroups.template.php
Find:

Code Select Expand

<img id="star_preview" src="', $settings['images_url'], '/', $context['group']['star_image'] == '' ? 'blank.gif' : $context['group']['star_image'], '" alt="*" />
Replace:

Code Select Expand

<img id="star_preview" src="', $settings['images_url'], '/badges/', $context['group']['star_image'] == '' ? 'blank.gif' : $context['group']['star_image'], '" alt="*" />

5. Themes/default/scripts/ridd.js
Find:
[code]document.getElementById('star_preview').src = smf_default_theme_url + '/images/' + ((select_box.value && star_count.value > 0) ? select_box.value : 'blank.gif');
Replace:

Code Select Expand

document.getElementById('star_preview').src = smf_default_theme_url + '/images/badges/' + ((select_box.value && star_count.value > 0) ? select_box.value : 'blank.gif');

Let me know if that works, and take backups

2. It's loading the image names from the default theme. It's possibly a bug, but me doing it this way means that I hit a barrier during the development. I'll take another look, put on my to-do list.

3. Membergroup stars can be set by an admin only, what do you want on the profile?

[Jade Elizabeth]

Works amazingly!!

Thanks so much!!!

[Jade Elizabeth]

Wait it's not quite there, it's submitting the image url as /images not images/badges. Did I miss something?

[NanoSector]

Eh, ups.

Themes/default/ManageMembergroups.template.php,
find:

Code Select Expand

<option value="', $star, '"', $context['group']['star_image'] == $star ? ' selected="selected"' : '', '>', $star, '</option>';

Replace with:

Code Select Expand

<option value="badges/', $star, '"', $context['group']['star_image'] == $star ? ' selected="selected"' : '', '>', $star, '</option>';

That should fix it.

[Jade Elizabeth]

Now that's working and the preview is not ha ha.

[NanoSector]

Ah, undo the change to Themes/default/scripts/ridd.js

[Jade Elizabeth]

Perfect! You rock, thank you so so much!!

You just seriously cut my work in half almost. Or at least made it easier!

[Jade Elizabeth]

Okay I am so sorry to do this... it's not selecting the right image... so when I edit a group that has an image the image is always reset to the first image listed (in this case admin). Can I fix that?

[NanoSector]

Any errors in your error log?

[Jade Elizabeth]

Not one

[NanoSector]

Does the image show correctly on profiles etc.?

[Jade Elizabeth]

Yep, everywhere. It's just that the drop down is not taking into account that there was a image already picked I think?

[NanoSector]

Aha.

Themes/default/ManageMembergroups.template.php
Find...

Code Select Expand

<option value="badges/', $star, '"', $context['group']['star_image'] == $star ? ' selected="selected"' : '', '>', $star, '</option>';
Replace:

Code Select Expand

<option value="badges/', $star, '"', ($context['group']['star_image'] == 'badges/' . $star ? ' selected="selected"' : ''), '>', $star, '</option>';

Now it should work.
Sorry for the many attempts.

[Jade Elizabeth]

Hey it's not your fault, this is technical, and with all code it's basically trial and error ha ha.

It would be nice to consider a field for "where are badges kept" because I know some people keep them in the forum root...and I know a lot of people who keep them in folders like "badges" or "ranks". So yeah it may be worth investing in .

[Arantor]

And is that a per-theme folder or not? Bear in mind you can use a single central folder for all badges in all themes without a mod if you're careful.

[Jade Elizabeth]

Also another note, even before when it wasn't showing the right image....the image that shows when the page loads never previews right. Maybe to do with JS loading order or something? Anyway it shows a blank image when you edit, but it is working now otherwise. I am not worried too much I just thought I would let you know in case it happens with the regular version too .

And is that a per-theme folder or not? Bear in mind you can use a single central folder for all badges in all themes without a mod if you're careful.

I'm not sure how to do that. TBH I really like it in the images folder in the themes. I don't like them anywhere else. Besides, what if I want a set of Christmas badges for my Christmas theme? (hint: I DO! )

It would be awesome to be able to specify it globally in SMF though, anywhere you wanted.

[Arantor]

You can't have both, one or the other, and having 'options' for everything is never, ever the good idea people think it is.

[Ninja ZX-10RR]

Got to file a bug report for this one... I am surprised that nobody did before O.o
When you install this mod the suggest.js file providing a dropdown list of possible moderators doesn't work anymore. I have been told by a very experienced guy that instead of assigning the function to window.onload directly in the js file, you should be using addLoadEvent and that would cure it.
I tried uninstalling it and the problem went away indeed, also I tried to install it on a clean forum and the problem was there as soon as I installed this.

Thanks in advance for any help

[NanoSector]

Thanks - will fix this in a future release.

I'll add links to my Github repos in the mod descriptions while I'm at it. Might help