Advertisement:

Author Topic: Automatic Attachment Rotation (and Resize)  (Read 52464 times)

Offline Rob Lightbody

  • Charter Member
  • Jr. Member
  • *
  • Posts: 168
  • Gender: Male
  • Rob Lightbody, QE2 Story Forum administrator
    • The QE2 Story
Re: Automatic Attachment Rotation (and Resize)
« Reply #240 on: December 08, 2019, 06:39:54 AM »
Hi,

Returning to report that v5.9 has resolved all the issues we were having.

Thanks very much indeed.

- Rob

Offline TourFL

  • Semi-Newbie
  • *
  • Posts: 66
Re: Automatic Attachment Rotation (and Resize)
« Reply #241 on: January 22, 2020, 08:34:02 AM »
Hello,

I migrated to the 5.9 version, with SMF 2.0.17, and the messages I previously had in the error logs are still there  :(
It seems it's only for users using "search" functionnality, so there is improvement, and much less occurences! But one search generates 12 errors, so it's adding up fast

Code: [Select]
http://www.500-126.com/index.php?action=search2
8: Undefined index: thumb_hash
File: /home/clients/XXX/web/Sources/Display.php
Line: 1762

http://www.500-126.com/index.php?action=search2
8: Undefined index: thumb_folder
File: /home/clients/XXX/web/Sources/Display.php
Line: 1762

http://www.500-126.com/index.php?action=search2
8: Undefined index: thumb_name
File: /home/clients/XXX/web/Sources/Display.php
Line: 1762

The code at this line, in my Display.php file:
Code: [Select]
1760: }
1761:   else
==>1762: $thumb_realname = getAttachmentFilename($attachment['thumb_name'], $attachment['id_thumb'], $attachment['thumb_folder'], false, $attachment['thumb_hash']);
1763:
1764: // Get timestamp for thumbnail image:
1765: $time = !empty($thumb_realname) && file_exists($thumb_realname) ? filemtime($thumb_realname) : false;

Any clue?
If you like Fiat 500 and derived models, the SMF forum I'm helping with: www.500-126.com

Offline GL700Wing

  • Full Member
  • ***
  • Posts: 482
  • Gender: Female
Re: Automatic Attachment Rotation (and Resize)
« Reply #242 on: January 23, 2020, 04:52:54 AM »
Hello,

I migrated to the 5.9 version, with SMF 2.0.17, and the messages I previously had in the error logs are still there  :(
It seems it's only for users using "search" functionnality, so there is improvement, and much less occurences! But one search generates 12 errors, so it's adding up fast

...

Any clue?
I've had a look at this issue (which you've reported a few times) but I haven't been able to reproduce it and I have this mod installed on three different forums which each have between 120 and 145 other mods installed.

I suspect there may have been an issue with a previous installation/removal of either this mod or that another mod is causing the issue.  What happens if you do a search after removing this mod?

PS:  I'm going away for the next 4-5 days and won't be able to follow up until after I return.
Life doesn't have to be perfect to be wonderful ...

Offline TourFL

  • Semi-Newbie
  • *
  • Posts: 66
Re: Automatic Attachment Rotation (and Resize)
« Reply #243 on: January 24, 2020, 03:59:57 AM »
Thanks for your help!
I tried desinstaling the mod. Performing a search doesn't generate any error without the mod installed.

And actually logs showed me that it's not only the search generating errors.
I don't understand where are those 3 indexes defined, and why it's not seen from that part of the code.

I have also a mod called "Inline Attachements" (from Spuds), used to display images or links within the message text. I'm not sure if it might get in conflict. I checked for an update on that one, but it looks like it's not maintained anymore. I Saw Dougiefresh did a similar mod, unfortunately it's not the same syntax, so I guess all my messages will be messed up if I use it  :-\
If you like Fiat 500 and derived models, the SMF forum I'm helping with: www.500-126.com

Offline Capion

  • Semi-Newbie
  • *
  • Posts: 75
  • Gender: Male
    • M@W
Re: Automatic Attachment Rotation (and Resize)
« Reply #244 on: March 21, 2020, 05:35:37 AM »
Thank You for at really great mod ;)

Could You make it handle the images in SMF gallery too?
*if it works, dont fix it*