News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

RSS missing link & guid

Started by john9001, May 11, 2014, 10:06:19 AM

Previous topic - Next topic

john9001

For some reason our forums core RSS feed doesn't contain the link or guid data anymore.  I've tried deactivating any MODs that were installed recently without success, still both fields empty.

Any thoughts on the reason and possible fix or suggestion on how to troubleshoot folks?  We're running SMF v2.0.7.

JF


Arantor

What's the link to your RSS feed?
No good deed goes unpunished / All helpful urges should be circumvented

I have something to say: it's better to burn out than to fade away. There can be only one.

john9001

hxxp:www.calis-beach.co.uk/forum/index.php?action=.xml;type=rss [nonactive]

JF

Arantor

Hmm, interesting. What mods do you have installed?
No good deed goes unpunished / All helpful urges should be circumvented

I have something to say: it's better to burn out than to fade away. There can be only one.

john9001

Thanks for looking.  These are the currently installed MODS.  I've tried disabling anything that rewrites URL such as Pretty URLs and SimpleSEF (in fact I just uninstalled that one as we havent used it for a while).

JF


1.   AjaxChat Integration   3.3c   [ Uninstall ]
2.   Pretty URLs   1.1.1a   [ Uninstall ]
3.   Tapatalk SMF 2.0 Plugin   3.9.3   [ Uninstall ]
4.   Like Posts   1.3.1   [ Uninstall ]
5.   SMF 2.0.7 Update   1.0   [ Uninstall ]
6.   SMF 1.1.19 / 2.0.6 Update   1.0   [ Uninstall ]
7.   SMF 2.0.5 Update   1.0   [ Uninstall ]
8.   SMF 2.0.4 Update   1.0   [ Uninstall ]
9.   SMF 2.0.3 Update   1.0   [ Uninstall ]
10.   Disable 'last edit by...' for Administrators   1.9   [ Uninstall ]
11.   MessagePreviewOnHover   1.8   [ Uninstall ]
12.   SimpleAds   1.0.1   [ Uninstall ]
13.   Recent Topics by 1h 8h 24h Filter Steve Adaption   1.0   [ Uninstall ]
14.   Automanagement of attachments   0.1.12   [ Uninstall ]
15.   SimpleSEF   2.1   [ Uninstall ]
16.   Shiny Smiley Icons   1.0   [ Uninstall ]
17.   Animation Blue Smiley   2.1   [ Uninstall ]
18.   Popos Smiley   1.0   [ Uninstall ]
19.   Adk Warning to visitors   1.0   [ Uninstall ]
20.   BoardColor   V1   [ Uninstall ]
21.   CheckBeforePosting   0.3.3   [ Uninstall ]
22.   YouTube BBCode   2.6   [ Uninstall ]
23.   Social Bookmarks   2.0   [ Uninstall ]
24.   Google Translate for SMF 2.0   1.3   [ Uninstall ]
25.   Simple Image Upload   1.3.0   [ Uninstall ]
26.   Age And Location   1.0   [ Uninstall ]
27.   Google Member Map   2.6   [ Uninstall ]
28.   Additional Instant Messengers   1.0.1   [ Uninstall ]

Arantor

Nothing strikes me as out of the ordinary with this :/ I can see that the SEF mods are disabled but I don't understand why your feeds are broken.

Out of interest, what's in Sources/News.php and Sources/QueryString.php? (Something is very weird since all of your feeds are broken, not just RSS)
No good deed goes unpunished / All helpful urges should be circumvented

I have something to say: it's better to burn out than to fade away. There can be only one.

john9001

Here are both.

Another curiosity is that the author is showing up as the members email address, I don't remember that happening before!

JF

Arantor

Your News.php file is damaged. I'd speculate Pretty URLs is the root cause.

Specifically this block of code that's commented out:
/* if (empty($modSettings['queryless_urls']) || ($context['server']['is_cgi'] && @ini_get('cgi.fix_pathinfo') == 0 && @get_cfg_var('cgi.fix_pathinfo') == 0) || (!$context['server']['is_apache'] && !$context['server']['is_lighttpd']))
return $val;

$val = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+)(#[^"]*)?$~', create_function('$m', 'global $scripturl; return $scripturl . \'/\' . strtr("$m[1]", \'&;=\', \'//,\') . \'.html\' . (isset($m[2]) ? $m[2] : "");'), $val);
return $val; */


At a minimum, the closing return $val statement should be left intact even if the other stuff isn't. All the URLs are passed to it, nothing's being returned so nothing gets output. I'm trying to remember what this function does but I can't remember...
No good deed goes unpunished / All helpful urges should be circumvented

I have something to say: it's better to burn out than to fade away. There can be only one.

john9001

Its a starting point, so thanks for that, much appreciated.

Will have another go at it tomorrow.

JF




john9001

The issue was PrettyURLs MOD.  Completely uninstalled and links and guids back. 

That change to the News.php file was part of PrettyURLs.

Cheers Arantor!

JF

Advertisement: