Advertisement:

Author Topic: You've got karma!  (Read 41925 times)

Offline live627

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,265
  • Gender: Male
  • Cat: Destroy!
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
You've got karma!
« on: June 12, 2014, 02:32:06 AM »
Several people still want to use the karma feature, which was removed from 2.1. Rather than leave those users in the dark (and I don't think they'd like to use the Likes feature (pun unintended), I decided to rebuild it as a mod.

Screenshots attached below.

This mod does not edit any files, partly due to the use of custom profile fields, but also because SMF 2.1 introduces hundreds of new hooks (haven't counted).

Open sourced under the MIT license. Link to project on GitHub: https://github.com/live627/smf-karma

~~~
Win a free cookie (not provided by me) if you can guess the reference in the title!!
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline CountryLady

  • Jr. Member
  • **
  • Posts: 178
  • Gender: Female
    • OurCountryHaven
Re: You've got karma!
« Reply #1 on: June 12, 2014, 02:44:44 AM »
Very considerate of you to do that. Way to Go!

Offline ѕησω

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,427
  • Gender: Male
  • Nisi credideritis, non intelligetis.
    • wade.poulsen93 on Facebook
    • acans on GitHub
    • https://www.linkedin.com/profile/view?id=145186638 on LinkedIn
    • @imacans on Twitter
    • Acans
Re: You've got karma!
« Reply #2 on: June 12, 2014, 05:05:57 AM »
You've got mail.

-.-

It's not SPAM

:D

Or something like that :P. Thanks Live!
"The Book of Arantor, 17:3-5
  And I said unto him, thy database query shalt always be sent by the messenger of $smcFunc
  And $smcFunc shall protect you against injections and evil
  And so it came to pass that mysql_query was declared deprecated and even though he says he is not dead yet, the time was soon to come to pass when mysql_query shall be gone and no more."

Offline Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,646
  • Gender: Male
  • Black cat rulz!
    • Antes on GitHub
    • merta on LinkedIn
    • @antesistan on Twitter
    • Lunarfall
Re: You've got karma!
« Reply #3 on: June 12, 2014, 05:09:33 AM »
Okay, this probably will be asked by other people in the future (especially people actively using Karma on their forum), what will happen to existing karma?

First of all we added option NOT to delete karma data from upgrade process so you are safe to upgrade, now question to OP, will your modification converts current data into its own? or just use the existing data?

Thanks for the modification :)
« Last Edit: June 12, 2014, 05:44:48 AM by Antes »
Active Project(s): [ SimpleDesk ] # [ Lunarfall ] # [ CoreStore ]

Past Project(s): [ ezPortal ]

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,133
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: You've got karma!
« Reply #4 on: June 12, 2014, 05:25:36 AM »
I like this. If I ever upgrade to 2.1 then I think I'm gonna download it :)
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Dragooon

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 6,738
  • Gender: Male
  • I'm bIn
    • ShitizGarg on Facebook
    • Dragooon on GitHub
    • dragooon on LinkedIn
    • SMF-Media
Re: You've got karma!
« Reply #5 on: June 12, 2014, 08:08:52 AM »
Oh yay :D. And it's a reference to the AOL mail client's mail notification

Offline live627

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,265
  • Gender: Male
  • Cat: Destroy!
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: You've got karma!
« Reply #6 on: June 12, 2014, 08:39:18 PM »
Someone younger than me got the old reference :o
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,133
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: You've got karma!
« Reply #7 on: June 12, 2014, 08:56:07 PM »
Okay, this probably will be asked by other people in the future (especially people actively using Karma on their forum), what will happen to existing karma?

First of all we added option NOT to delete karma data from upgrade process so you are safe to upgrade, now question to OP, will your modification converts current data into its own? or just use the existing data?

Thanks for the modification :)
You missed it ;)
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline live627

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,265
  • Gender: Male
  • Cat: Destroy!
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: You've got karma!
« Reply #8 on: June 12, 2014, 09:04:30 PM »
Ah yes. I'll write a converter soon.

Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 67,876
    • Arantor on GitHub
Re: You've got karma!
« Reply #9 on: June 12, 2014, 09:04:53 PM »
It'll take two weeks, amirite? (ba dum tish)
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline live627

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,265
  • Gender: Male
  • Cat: Destroy!
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: You've got karma!
« Reply #10 on: June 12, 2014, 09:05:31 PM »
lol
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Study Force

  • SMF Hero
  • ******
  • Posts: 3,100
    • @studyforceps on Twitter
    • Study Force
Re: You've got karma!
« Reply #11 on: June 12, 2014, 09:14:54 PM »
Why was Karma feature removed?

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 67,876
    • Arantor on GitHub
Re: You've got karma!
« Reply #12 on: June 12, 2014, 09:20:10 PM »
Uncharacteristically I asked the users about it and explained my reasoning in the thread.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 54,985
  • Gender: Male
    • Kindred-999 on GitHub
Re: You've got karma!
« Reply #13 on: June 12, 2014, 09:59:35 PM »
and do note, as SMF moves along, We're going to be doing that with several "features"
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,133
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: You've got karma!
« Reply #14 on: June 12, 2014, 10:00:37 PM »
Uncharacteristically I asked the users about it and explained my reasoning in the thread.
There are hundreds of thousands members and 33 people voted  :-\
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 67,876
    • Arantor on GitHub
Re: You've got karma!
« Reply #15 on: June 12, 2014, 10:02:25 PM »
There might be hundreds of thousands of members but they're not all active, nor do they all go into the Chit Chat board. Most members only come here when they need help.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 54,985
  • Gender: Male
    • Kindred-999 on GitHub
Re: You've got karma!
« Reply #16 on: June 12, 2014, 10:05:51 PM »
besides - we're the ones making the system...   although we consider what the users want, as Arantor has pointed out before, we are also users... and we have ideas on what WE want as well. And with the mod system, removal of a feature like Karma or the Calendar is not an end to the functionality
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,133
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: You've got karma!
« Reply #17 on: June 12, 2014, 10:08:14 PM »
Yeah but I don't really consider it a poll with 33 votes anyway D: it's *way* too low. If it was like 100 at least but 33 no .-.
Next time could it be a good idea to make the topic global or something like that? At least a lot more people would vote ;)

besides - we're the ones making the system...   although we consider what the users want, as Arantor has pointed out before, we are also users... and we have ideas on what WE want as well. And with the mod system, removal of a feature like Karma or the Calendar is not an end to the functionality
Indeed no one ever said you can't vote in your own poll :D
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 67,876
    • Arantor on GitHub
Re: You've got karma!
« Reply #18 on: June 12, 2014, 10:12:19 PM »
Things like the calendar are particularly fiercely debated. There are many communities that do not use one. There are some that do - and invariably the ones that do, also rely on it quite heavily.

Breaking it out of the core has consequences for them. More importantly, it has all kinds of other consequences. It means you absolutely ensure your modding functionality is up to scratch. It has performance consequences. And probably most compelling of all, you can add to its functionality separately from the main core, meaning you can turn around updates to it separately of the forum - adding in functionality that users want without waiting for another major release of SMF.

On the other hand it also encourages doing things previously unheard of. Right now the calendar depends on SMF's posting routine; adding a new calendar entry with a topic ties them together and if so doing, it means every time you view a topic you end up looking for whether or not there's a related calendar entry. This is a non-trivial performance problem.

If you were to decouple calendar events from main posting, you would avoid that performance hit while still being able to do what you want to do with calendar stuff.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 54,985
  • Gender: Male
    • Kindred-999 on GitHub
Re: You've got karma!
« Reply #19 on: June 12, 2014, 10:15:21 PM »
the poll was offered as a pancea, not a binding agreement.... to get an idea - and the choice was fairly clearly represented.

and, if 33 people voted, then that's 33 people who cared enough to vote...
As for global topics... nope. Those who care can view the development threads and comment - those who don't care enough will take what we make and go from there.


As for the calendar... as arantor says... there are VERY good reasons for decoupling it
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Haren

  • Newbie
  • *
  • Posts: 3
Re: You've got karma!
« Reply #20 on: January 20, 2015, 06:00:55 AM »
This may be one of the worst decisions made by SMF. Not the karma functionality, but the calender. My forum uses it very heavily, and if there are no immediate plugins with up-to-date upgrades as new SMF versions are released, it renders SMF useless to us.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 67,876
    • Arantor on GitHub
Re: You've got karma!
« Reply #21 on: January 20, 2015, 06:05:24 AM »
Not being funny but you clearly didn't read the thread.

2.1 has not removed the calendar. It is still a core feature.

The point being made was that it has been fiercely debated both ways to remove it in a future version and make it a plugin - and at the same time make the plugin system much more reliable so it would be much saner to actually make it a plugin if it were actually done (and it would be available with 3.0 for that reason).

The calendar is a strange beast. It is used by a tiny percentage of the SMF userbase... but those that do, make heavy use of it. It is a maintenance nightmare, it has a number of bugs in it, it is also a performance hog (more than it needs to be) and a plugin with proper importer would make a lot of sense for various reasons.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.