Embed Facebook BBCode

[dougiefresh]

Its safe to upgrade from version V3.7 by replacing the Subs-BBCode-Facebook.php file in Sources ??

That should be safe to do, since nothing much changed.

[dougiefresh]

Uploaded v3.9 - March 4th, 2018
o Fixed an issue that prevents BBC manager from showing bbcodes.

[dougiefresh]

Uploaded v3.10 - April 21st, 2018
o Made a few changes to the HTML header code, as suggested by UMH.
o Moved certain installer code from add_remove_hooks.php to main source file.
o Added package redirect to invoke previously mentioned installer code.



@UMH:  Thank you for the suggestions!  They have been included in this version!

[kitz]

Having a problem with this mod.     I've had an older version installed (3.7) which worked fine thanks
 
... Until last night when a few people who were using ipads said they could no longer see any trace that there was a video embedded into the post, so I tried to upgrade to the latest version.    I have since I think been on a red herring chase thinking it was something to do Tapatalk, as I had difficulty removing the old version due to a minor file difference in one of the mobique files.

So tapatalk uninstalled, old version of this mod uninstalled.   
Tapatalk reinstalled, Embed FB BBCode 3.10 installed.

Now no-one can see any embedded FB videos and unless I switch on the option to include the url, then it looks like there is an empty post.

I've tried a reinstall but still nothing is working.
The button is there fine and it will add the {facebook} {/facebook} BBcode.  Just no video displayed.

[dougiefresh]

Interesting bug report.  I'll look into it.....

[kitz]

Thank you.   If you need any more info let me know.
I haven't done any updates other than tapatalk for a while. I'm currently running SMF 2.0.15 with the following mods:

Code Select Expand

1. Embed Facebook BBCode 3.10
2. Tapatalk SMF 2.0 Plugin 4.5.2
3. GDPR Helper 1.0.4
4. Stop Spammer 2.3.9a
5. Ohara YouTube Embed 1.2.3
6. httpBL

Whilst at first it was just those with i-pads reporting problems, now no-one can view any videos past or present (even those that previously showed ok).

I don't think its relevant, but one of my users noticed that the FB code causes W3 errors with SMF's xhtml.

[kitz]

Just had a quick look at Subs-BBCode-Facebook.php and not sure if this is relevant but  jssdk 2.3 is long since deprecated.  The latest version is 3.1

There also appears to have been a change in the url structure
$tag['content'] = '<div class="fb-video" data-href="https://www.facebook.com/video.php?v='; . $parts[5] . '" data-width="'

Video links are now in the format

<div class="fb-video" data-href="https://www.facebook.com/'; . $fb_user . '/videos/' . $part . '/" data-width="500" data-show-text="false">


Apols if I've misunderstood your code or if you checked for that in the reg expression which Ive just noticed above that line.

[dougiefresh]

Uploaded v3.11 - October 13th, 2018
o No functionality change.
o Updated documentation to point to new website.



@kitz:  I apologize for the late response to your bug report.  I'll look into it!

[kitz]

Thank you, I'd appreciate it if you would.   I've not been able to get it to work for several months now.
Same issue with 3.11

[FishingManMatt]

Hi dougiefresh!
First of all, thank you for your mod.

Just wanted to report the same bug which Suki had made in his Ohara YouTube Embed mod.
I described the bug in this post.

In the installation script you can find the following:

Code Select Expand

<file name="$sourcedir/Post.php">
<operation>
<search position="replace"><![CDATA['<img>]]></search>
<add><![CDATA['<img><div>]]></add>
</operation>
<operation>
<search position="replace"><![CDATA['<img>]]></search>
<add><![CDATA['<img><div>]]></add>
</operation>
</file>

which results in:

Code Select Expand

<img><div><div>


Another issue worth to mention:
I think that many people use both mods Embed Facebook BBCode and Ohara YouTube Embed and both mods modify the same img tag in different manner:

Ohara YouTube Embed converts the img tag into:

Code Select Expand

<img><iframe><video><div>

Embed Facebook BBCode into:

Code Select Expand

<img><div>

Maybe there is some way to unify this code for both mods?

Best regards
Matt

[Cola-Coca]

Helo,

I installed the mod and after installation when I put something between tags '[facebook]facebook link[/facebook]' in the end I get nothing, as if I did not write anything in the post.

I have instaled 'Embed_Facebook_BBCode_v3.11'.

[Ninja ZX-10RR]

Helo,

I installed the mod and after installation when I put something between tags '[facebook]facebook link[/facebook]' in the end I get nothing, as if I did not write anything in the post.

I have instaled 'Embed_Facebook_BBCode_v3.11'.

Buddy, you have 3.5k posts, you should know very well that when you have a problem you must give some context... Link to see the problem, errors, something...

[Cola-Coca]

Helo,

I installed the mod and after installation when I put something between tags '[facebook]facebook link[/facebook]' in the end I get nothing, as if I did not write anything in the post.

I have instaled 'Embed_Facebook_BBCode_v3.11'.

Buddy, you have 3.5k posts, you should know very well that when you have a problem you must give some context... Link to see the problem, errors, something...

Yes you're right.
I installed the mod without any error and I have no error in the forum 'error log'. As I wrote, I installed the version 'Embed_Facebook_BBCode_v3.11' and when I put it for example facebook video between facebook tags I do not get anything except empty message (see imagen):




I want to add that I have installed the mod 'Yet Another YouTube BBCode Tag' and I do not know if this is a problem?

[kitz]

This is the same problem that I have and I reported it here.

Now no-one can see any embedded FB videos and unless I switch on the option to include the url, then it looks like there is an empty post.

I've tried a reinstall but still nothing is working.
The button is there fine and it will add the {facebook} {/facebook} BBcode.  Just no video displayed.

The mod has been totally broken for me since Aug 2018.    I later made a suggestion on 18th of Aug after I'd tried to look into it, and it appears to be something to do with the facebook format for video links has changed so that code in the existing mod no longer works.

[kitz]

PS I just noticed the post from FishingManMatt which could be relevant

I also use Ohara YouTube Embed

[Cola-Coca]

This is the same problem that I have and I reported it here.

Now no-one can see any embedded FB videos and unless I switch on the option to include the url, then it looks like there is an empty post.

I've tried a reinstall but still nothing is working.
The button is there fine and it will add the {facebook} {/facebook} BBcode.  Just no video displayed.

The mod has been totally broken for me since Aug 2018.    I later made a suggestion on 18th of Aug after I'd tried to look into it, and it appears to be something to do with the facebook format for video links has changed so that code in the existing mod no longer works.

Thank you for explanation !!!
Can you have an older version (3.7) which worked fine for you ?
If you have it, please send me download link via PM.

Thanks 

[Cola-Coca]

Any news ?

[Arantor]

The author hasn't been online for a week and even if he had, it's actually unreasonable to expect someone doing this in their spare time to always respond in less than a day

[Cola-Coca]

bump! 

[dougiefresh]

I apologize for having been absense for the last few months.  Life decided it wanted to rachect up the difficulty level some.... You know, computer problems, vehicle problems, work problems, etc.....

I'm looking for the cause of the issues that have been reported.....