[2.0.13] smf_db_create_table no $column_info

[vbgamer45]

function smf_db_create_table($table_name, $columns, $indexes = array(), $parameters = array(), $if_exists = 'ignore', $error = 'fatal')

This line changed to

Code Select Expand


$unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint')) && !empty($column['unsigned']) ? 'unsigned ' : '';

To

Code Select Expand


$unsigned = in_array($type, array('int', 'tinyint', 'smallint', 'mediumint', 'bigint', 'float')) && !empty($column_info['unsigned']) ? 'unsigned ' : '';

Issue there is no $column_info

It was done in some other spots but it makes sense in those spots

[live627]

Can you check if this issue is also in 2.1? I'm not in a coding mood right now... (burnout yet again)

[vbgamer45]

Does not affect 2.1

[albertlast]

I would like to comment this part in general:

In my eyes you should forget that unsigned exists,
from sql standard pov is garbage.

And i know "mysql can it" and "smf use it" but both is wrong.

the api of smf is designed to work with all supported databases.
In smf 2.1 is it mysql and pg,
and you run in trouble when the min and max value in both database is different.