2.0.13 -> 2.0.14 install fail in ./Sources/Subs.php (image _proxy related code)

[aegersz]

(Subs.php attached)

Code Select Expand

'content' => '<img src="'content' => '<img src="$1" alt="{alt}"{width}{height} class="bbc_img resized" />',
'validate' => create_function('&$tag, &$data, $disabled', '
$data = strtr($data, array(\'<br />\' => \'\'));
if (strpos($data, \'http://\') !== 0 && strpos($data, \'https://\') !== 0)
$data = \'http://\' . $data;
')," alt="{alt}"{width}{height} class="bbc_img resized" />',
'validate' => create_function('&$tag, &$data, $disabled', '
$data = strtr($data, array(\'<br />\' => \'\'));
if (strpos($data, \'http://\') !== 0 && strpos($data, \'https://\') !== 0)
$data = \'http://\' . $data;
'),

to replace with:

Code Select Expand

'content' => '<img src="'content' => '<img src="$1" alt="{alt}"{width}{height} class="bbc_img resized" />',
'validate' => function (&$tag, &$data, $disabled)
{
global $image_proxy_enabled, $image_proxy_secret, $boardurl;

$data = strtr($data, array('<br>' => ''));
if (strpos($data, 'http://') !== 0 && strpos($data, 'https://') !== 0)
$data = 'http://' . $data;

if (substr($data, 0, 8) != 'https://' && $image_proxy_enabled)
$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
}," alt="{alt}"{width}{height} class="bbc_img resized" />',
'validate' => function (&$tag, &$data, $disabled)
{
global $image_proxy_enabled, $image_proxy_secret, $boardurl;

$data = strtr($data, array('<br>' => ''));
if (strpos($data, 'http://') !== 0 && strpos($data, 'https://') !== 0)
$data = 'http://' . $data;

if (substr($data, 0, 8) != 'https://' && $image_proxy_enabled)
$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
},

[vbgamer45]

Could be caused by a mod that edits that same code.

[aegersz]

Thanks -- I naturally thought that of course but i have over 120 mods on and I was hoping that someone could point me to which one. I have never had a problem moving to new modification levels before so that's also concerning.

I have compared the code and it isn't much different (at first glance) but didn't want to make any manual changes my self, especially ones that i don't understand ... my php skills are next to useless, i'm sad to say.

the best case would be a SMF-sanctioned code change and if it has to be manual then i'm OK with that as long as it is documented here and may help others.

[vbgamer45]

you would need to list your mods

[aegersz]

My mods are listed in my Signature (link) but you may not want to take the link, i get that.

Still hoping for a minor miracle here, though ... 

like some prolific mod author that recognises the differences in my attached Subs.php vs. vanilla, if they can be bothered, that is.

I don't even really understand what Subs.php actually does.

Sad, but i've been too busy with work these days.

[vbgamer45]

I would guess this mod  Resize Attached Images   

[aegersz]

I love that mod  ! ... *groan* ... well, as ever, thanks for helping.

[aegersz]

I might try to retro fit that mod.

if not, what's the worst thing about sitting on 2.0.13 forever ?

[aegersz]

I found it - it was the "Images with Margins and Borders" mod.

sorted !