Advertisement:

Author Topic: Embed Facebook BBCode  (Read 54235 times)

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Embed Facebook BBCode
« Reply #180 on: February 26, 2019, 11:14:55 AM »

Okay, I've personally gotten this mod to work on Chrome browsers, but failing miserably on FireFox browsers on my Windows 7 OS.....  I've followed Facebook's own instructions on how to embed this stuff and Firefox seems to want to snub it's nose at me....  I'm going to publish a new version, but it doesn't work on FireFox browsers (at least that I can tell)....  Gimme a little while to figure out how to make the necessary changes for it to work on Chrome.
« Last Edit: February 26, 2019, 11:27:58 AM by dougiefresh »

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Embed Facebook BBCode
« Reply #181 on: February 26, 2019, 12:24:27 PM »
I apologize to everybody for the enormous delay!  I'm working on the mod issues....

Okay, Firefox has a feature called "Tracking Protection".  Disabling it through about:config allows FireFox to correctly show the embedded stuff in the browser window.....  This irritating "feature" caused me much irritation while trying to figure out why FF was being a pain in my butt.  Anyways, an update is going to be out soon!

This mod is going to require some additional editing in order to bring some cool new features that almost every one of my video mods has: responsive video formats....  Sorry about the additional delay, but since the video tags have changed, it should be easy enough to add the required HTML code to make the video size responsive....

Hi dougiefresh!
First of all, thank you for your mod.

Just wanted to report the same bug which Suki had made in his Ohara YouTube Embed mod.
I described the bug in this post.

In the installation script you can find the following:
Code: [Select]
<file name="$sourcedir/Post.php">
<operation>
<search position="replace"><![CDATA['<img>]]></search>
<add><![CDATA['<img><div>]]></add>
</operation>
<operation>
<search position="replace"><![CDATA['<img>]]></search>
<add><![CDATA['<img><div>]]></add>
</operation>
</file>

which results in:
Code: [Select]
<img><div><div>

Another issue worth to mention:
I think that many people use both mods Embed Facebook BBCode and Ohara YouTube Embed and both mods modify the same img tag in different manner:

Ohara YouTube Embed converts the img tag into:
Code: [Select]
<img><iframe><video><div>
Embed Facebook BBCode into:
Code: [Select]
<img><div>
Maybe there is some way to unify this code for both mods?

Best regards
Matt
It's been fixed.  Hopefully this mod won't conflict with anything else...
« Last Edit: February 26, 2019, 12:39:45 PM by dougiefresh »

Offline Cola-Coca

  • SMF Hero
  • ******
  • Posts: 3,599
  • Gender: Male
Re: Embed Facebook BBCode
« Reply #182 on: March 03, 2019, 04:41:15 PM »
I apologize for having been absense for the last few months.  Life decided it wanted to rachect up the difficulty level some.... You know, computer problems, vehicle problems, work problems, etc.....

I'm looking for the cause of the issues that have been reported.....

Thank you very much. I hope you will quickly remove this problem.

Thank you.  :)
I LOVE SMF

Offline FishingManMatt

  • Semi-Newbie
  • *
  • Posts: 52
  • Gender: Male
Re: Embed Facebook BBCode
« Reply #183 on: March 09, 2019, 01:20:03 PM »
Once again, many thanks for your support, dougiefresh!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,859
  • Mod King
    • XPtsp.com Community
Re: Embed Facebook BBCode
« Reply #184 on: May 22, 2019, 04:59:24 PM »
Uploaded v3.12 - May 22nd, 2019
o Added support for SMF 2.1 RC2.
o Removed support for SMF 2.1 Beta 1.
o Updated the code for the embedded Facebook video.
o Modified installer to change <img> to <img><div> in two different places.



@Everybody:  Let me know if this version fixes the issues that were brought up.  It's been a long while since I coded anything for SMF, and I've forgotten what I did with this mod since my last coding session.  Thanks for your assistance and (hopefully) your understanding!

Offline villasg

  • Full Member
  • ***
  • Posts: 485
Re: Embed Facebook BBCode
« Reply #185 on: June 05, 2019, 07:06:26 AM »
Thanks , just now i made the update ......

Offline kitz

  • Jr. Member
  • **
  • Posts: 124
    • kitz.co.uk
Re: Embed Facebook BBCode
« Reply #186 on: July 07, 2019, 03:34:15 AM »
@dougiefresh

Thank you so much for attempting to fix this.  I installed this a couple of days ago and at first all seemed to be ok.   

Unfortunately I've since had to disable it after reports of the following issues.
  • It stops the ability to insert quotes from underneath the Post reply box for all members [see image 1]
  • Members who use the Quick Reply function are no longer able to quote any posts.  If they attempt to do so then they just get a green loading bar across the top of the screen. [see image 2]


Uninstalling the mod restores the ability to use the quote functions in both scenarios.

Offline kitz

  • Jr. Member
  • **
  • Posts: 124
    • kitz.co.uk
Re: Embed Facebook BBCode
« Reply #187 on: July 07, 2019, 03:35:04 AM »
PS the mod also seems to be unable to accept links which are in the following format
https://www.facebook.com/watch/?v=2260263807362303 and just displays  [ Invalid Facebook URL ]