Advertisement:

Author Topic: SMF Upgrader styles break on SSL 2.0.15  (Read 1785 times)

Online vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,898
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
SMF Upgrader styles break on SSL 2.0.15
« on: November 12, 2018, 11:20:32 AM »
SMF Upgrader styles break on SSL 2.0.15

upgrade.php
Change
Code: [Select]
$smfsite = 'http://www.simplemachines.org/smf';
To
Code: [Select]
$smfsite = 'https://www.simplemachines.org/smf';
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline live627

  • Developer
  • SMF Hero
  • *
  • Posts: 5,525
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: SMF Upgrader styles break on SSL 2.0.15
« Reply #1 on: November 12, 2018, 07:25:17 PM »
lolwut how does that break stylizing?? Confused. And amused.
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Online vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,898
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: SMF Upgrader styles break on SSL 2.0.15
« Reply #2 on: November 12, 2018, 07:42:22 PM »
If they are running the their forum on SSL the css/graphics won't load since it is fetched from http:// so the upgrade will appear odd to them same issue with the convertors.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline live627

  • Developer
  • SMF Hero
  • *
  • Posts: 5,525
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: SMF Upgrader styles break on SSL 2.0.15
« Reply #3 on: November 13, 2018, 12:37:26 AM »
The plot thickens.

Code: [Select]
upgrade.php:52: $smfsite = 'http://www.simplemachines.org/smf';
upgrade.php:3471: global $modSettings, $txt, $smfsite, $settings, $upcontext, $upgradeurl;
Found 2 matches for "smfsite".

Am I looking in the wrong file?
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Online vbgamer45

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 20,898
    • smfhacks on Facebook
    • VBGAMER45 on GitHub
    • @createaforum on Twitter
    • SMF For Free
Re: SMF Upgrader styles break on SSL 2.0.15
« Reply #4 on: November 13, 2018, 12:56:00 AM »
Nope that is the bad line right there missing https://
Code: [Select]
upgrade.php:52: $smfsite = 'http://www.simplemachines.org/smf';
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Full Member
  • *
  • Posts: 579
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: SMF Upgrader styles break on SSL 2.0.15
« Reply #5 on: November 13, 2018, 02:53:11 AM »
Fix has been submitted for 2.0.16
I promise you nothing.

Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline albertlast

  • Development Contributor
  • Full Member
  • *
  • Posts: 449
Re: SMF Upgrader styles break on SSL 2.0.15
« Reply #6 on: November 13, 2018, 10:50:52 AM »
Would be nice when you fix also the postgres setup,
this literial not work,
because of the wrong escape char for the holidays -> \' = wrong '' = right
look how it the 2.1 setup do.