• Welcome to Simple Machines Community Forum. Please login or sign up.
October 15, 2021, 07:37:13 PM

News:

Wondering if this will always be free?  See why free is better.


[2.0] No notifications sent on approving regular user's reply.

Started by harlow_1, November 12, 2019, 09:33:27 PM

Previous topic - Next topic

harlow_1

Quote from: Arantor on December 01, 2019, 02:48:06 PM
Well, at some point 2.0 will cease to be supported, but that's not going to be until whatever comes after 2.1 is ready.

And at some point, it's going to become more and more difficult to retrofit PHP compatibility changes; the changes in 7.2+ cannot be fixed across the board in core and all mods, right now they can be mitigated but the underlying problem cannot be fixed and at some point they will stop working and at that point it'll be about helping people move forward.

We still see people on 1.1; that came out in 2006, and it has been unsupported (outside of upgrades) for a while, but we're helping people upgrade to a version that isn't 13 years old, that does have security patches etc.

OK.  Sounds like I have long enough.  Thanks.

shawnb61

I have confirmed 2.1 is fine.  This behavior is only in 2.0.x.
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

harlow_1

Quote from: harlow_1 on November 12, 2019, 09:33:27 PM
No mods.
Default installation.
Moderation enabled and required on regular user replies.

File Subs-Post.php version 2.0.14    (in a 2.0.15 install)

Line 2854
is
   $topics[] = $msg['id'];
should be
   $topics[] = $topic;

Line 2914
is
   'TOPICSUBJECT' => $topicData[$row['id_topic']]['subject'],
should be
   'TOPICSUBJECT' => $msg['subject'];

Line 2959
is
   'POSTERNAME' = un_htmlspecialchars($topicData[$row['id_topic']['name']),
should be
   'POSTERNAME' = un_htmlspecialchars($msg['name']),

Line 2934
is
   sendmail($row['email_address'], $emaildata['subject'], $emaildata['body'], null, 'm' . $topicData[$row['id_topic']]['last_id']);
should be
   sendmail($row['email_address'], $emaildata['subject'], $emaildata['body'], null, 'm' . $msg['id']);

   A couple corrections:

What I said was line 2959 above appears to actually be line 2915.

It also appears that I missed line 2925 which has the same type of error.
Is:
                $replacements['BODY'] = $topicData[$row['id_topic']]['body'];
Should be:
                $replacements['BODY'] = $msg['body'];


This is just an FYI.  I understand you are not going to change it in 2.0 and that 2.1 doesn't have this problem.

shawnb61

Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

harlow_1


"Note:  This was logged earlier as #88"

Is there a way to view this #88?

Illori

our repo for SMF 2.0 is not public at this time, so the issue/bug tracker is not public.

Advertisement: