Advertisement:

Author Topic: What does this do? $settings['show_user_images']  (Read 321 times)

Offline Antechinus

  • SMF Friend
  • SMF Master
  • *
  • Posts: 25,109
  • Master of BBC Abuse
What does this do? $settings['show_user_images']
« on: February 04, 2020, 05:32:09 AM »
This code is called by default in various 2.0.x templates:

Code: [Select]
if (!empty($settings['show_user_images']) etc
What is it supposed to do? I can't seem to find a matching user setting in profile, or theme setting in admin.
Is this a deprecated legacy setting, that has just been sitting around for years without being active?

Reason I ask is because there is also this...

Code: [Select]
empty($options['show_no_avatars'])
...which appears to be trying to do the same thing. So why, exactly, is it supposedly necessary to have two separate conditions for choosing whether or not to display avatars?

Online d3vcho();

  • Sempiterno
  • Lead Localizer
  • SMF Hero
  • *
  • Posts: 4,276
  • Gender: Male
    • frandominguez03 on GitHub
Re: What does this do? $settings['show_user_images']
« Reply #1 on: February 04, 2020, 05:43:39 AM »
It's the settings for the theme, as follows:

Quote
$txt['user_avatars'] = 'Show user avatars in message view';

"Greeting Death as an old friend, they departed this life as equals."

Offline Antechinus

  • SMF Friend
  • SMF Master
  • *
  • Posts: 25,109
  • Master of BBC Abuse
Re: What does this do? $settings['show_user_images']
« Reply #2 on: February 04, 2020, 06:42:18 AM »
Ok, but what is the rationale behind it? What is its purpose in life?

If users want to see avs, they set it in profile. If they don't, they set that in profile too. What's the point of an extra admin setting?

Offline Antechinus

  • SMF Friend
  • SMF Master
  • *
  • Posts: 25,109
  • Master of BBC Abuse
Re: What does this do? $settings['show_user_images']
« Reply #3 on: February 04, 2020, 03:12:03 PM »
Something occurred to me. Is this setting supposed to be a way for the admin to reduce server loads, by disabling avatars? If so, that would make a certain amount of sense, although it would make even more sense if it was a global setting that automatically took care of all installed themes.