• Welcome to Simple Machines Community Forum. Please login or sign up.
November 29, 2021, 10:56:21 PM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


Very minor smiley bug

Started by Sir Osis of Liver, August 29, 2021, 12:54:36 AM

Previous topic - Next topic

Sir Osis of Liver

August 29, 2021, 12:54:36 AM Last Edit: October 14, 2021, 08:20:30 PM by Diego Andrés
Not something to lose sleep over, but one of my members posted this -

  (September 7 or 8)

You can see the result. ;)
"The best laid schemes o' mice an' men / Gang aft a-gley." - Robert Burns

Antechinus

That one has been around since 1.1.x. :D

Arantor

What exactly would you like it to do other than reading minds to know that shouldn't be processed as a smiley?

You have choices:
* change the smiley code away from 8)
* change the option for no smileys
* wrap it in the nobbc tag

But this is a problem most of the forum systems have had one way or another over the years. Mind-reading or being able to infer from context are a little bit out of scope.
No good deed goes unpunished
All helpful urges should be circumvented

Antechinus

I just put a space between any dodgy smileys and the closing bracket.
So (September 7 or 8 )

landyvlad

Yeah that's what I do too, but teh best way to prevent this is to redefine the shortcode for the smiley.

eg instead of
8)
use :8):
That is use a semicomon to start and end each shortcode.  Well that's one option anyway.
Please do not PM, IM or Email me with questions on astrophysics or theology.  You will get better and faster responses by asking homeless people in the street. Thank you.

To paraphrase Kindred: "There are no technical solutions to social problems."

Steve

Keeping in mind that will break any previous intentional posting of the 8) but it does solve the problem for the future. All my smileys are in enclosed in colons ...
Please do not PM me for support.

Antechinus

August 30, 2021, 04:16:24 PM #6 Last Edit: August 30, 2021, 04:51:28 PM by Antechinus
What happens if someone posts this?
:8):)Is that going to render as :8 ) :) once it is parsed?

Arantor

Smileys are parsed by length, longest first, then it's somewhat indeterminate exactly what will happen after that, but if :8):) is the string and :8): is a known smiley, you'll get smiley-followed-by-closing-parenthesis because :8): will be parsed first in its entirety.
No good deed goes unpunished
All helpful urges should be circumvented

Antechinus

Ok. That is the desired result, so good.

Steve

Darn! Arantor beat me to it ... like I knew that ...  :P
Please do not PM me for support.

Advertisement: