Where did 2.1 put the "new replies" warning?

[Grammy]

Hey, guys, where did you put the "Don't warn on new replies made while posting" warning in 2.1RC3 that was a profile option in older versions?  I'm just groping around like the old lady I am. 

  < ---  me

[Sir Osis of Liver]

Looks like it's been removed.

[Grammy]

Looks like it's been removed.

Ah....   well, it keeps popping up in the forum and I'd love to put it out of my misery.   

I'm trying to look through the Github files but search fields hate me. 

[Grammy]

I see this block in Post.english.php:

Code Select Expand

$txt['error_new_reply'] = 'Warning - while you were typing a new reply has been posted. You may wish to review your post.';
$txt['error_new_replies'] = 'Warning - while you were typing %1$d new replies have been posted. You may wish to review your post.';
$txt['error_new_reply_reading'] = 'Warning - while you were reading a new reply has been posted. You may wish to review your post.';
$txt['error_new_replies_reading'] = 'Warning - while you were reading %1$d new replies have been posted. You may wish to review your post.';


Now I need to find where else it's hiding...   

Post.php (slowly but surely...)

Code Select Expand

$txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply'];
else
$txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']);


Okay, is there an "off-switch"?  I'm no coder.   

[Sir Osis of Liver]

The code in Posts.php looks for a setting -

Code Select Expand



if (!empty($context['new_replies']))



but there doesn't appear to be an option in profile or member settings.  If you want to eliminate it for all members, this should work -

Code Select Expand



$context['new_replies'] = null;
if (!empty($context['new_replies']))



[Grammy]

I commented out those sections and things seem to be good.  I'm headed to bed, but I'd like to leave this marked unsolved just long enough to revisit the behavior? 

[Grammy]

The code in Posts.php looks for a setting -

Code Select Expand



if (!empty($context['new_replies']))



but there doesn't appear to be an option in profile or member settings.  If you want to eliminate it for all members, this should work -

Code Select Expand



$context['new_replies'] = null;
if (!empty($context['new_replies']))



Oh, thanks so much!  I'm sure all the members would be in agreement with getting rid of it.   

[Grammy]

Thanks again!   

[Grammy]

This is solved but if anyone sees my new reply, I just wanted to ask...  was this setting option deliberately left out of 2.1 or will it be in the finalized version?  I ask because I was kicking around the idea of actually trying to wrangle it back into profile settings, but I thought I'd wait to see if it was going to be included at some point.   

Just messing around on my test site. 

[Douglas]

I'm bumping this back up.

This is a CORE feature that MUST be restored before SMF 2.1 Final is released.

This needs to be an end-user configurable, as well as globally configurable option.

Thanks!

[shawnb61]

A friendly-ish reminder:
https://www.simplemachines.org/community/index.php?msg=4092196

An issue was logged:
https://github.com/SimpleMachines/SMF2.1/issues/6851

And PR merged:
https://github.com/SimpleMachines/SMF2.1/pull/6852

[Douglas]

Ahh, crap... totally forgot about that... but didn't see my post in search results, either.

Thanks, Shawn!