News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Themes and Layout settings Menu (Github)

Started by Shades., January 30, 2022, 09:06:13 AM

Previous topic - Next topic

Shades.

I'm still not familiar enough to post bugs on Github but just downloaded last nights nightly last_commit_a564c3d and I'm getting a "Themes and Layout settings Menu" popup menu that will not go away even by clicking on the red "X" but only when viewing my themes created before this commit. The popup does not appear in the new default theme.

Is this a bug or is there something I need to add or subtract to/from my previously created themes?

2.1RC4
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

marcosbr

Nothing in life is absolute. We are always learning... Did you know that?
https://amigosdaeletronica.com.br

Aleksi "Lex" Kilpinen

If it does not appear in the new default theme, then it is most likely not a bug in SMF but in the theme you are using.
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Shades.

#3
Quote from: Aleksi on January 30, 2022, 09:47:00 AMIf it does not appear in the new default theme, then it is most likely not a bug in SMF but in the theme you are using.
But the theme is based off of the default theme from an earlier Nightly download which only has color changes. Nothing else has been changed...same for my other two themes, i've only changed colors!?? ???

Edit: I changed my files back to an earlier download, last_commit_a272d26 (from 01/24/2022) and no popup! So something had to been changed in the newest Nightly!??
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

TwitchisMental

Quote from: Shades. on January 30, 2022, 11:21:36 AM
Quote from: Aleksi on January 30, 2022, 09:47:00 AMIf it does not appear in the new default theme, then it is most likely not a bug in SMF but in the theme you are using.
But the theme is based off of the default theme from an earlier Nightly download which only has color changes. Nothing else has been changed...same for my other two themes, i've only changed colors!?? ???
There are actually some big changes. If you were doing all the edits in index.css you will need to add the changes that have been done since you last did an install.

The specific issue that you are having currently is caused by the changes in the index.css and responsive.css. This is occurring on all of my themes aswell with the newest github build.(Well minus the one I have been updating...slowly)

This is just one of those things you can run into when using a development build.

TL:DR : You need to include all of the new github build theme changes to your theme.


Shades.

Yeah that's why I only use the nightly on my test sites. ;)

Do you know specifically what the css changes (or other theme changes) are so I can add/change them in my themes or a link to the github build addition/changes?
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean


TwitchisMental

Quote from: Shades. on January 30, 2022, 11:46:29 AMYeah that's why I only use the nightly on my test sites. ;)

Do you know specifically what the css changes (or other theme changes) are so I can add/change them in my themes or a link to the github build addition/changes?
Just a note here before I get started, what I have been doing personally is most likely not the norm..So you may wanna get others opinions on how to do this.   

What I have been doing is just putting all of my modified files in a separate folder. I then take the new version of the .css files and template.php files from the default theme and put them in my theme folder.

I then do a compare and contrast in notepad++ with the compare plugin.

This will show you the differences between the files and allow you to manually make the changes.

I then just add my changes one by one to the new files.

Since I use a custom.css for all of my themes I do not have much to do in terms of css besides replacing the standard .css files

------------------------------------------------

Now this is where someone comes in and tells you a much easier way XD.



Diego Andrés

Quote from: TwitchisMental on January 30, 2022, 12:05:26 PMSince I use a custom.css for all of my themes I do not have much to do in terms of css besides replacing the standard .css files

------------------------------------------------

Now this is where someone comes in and tells you a much easier way XD.

Well actually the only comment I have is that when using your own file for overwriting styles, is that you don't even need to load the index.css anymore because it'll still load from the default theme.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Diego Andrés

@Shades. how exactly do you replicate this issue and did you test it with the default theme using the latest build?

SMF Tricks - Free & Premium Responsive Themes for SMF.

TwitchisMental

Quote from: Diego Andrés on January 30, 2022, 12:09:01 PM
Quote from: TwitchisMental on January 30, 2022, 12:05:26 PMSince I use a custom.css for all of my themes I do not have much to do in terms of css besides replacing the standard .css files

------------------------------------------------

Now this is where someone comes in and tells you a much easier way XD.

Well actually the only comment I have is that when using your own file for overwriting styles, is that you don't even need to load the index.css anymore because it'll still load from the default theme.

See this is where I seem to have problems. For example right now I am working on my Blue Evolution theme.  If I remove the responsive.css, the Mobile Main Menu icon will get called from the default theme folder.  Which makes sense seeing as the responsive.css is now being called from the default theme folder aswell.

So the fix would be to just add that css code to my custom.css. Which would be something like below correct ? -

@media (max-width: 560px) {
.menu_icon {
    display: inline-block;
    background: url(../images/icons/menu.svg) no-repeat;
    height: 24px;
    width: 24px;
}
}

When I add that to the bottom of the custom.css it still calls from the responsive.css in the default theme folder. Now if I add !important to the background, it then shows.

Another really odd thing while were on this subject, I can put other code that would normally be found in responsive.css, but it work without issue.

Split this to another topic if need be by the way.

Shades.

Quote from: TwitchisMental on January 30, 2022, 12:05:26 PMI then do a compare and contrast in notepad++ with the compare plugin.

This will show you the differences between the files and allow you to manually make the changes.
Hey cool I just learned sumptin' from you again...lol! I have notepad++ but I didn't realize it had a compare plugin until just now. That will be very helpful! Thanks! ;)

Edit: I've BEEN using EditPad Lite 8

Quote from: Diego Andrés on January 30, 2022, 12:10:10 PM@Shades. how exactly do you replicate this issue and did you test it with the default theme using the latest build?
I just created my themes based off of the default theme and just changed colors in index.css, responsive.css and calendar.css. And then yesterday just uploaded the latest nightly which overwrites the default theme. So if I'm already in one of my previously created/edited themes I went into Admin>Configuration>Themes and Layout>Manage and Install to set my theme back to the default and thats when I get the popup.

This doesn't happen when I change back to default in/from my profile layout (which was the only way I could get back to default).
ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

TwitchisMental

Quote from: Shades. on January 30, 2022, 12:29:11 PM
Quote from: TwitchisMental on January 30, 2022, 12:05:26 PMI then do a compare and contrast in notepad++ with the compare plugin.

This will show you the differences between the files and allow you to manually make the changes.
Hey cool I just learned sumptin' from you again...lol! I have notepad++ but I didn't realize it had a compare plugin until just now. That will be very helpful! Thanks! ;)

Edit: I've BEEN using EditPad Lite 8
Notepad ++ actually has alot of useful plugins, all of which can be installed within a few clicks.

Just open Notepad ++ and then click Plugins > Plugins Admin > and pick a plugin that you need.

I use the compare and explorer plugins mostly.

marcosbr

In my case everything works fine. The error is only in the administration. This menu does not close!
Tested with 3 different themes!
Nothing in life is absolute. We are always learning... Did you know that?
https://amigosdaeletronica.com.br

marcosbr

All options change normally. If you close it is solved!
Nothing in life is absolute. We are always learning... Did you know that?
https://amigosdaeletronica.com.br

TwitchisMental

Quote from: marcosbr on January 30, 2022, 12:37:59 PMIn my case everything works fine. The error is only in the administration. This menu does not close!
Tested with 3 different themes!

Yep that would be due to the changes in index.css and responsive.css.

Pretty much all RC4 themes will need to be updated for final when it is released.

Shades.

ShadesWeb.com - Custom Logos - My Themes on SMF | My Themes on ShadesWeb
https://shadesweb.com

BikerHound.com - Sniffing out the road ahead
https://bikerhound.com

Dream as if you'll live forever; Live as if you'll die today. - James Dean

Advertisement: