News:

Wondering if this will always be free?  See why free is better.

Main Menu

Ohara YouTube Embed

Started by Suki, December 21, 2011, 03:04:59 PM

Previous topic - Next topic

Melonking

Quote from: Suki on May 06, 2023, 02:41:16 PMTheres a new version:

1.2.14 - May 06, 2023
- Remove imgur support
- Fix correctly displaying smileys after posting a video
- Use curl to make request to vimeo for getting the oembed info.

Thanks for the update! A few small bugs to report:
For some reason the embeds are injecting <br>'s on my forum; I gad to edit the iframe code in OharaYTEmbed.php to remove the whitespace; this fixes the br's

(I also had a weird bug where the play button was offset, fixing the whitespace also seemed to resolve that, but it might have also been restoring my old CSS file that had edits previously mentioned here regarding box borders)

e.g changed to:
$result = '<div class="oharaEmbed youtube" id="oh_'. $videoID .'"><noscript><a href="https://youtube.com/watch?v='. $videoID .'">https://youtube.com/watch?v='. $videoID . '</a></noscript></div>';
Also, I believe the fullscreen button is broken in the default script:
In ohyoutube.js this change needs to happen:
From:
iframe.allowfullscreen = 'allowfullscreen'To:
iframe.setAttribute('allowFullScreen', '')

Suki

Thank you for your reports @Melonking will check them out and release a new version, sadly I cannot guarantee when it will be released due to time constraints but will def look into this.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Suki

New 1.2.x version has been released:

1.2.15 - Dec 18, 2023
- Fix setting for allowFullScreen
- Don't need to parse new lines and spaces
- Add phpunit tests
- Mod now requires PHP 7.1
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Advertisement: