Stop Forum Spam

[Steve]

@SleePy - Is that something we should all do or is that tailored to a specific poster's problem?

[SleePy]

You can do it.  Its fixing a issue where the data is returning null rather than an array and PHP is more strict about type handling, throwing a error about merging an array and null.  I have a update I was working on that I will release someday soonish that will include the fix. https://github.com/jdarwood007/smfmod_sfs/pull/16/commits/08fc46565e7bb35f3ce87c3d566a02308cfcf743

I believe that PHP 8.2+ complains, so if your on 8.1 or below, you shouldn't get the error.

[Steve]

There is a conflict between this mod and the Topic Participants mod. I posted about the problem here: https://www.simplemachines.org/community/index.php?msg=4159497 but found out that if I remove this mod and then add the Topic Participants one, the error I was getting goes away.

Just making you aware of it.

[SleePy]

I'm not getting the error.

Your steps are to
1. Go to ACP > Error Log
2. Truncate Error Log
3. Navigate to Home

[woolly bugger]

running smf 2.1.4 just uninstlled SFS 1.4 and tried to install 1.5.1 and it hoses the board.

during the install the screen changed to:

"This page isn't working right nowwww.brfff.com can't currently handle this request.
HTTP ERROR 500"


Help!

[Steve]

@SleePy, for reference regarding @woolly bugger's post: Installing mod hosed my board?

[SleePy]

I can't reproduce that.  I uninstalled the 1.4 and installed the 1.5.1 without any errors.

You can use repair_settings.php tool (on downloads page) to remove hooks.  Upon removal of hooks you can uninstall the mod and reinstall it.  You could also try fix_packages tool but it may not load if SMF isn't working.

[woolly bugger]

I can't reproduce that.  I uninstalled the 1.4 and installed the 1.5.1 without any errors.

You can use repair_settings.php tool (on downloads page) to remove hooks.  Upon removal of hooks you can uninstall the mod and reinstall it.  You could also try fix_packages tool but it may not load if SMF isn't working.

i think it was a PHP version problem -- up graded to 8.2 but now I see that the errors I was getting may need to downgrade to 8.1?? to eliminate errors.

[SleePy]

What errors are you getting?
PHP 8.2 just complains a bit more about type juggling.  Mostly it shouldn't cause issues, just warnings.  SMF has been fixing issues regarding this.

[woolly bugger]

ERROR messages after install,

Hook call: function "SFS::hook_pre_profile_areas" in file /home/XXXXX/public_html/forum could not be called.


mods instslled
You cannot view this attachment.

[SleePy]

I fixed it up in 1.5.2.

[Naytheet]

typos in SFS-Admin.php :

$config_vars = $this->getConfiguraiton();

$this->saveConfiguraiton($config_vars);

[ZabiinoOo]

have errors this mod

PHP Parse error:  syntax error, unexpected 'array' (T_ARRAY), expecting variable (T_VARIABLE) in Sources/StopForumSpam.php on line 16

line 16:

Code Select Expand

private array $changedSettings = [];

[live627]

Can you upgrade your PHP? The latest update seems to have introduced changes that break on older PHP.

[SleePy]

Yes, the type hints are PHP 8.0.  You should upgrade your php to a supported release: https://www.php.net/supported-versions.php
Also note that 8.0 is also no longer getting security fixes in one month.  However some distros will backport security fixes still.

[Naytheet]

Your web hosting company just give instruction on how to update it, I just had to click on a button in my client area.

[MobileCS]

Any chance of you adding an option to disable the "logAction" part?

It's making me think there are actual forum errors, when it's just a block notice.

The logs in "SFS Logs" is more than enough for me.

[MobileCS]

Sorry, I meant "fatal_error".

An option to turn this :

Code Select Expand

fatal_error($this->txt('sfs_request_blocked'));
in to this :

Code Select Expand

fatal_error($this->txt('sfs_request_blocked'), false);

[SleePy]

I've updated to 1.5.3 which fixes that.  if you applied that change, you don't need to upgrade.  Only other change was a typo correction.

[MobileCS]

Thanks!