NameX

[jsx]

Can I get such a link that shows the exact changes in the files?



Example:

https://github.com/SMFTricks/NameX/compare/v1.3.1...v1.3.2

[Diego Andrés]

It's linked in the post, click on the Files changed tab:
https://github.com/SMFTricks/NameX/compare/v1.3.2...v1.4

[jsx]

Thanks for the information, those github files confused me and I thought there was information only about .github files in this tab, example: .github/FUNDING.yml

What is the compat folder that has css files inside? What is this needed for?

Will the changes I have made in custom/app.css, dark.css, variants.css work in NameX 1.4?

[Diego Andrés]

What is the compat folder that has css files inside? What is this needed for?

Not used in NameX, it's just a shared set of files for my themes.

Will the changes I have made in custom/app.css, dark.css, variants.css work in NameX 1.4?

Yes, sent you some info in the PM, it's all described in the note from the release post.

[willerby]

Hi Diego, 

I've been running NameX on my forum since upgrading to 2.1.14 (still think it;s fab!) but have just hit an issue which I'm pretty sure was due to turning on (and off) the Recaptcha within Admin. I may be wrong and it may be a coincidence but the timing of the issue is uncanny.

Anyway, I posted in the 2.1 support forum before realising that the issue only presents itself on the theme and is fine if I revert back to the default SMF theme. It's a weird one...

https://www.simplemachines.org/community/index.php?topic=589357.0

Any ideas on where to look for a solution greatly appreciated. The topic is also still live on 2.1 support but suspect it will get closed down as it is theme specific.

Many many thanks

[Diego Andrés]

There isn't anything in the theme that directly interacts with the captcha, I'm unsure about the issue you're facing.

It could also be an issue caused by a MOD that somehow isn't installed in the theme. Not much information to diagnose the issue.

Are you running PHP 8+? The theme wasn't compatible with PHP 7.4 in the last update, I don't recall if previous versions had any issue.

One way to confirm it as a theme issue would be if you install either Repulse or Endar themes (just for testing, you can delete them afterwards), they all use the same code 'library'. However the issue is that all theme were also recently updated, including NameX, so wouldn't be an accurate test if your NameX theme using a previous version.

[willerby]

Thanks Diego,

I installed the latest version just to check it wasn't my older one and same issue. My server tech guy says doubling the PHP memory allocation didn't fix the issue but quadrupling it did! He thinks that is excessive though and it's not needed for the default theme.

We are running PHP 7.4 and although we haven't had an issue with the prior version of NameX for overf a year I suspect you are right and it is a combination of the Tiny Portal mod and the theme causing an issue.

WIll keep looking but may need to revert back to an alternative theme.

[Diego Andrés]

Should try using PHP 8 then, the theme won't work in PHP 7.4

[Diego Andrés]

1.4.1 - 09 August 2024

• Improved yellow variant for Dark Mode.
• HTML attributes definition.
• Fixed issues with the defaults for Variants and Dark Mode.
• Fixed issues with the data attributes for the Variants and Dark Mode.

Full Changelog: v1.4...v1.4.1

[Diego Andrés]

1.4.2 - 10 August 2024

• Fixed issue with minification of CSS and JS files.

Full Changelog: v1.4.1...v1.4.2

[jsx]

Diego I noticed on the smf.pl forum in a thread that the theme is broken. What could be the cause?



https://www.smf.pl/index.php/topic,13143.0.html

[Diego Andrés]

Looks like there are some code tags inside other code tags? I wouldn't know.
If you can figure out what part of the post causes it I can try to reproduce it and fix it.

[jsx]

This code embedded in the code tag causes this bug:

Code Select Expand

<?php phpinfo(); ?>

[Diego Andrés]

Is it only that causing the issue?
I tried it on a clean board and it doesn't break anything, perhaps a MOD is causing it?

[jsx]

When I removed this code from this topic, this bug did not appear. But it is possible that bug is in NameX 1.2.2, from what I see smf.pl uses NameX version 1.2.2, it is quite an old version of the theme.

[gevv]

Hello,

@Diego Andrés
 I am trying to switch to the current version. (v1.2.7 to v1.4.2)  How to add "class" between the code


v1.4.2 boardindex template;

Code Select Expand

<div class="board_icon">
', function_exists('template_bi_' . $board['type'] . '_icon') ? call_user_func('template_bi_' . $board['type'] . '_icon',  $board) : template_bi_board_icon($board), '
</div>

I used v1.2.7 boardindex template;

Code Select Expand

function template_bi_board_icon($board)
{
global $context, $scripturl;

echo '
<a href="', ($context['user']['is_guest'] ? $board['href'] : $scripturl . '?action=unread;board=' . $board['id'] . '.0;children'), '" class=" w', $board['id'], ' board_', $board['board_class'], '"', !empty($board['board_tooltip']) ? ' title="' . $board['board_tooltip'] . '"' : '', '></a>';
}
I add board icons with class="w'

[Diego Andrés]

Yes, you're looking at it correctly.
Add it before the 'w', mind the space which is already present so add it after the double quotes.

class="board_icon w...

[gevv]

I think I'm doing something wrong 

Code Select Expand

'" class=" w', $board['id']
How can I add the class code to the code below?

v1.4.2

Code Select Expand

<div class="board_icon">
', function_exists('template_bi_' . $board['type'] . '_icon') ? call_user_func('template_bi_' . $board['type'] . '_icon',  $board) : template_bi_board_icon($board), '
</div>

The version I used in the old version (v1.2.7);

Code Select Expand

function template_bi_board_icon($board)
{
global $context, $scripturl;

echo '
<a href="', ($context['user']['is_guest'] ? $board['href'] : $scripturl . '?action=unread;board=' . $board['id'] . '.0;children'), '" class=" w', $board['id'], ' board_', $board['board_class'], '"', !empty($board['board_tooltip']) ? ' title="' . $board['board_tooltip'] . '"' : '', '></a>';
}

[Diego Andrés]

Did you edit it before or what is it you're trying to do?
If it's not edited you could just replace the files.

If you're adding a custom class selector, you can do that in the same div, the updated theme simply prints the content, the wrappers are what you see in the BoardIndex.template.php

[gevv]

Thanks @Diego Andrés 

<div class="board_icon">
                           

Code Select Expand

<div class="board_icon">

<a href="', ($context['user']['is_guest'] ? $board['href'] : $scripturl . '?action=unread;board=' . $board['id'] . '.0;children'), '" class=" w', $board['id'], ' board_', $board['board_class'], '"', !empty($board['board_tooltip']) ? ' title="' . $board['board_tooltip'] . '"' : '', '></a>
</div>