Upgrade 2.1.4 -> 2.1.5 "Undefined variable $sid"

[Volker S]

Unfortunately, the suggestion in the MobileCS thread does not work for me.
Only the QueryString.php file is affected in my case, and without the suggested change by shawnb61, it shows the error on line 677, and with the change, the error is on the changed line 670.
Attached is a picture of the changed file [function($m) -> function($m) use ($sid)].

[shawnb61]

The above code is 2.1.4 code, not 2.1.5 code.  That's why it's not working for you.

Are you sure the 2.1.5 patch installed clean, without errors?  (It must've failed, because that's old logic...)

I would revert that tweak, then try to figure out what happened to your 2.1.5 patch.

(This topic is more of a support issue than a bug...)

[Volker S]

I have two copies of the 2.1.5 upgrade in the package manager. Should I delete one of them and then uninstall the second one?
According to the footer (see image), I am on 2.15. Can't I just download the large package (upgrade.php) and then simply use the new file?
If I still get errors, then I'll probably have to reinstall.

[Volker S]

I replaced the old QueryString.php with the new one containing your changes, and a little later subs.php appeared with the same error message.
This file was already version 2.1.5, and I just had to write in your changes.
Now everything seems to be working (so far). Thank you...

[shawnb61]

A couple questions, since I'm still trying to figure out how you got two 2.1.5 entries in the package manager...

 - Did you attempt a deinstall of 2.1.5 at any point?
 - Did you get the 'version mismatch' error at any point?
 - If you run the verison check in the admin console, do all files (other than language files) show as 2.1.5?

Any details regarding all steps taken before you saw the duplicate entries in the package manager might help. 

[Liviu Lalescu]

Also I obtained two entries for 2.1.5. As I said in my topic, I tried to install, obtained blank page, clicked Back and tried again to install.

I then removed one of the two entries.

[shawnb61]

Also I obtained two entries for 2.1.5. As I said in my topic, I tried to install, obtained blank page, clicked Back and tried again to install.

I then removed one of the two entries.

Oh no...

& Thanks for that important detail...

[Volker S]

I can't say when I received the duplicates, but I can tell you that I forced the forum upgrade today.
It started when I looked at my admin console today and saw that two updates were available. The add-on module update for "Automatic Attachment Rotation (and Resize)" and the forum upgrade.
I was able to perform the former online without any errors in the package management. After that, I noticed that something was wrong with the listed packages.

I had 3x SMF 2.1.5 listed as not installed and had not attempted to install it until then. Up to this image (Autorotation_löschen.jpg), I had only updated the autorotation online without any errors. Then I started the file check as if I wanted to perform the upgrade online. But I not chose one of the 3 duplicate modification notes (SMF 2.1.5 update -> image Autorotation_löschen.jpg), I chose the Upgrade of the table field above the listed modules.

During this check, two files failed the upgrade compatibility check for the forum software (these files were manually adjusted and the changes were suggested in the forum by the "Autorotation" add-on). I then asked in this forum and was told to uninstall Autorotation, then install the forum upgrade and reinstall the latest Autorotation. This failed because I could only delete Autorotation (see image).

Then the Autorotation developer suggested starting the forum upgrade online and installing the latest Autorotation afterwards. Now I have the image posted above (SMF_nach_Upgrade.jpg).

However, a final version check looks good (SMF-Versionscheck.jpg).

Edit_1: You wrote "- Did you attempt a deinstall of 2.1.5 at any point?" Answer: No

Edit_2:
Which entries can I delete without causing any problems (image "SMF_nach_Upgrade.jpg")?
I would delete:
The lower 2.1.5 update and "Automatic attachment Resize 6.24".

[Volker S]

I can't delete the lower "2.1.5 Update" because it's installed. So I just have two entries from "2.1.5 Update".

But I already have a plan to change that -> Link

[GL700Wing]

I can't delete the lower "2.1.5 Update" because it's installed. So I just have two entries from "2.1.5 Update".

You need to uninstall the "2.1.5 Update" and then delete all the copies of the mod before you try and install it again.

[NukeWorker.com]

I also have this issue. Clean package install with no issues/errors. No mods/other packages installed.

 Error

Type of error

Undefined_vars

Error message

Code Select Expand 2: Undefined variable $sid

File

/path/forum/Sources/QueryString.php

Line

677

URL of page causing the error

url/forum/index.php?topic=24710.msg126337%3Btopicseen

Backtrace information

• #0: smf_error_handler()
  Called from /path/forum/Sources/QueryString.php on line 677
• #1: {closure}()
  Called from unknown on line -1
• #2: preg_replace_callback()
  Called from /path/forum/Sources/QueryString.php on line 671
• #3: ob_sessrewrite()
  Called from unknown on line -1

[shawnb61]

Solution was spelled out in the other thread.

See tweak for QueryString.php here:
https://www.simplemachines.org/community/index.php?msg=4191110

And the tweak for Subs.php here:
https://www.simplemachines.org/community/index.php?msg=4191118

[Aleksi "Lex" Kilpinen]

#8393