After update, quick replay 'more' button stopped working in custom theme?

[pulgoki]

I don't know if this is an appropriate question to ask since this is a custom theme that I created a long time ago.

After updating from 2.1.4 to 2.1.5, then 2.1.6, the 'more' button stopped working in my custom theme. I don't know why that would have happened?

I have a login that uses the stock theme and it's not broken there.

Any idea why this would have broken and if it's a potential easy fix? The custom theme is based on the stock theme with mostly cosmetic changes. 

[Kindred]

what exactly do you mean by "the more button"?

URL demonstrating the issue?

[Illori]

in the topic display page on the right side of each post is a "More..." button.

[pulgoki]

what exactly do you mean by "the more button"?

URL demonstrating the issue?

The button in the quick reply box that opens up additional emojis.

[Illori]

check in your browsers inspect tool/developer tools console for any related errors on the page.

[pulgoki]

I did that and didn't see an error. 

I'm trying to dig in to this but it's been a couple of years since I've worked on a theme so I'm trying to get my wheels back.

I think that something was changed in the Settings.template.php in the update.  I allowed it to make a change to the theme.  I don't usually do that. 

I'm a little rusty as I haven't had to debug issues in a very long time.

[pulgoki]

I opened a guest browser in Brave and the button seems to work in there.

I don't know if this is some kind of cache issue?

I cleared all of my browser cache in firefox and still have the issue in there. 

Same issue in Brave until I opened a guest browser. 

[Sesquipedalian]

It sounds like you have something broken in your JavaScript. You should open your browser's JavaScript console and see what error it reports.

[pulgoki]

It sounds like you have something broken in your JavaScript. You should open your browser's JavaScript console and see what error it reports.

In chromium, I get this error.. jquery.min.js  deprecated feature used

[Lucarella]

This problem is also occurring on my forum and was reported to me a couple of days ago.
With Chrome, the popup opens but doesn't work properly, while with Edge and Firefox, it doesn't open at all.
All this with 2.1.6.
I just looked on a test forum that's still on 2.1.4 and works fine with all three browsers, so there's something wrong with the latest updates (2.1.5/2.1.6).

[shawnb61]

I see no issues with the MORE button in 2.1.6 in Chrome, Firefox or Edge.  It's operating properly.

Browsers & jquery have been working on deprecating/removing unload events for years.  jquery removed the functions back in 3.0.  SMF by default uses 3.6.3.

So...
- It might help to share which mods/themes are in use, to find a common thread.
- It might help to grep source code in /Themes & /scripts, e.g., for "unload\(".

Not sure why the error would have popped up at this time.

Chrome is playing catchup here:
https://developer.chrome.com/docs/web-platform/deprecating-unload

More info:
https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event

[Lucarella]

Maybe I figured out what the problem is...
I tested the default theme and everything worked fine, so I also tried the other themes I installed and noticed that only the TwitchisMental themes had this problem. I have the Halloween theme and the GreyedOut theme.
Now I'll mention @TwitchisMental  here so they can come over and see if they can figure out the problem.

[shawnb61]

First step would be to make sure you're current.

I cannot reproduce the issue on the latest version of Greyed Out.

Note that @TwitchisMental has been putting out v2.1.5/2.1.6 versions of their themes.

[pulgoki]

I just looked on a test forum that's still on 2.1.4 and works fine with all three browsers, so there's something wrong with the latest updates (2.1.5/2.1.6).

Same here.  It started right after the update.

I noticed that if I use the reply button, the more button works on that editor. Just not on the quick reply. Trying to get a consistent error is frustrating. It just doesn't seem to work.

If I use the Brave browser and use inspect, the more button will work while the developer tools are open. Still, I don't see an error.

[TwitchisMental]

Please be sure that you are using the latest version of the Greyed Out theme. It should resolve this issue for you.

Just tested in Firefox and Chrome to be sure.

[pulgoki]

It it possible to revert back to 2.1.4 until I can get this figured out on a test forum?

I ran the update from 2.1.4 -> 2.1.5 -> 2.1.6 on a test server but everything seemed to work fine. I didn't notice this anomaly until I had already updated the live forum.

To add as an FYI, this button still seems to work fine in all of my phones browsers.   

[Illori]

check the parse of each patch and see what changed and make sure all changes have been applied to your theme correctly.

https://custom.simplemachines.org/index.php?action=patches

[pulgoki]

Could this be the culprit? I didn't see anything else that looked like it would be the cause.

I have a custom jquery.sceditor.theme.css although it doesn't have the lines that are shown to be modified.

./Themes/default/css/jquery.sceditor.css

My custom jquery.sceditor.theme.css doesn't have this in it at all -

Code Select Expand

@media screen and (min-width: 1024px) {
div.sceditor-smileyPopup {
max-height: 50%;
width: 50%;
position: fixed;
}
#sceditor-popup {
height: 100%;
}
#sceditor-popup-smiley {
height: 90%;
overflow: auto;
}
}
@media screen and (max-width: 1024px) {
div.sceditor-smileyPopup {
width: 90%;
position: absolute;
}
The file in the default theme folder was edited to reflect the following

Code Select Expand

div.sceditor-smileyPopup {
top: unset;
left: 0;
right: 0;
transform: unset;
position: absolute;
min-height: 100px;
min-width: 250px;
margin-inline: auto;
display: flex;
box-sizing: border-box;
max-height: 215px;
max-width: 450px;
}
div.sceditor-smileyPopup #sceditor-popup {
width: 100%;
display: flex;
flex-direction: column;
}
div.sceditor-smileyPopup #sceditor-popup div#sceditor-popup-smiley {
flex-grow: 1;
align-self: flex-start;
}
div.sceditor-smileyPopup #sceditor-popup span.button {
margin-top: 20px;
align-self: center;

[shawnb61]

Worth a try.

If you have a customized version of /scripts/jquery.sceditor.smf.js I'd compare that to current as well. 

[pulgoki]

Worth a try.

If you have a customized version of /scripts/jquery.sceditor.smf.js I'd compare that to current as well. 

That seemed to have fixed my problem.  The "Replace With" text has a missing closing bracket which threw me through a loop for a minute, but once I noticed that, everything worked fine.

Theme back up and running.

I didn't have a jquery.sceditor.smf.js  It appears to have just been the change in the CSS.

Thanks! 

check the parse of each patch and see what changed and make sure all changes have been applied to your theme correctly.

https://custom.simplemachines.org/index.php?action=patches

Thank you very much for this suggestion. This solved the problem for me.