News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

WoW Itemstats

Started by DarkCloud14, December 26, 2005, 08:58:53 PM

Previous topic - Next topic

Polleke

DarkCloud,

With ItemStats 1.25.9.3 and SMF 1.1.6. When you post something starting with an itemlink SMF will bug out saying the post is empty. Even if text is following the itemlink. This only happens with WoWHead tooltips.

This bug is caused by the default strip_tags() PHP function in sources/Post.php is applied on the parsed BCC tags. What happens is that strip_tags() can't handel HTML comments inside another tag. WoWHead puts HTML comments like <!--e--> and <!--s1666--> in their tooltip HTML. The fix is to strip these comments from the tooltip.

In Sources/itemstats/includes/wowhead.php on line 129:
$item['html'] = preg_replace('#<!--(.*?)-->#s', '', $item['html']);

Hope that helps.

DarkCloud14

#461
Ahh that's what several people where speaking of  >:(
Never created a post without text before the item.. Will fix that with the next version
Thanks!!

@pomi:
I'll take a look at it and if I've a solution I'll let you know..

Azphat12

Ok I am hitting a wall here, hopefully you guys can help...

Here is my site first of all

http://www.darkaftermath.org 
EQDKP = http://www.darkaftermath.org/eqdkp [nofollow] (check item values)
What I have is

SMF 1.1.6
Tinyportal 0.983
Eqdkp 1.3.2

So far I have Itemstats 1.5.5 working in eqdkp (minus the icons..sigh)
I have your version working in SMF

I cannot for the life of me get this to work in Tinyportal.
The links I have on there now are from WoWDigger

I have tried your code in the first page.  I tried Laric's code from like page 4 or 5..

Is there 1 itemstats that works on everything??

I have smf/tp in the samve database
eqdkp it its own.

Azphat12

Small update..

It seems to be showing the itemstats....but it has alot of error code too.

string(40) "Unable to connect to SQL host: localhost" Earthwarden
Looted by Gyza
string(40) "Unable to connect to SQL host: localhost" Blinkstrike
Looted by Gyza

That is what is show, however the items are showing.  No icon, but the link only.

Azphat12

Fixed the errors.  Appears I needed to add the dc14 or what not in the code.  However I still cannot get this to work in articles.  When I put in the wowitem tag in any article it shows me a white screen.

RavenDT

I have a fresh installation of SMF v1.1.6 and tried installing ItemStats. I am trying to make sure it installed right and test it out, but as soon as I go into my admin panel, I get the following error:


Parse error: syntax error, unexpected ',' in .../Themes/default/Admin.template.php on line 1159

1150: <td><a href="', $scripturl, '?action=helpadmin;help=maintenance_general" onclick="return reqWin(this.href);" class="help"><img src="', $settings['images_url'], '/helptopics.gif" alt="', $txt[119], '" align="top" /></a> ', $txt['maintain_title'], ' - ', $txt['maintain_general'], '</td>
1151: </tr>
1152: <tr>
1153: <td class="windowbg2" style="line-height: 1.3; padding-bottom: 2ex;">
1154: <a href="', $scripturl, '?action=optimizetables">', $txt['maintain_optimize'], '</a><br />
1155: <a href="', $scripturl, '?action=detailedversion">', $txt['maintain_version'], '</a><br />
1156: <a href="', $scripturl, '?action=repairboards">', $txt['maintain_errors'], '</a><br />
1157: <a href="', $scripturl, '?action=boardrecount">', $txt['maintain_recount'], '</a><br />
1158: <a href="', $scripturl, '?action=maintain;sa=logs">', $txt['maintain_logs'], '</a><br />', $context['convert_utf8'] ? '
1159: <a href="', $scripturl, '?action=cleanwowitems">', $txt['maintain_wowitems'], '</a><br />
1160: <a href="' . $scripturl . '?action=convertutf8">' . $txt['utf8_title'] . '</a><br />' : '', $context['convert_entities'] ? '
1161: <a href="' . $scripturl . '?action=convertentities">' . $txt['entity_convert_title'] . '</a><br />' : '', '
1162: </td>


I checked and rechecked the syntax and it seems correct. I can't quite figure it out. Any help would be appreciated.

RavenDT

#466
Okay. I took the problematic line, 1159, and replaced the commas with periods...


<a href="' . $scripturl, '?action=cleanwowitems">' . $txt['maintain_wowitems'] . '</a><br />


And that seems to work. The link is there in the Admin/Maintenance section, it shows up properly, when I click the button is replies with "Maintenance Complete."  So I believe that might have fixed it, but I don't understand why it has to be done that way. *Shrugs*...

However, another problem has arisen. Although the itemlinks in posts seem to work fine, I end up getting an error on my browser when I load a page with a link... Error says:

Quote
Line: 857
Char: 3
Error: Object required
Code: 0
URL: hxxp:defiance.ravendt.net/index.php?topic=2.msg10 [nonactive]

And that's all it says. Wondering if anybody has experienced this and would know of a fix.

Edit: It works fine on default board theme, but when I use a different board theme, I get the Javascript error. I tried looking into it but can't seem to figure it out. Any of the files I had to update in the Themes/default, the Theme I am using currently does not have Admin.template.php or any of those. I am at a loss. It just produces the Javascript error, but the itemstats links work fine otherwise, which is strange.

Pluemaster

Is this mod dead? Or are we just waiting for an update to 1.1.7?

Garou

I wouldn't call it dead. I'm sure DarkCloud is just busy, he hasn't even posted on his own site in about a month. You might try there for some more answers though. www.darkcloud14.de

I'm using this on 3 sites that have been upgraded to 1.1.7 without any problems.  You might have to do some hand coding to make it work with a fresh 1.1.7 install. I haven't tried it yet.

clarkkent93

How do I make an itemstats BBC button?

Thanks for help and a great mod.

SMF 1.1.6

Garou

I wrote a mod a while back that does this but SMF wouldn't approve it as its an addon for an existing mod. That said...

Add one of the attached images in your Themes/theme name/images/bbc directory.

The item.gif was my original creation and works great if your using this for something other then World of Warcraft.

The itemstats.gif looks more like the warctaft logo and much better on World of Warcraft guild site.

In your Themes/theme name/Post.template.php
Find...
'flash' => array('code' => 'flash', 'before' => '[flash=200,200]', 'after' => '[/flash]', 'description' => $txt[433]),

If your using the itemstats.gif then...
Add after...
'itemstats' => array('code' => 'itemstats', 'before' => '[wowitem]', 'after' => '[/wowitem]', 'description' => $txt['itemstats']),
'img' => array('code' => 'img', 'before' => '[img]', 'after' => '[/img]', 'description' => 'wowitem'),


If you wish to use the item.gif then...
Add after...
'item' => array('code' => 'itemstats', 'before' => '[wowitem]', 'after' => '[/wowitem]', 'description' => $txt['itemstats']),
'img' => array('code' => 'img', 'before' => '[img]', 'after' => '[/img]', 'description' => 'wowitem'),


jasendorf

Quote from: Pluemaster on November 12, 2008, 11:53:27 AM
Is this mod dead? Or are we just waiting for an update to 1.1.7?

OK, for those who are technically minded... here's what I know works (because I just made the mistake of uninstalling wowitemstats before upgrading to 1.1.7 and then trying to install the new wowitemstats only to find out that it doesn't like it because it doesn't think that it si ready for 1.1.7)

TRY AT YOUR OWN RISK... IT WORKED FOR ME

1. Open up the latest version of the package and extract package-info.xml
2. Using a text editor, change these two lines in the xml file:

Find:
   <install for="1.1.6">

Change to:
   <install for="1.1.6, 1.1.7">

Find:
   <uninstall for="1.1.6">

Change to:
   <uninstall for="1.1.6, 1.1.7">

3. Put the xml file back in the zip file.
4. Install the package as usual.

Garou

Yes that should work. For those that upgraded to 1.1.7 with itemstats installed the mod works just fine so installing it on 1.1.7 only runs into the problem with the version number.

Uess something major changes in the 1.X.X  series of SMF I cant see  the mod not working in the future.

Hopefully the author will get around to updating that soon, as well as a SMF 2.0 port but then many authors are holding out till 2.0 is finalized.

DarkCloud14

Uhh damnit,

really many problems happened and I'm really sorry about not answering/helping out somehow
but I just didn't have much time and still don't have enough time at the moment but as soon as possible I'll
check out everything and try to help as good as possible

thecompletists

#474
Please help, I really need to get this mod working for my SMF version 1.1.7. When attempting install, I get this error: The package you are trying to download or install is either corrupt or not compatible with this version of SMF.

So... I did some research and tried the below fix, and tried finding the below text in the package-info.xml, didn't see these exact words, and any edits I made corrupted the file. Would anyone happen to have this available via a zip or winRar or another way to fix? I'd really appreciate ANY help you can provide.

Please help!

Quote from: jasendorf on November 24, 2008, 03:23:43 PM

OK, for those who are technically minded... here's what I know works (because I just made the mistake of uninstalling wowitemstats before upgrading to 1.1.7 and then trying to install the new wowitemstats only to find out that it doesn't like it because it doesn't think that it si ready for 1.1.7)

TRY AT YOUR OWN RISK... IT WORKED FOR ME

1. Open up the latest version of the package and extract package-info.xml
2. Using a text editor, change these two lines in the xml file:

Find:
   <install for="1.1.6">

Change to:
   <install for="1.1.6, 1.1.7">

Find:
   <uninstall for="1.1.6">

Change to:
   <uninstall for="1.1.6, 1.1.7">

3. Put the xml file back in the zip file.
4. Install the package as usual.



starrbuck

Quote from: thecompletists on December 01, 2008, 10:02:20 PM
So... I did some research and tried the below fix, and tried finding the below text in the package-info.xml, didn't see these exact words, and any edits I made corrupted the file. Would anyone happen to have this available via a zip or winRar or another way to fix? I'd really appreciate ANY help you can provide.

Please help!

The words may or may not be exact.  Anywhere you see "1.1.6" just add "1.1.7".  Make sure you save the changes back to the ZIP file.

DuaneSimms

For now the rename of the 1.1.6 to 1.1.7 works.

DarkCloud14

A new version is out please try it out and if it doesn't work please post here.
As I've more time at the momen I can help you better at least I hope so  ;)

You can also post problems at www.darkcloud14.de

ssjmarshall

Heya, just installed the itemstats, and was really really easy too do loved it.  Currently any item I try to link ends up gray with a black background and says allakazam is busy or item dosn't exist, and will say that even if I change it to search on wowhead or buffed.   I'm not the smartest person on how to fix this lol 

neceros

Quote from: ssjmarshall on January 05, 2009, 10:11:02 PM
Heya, just installed the itemstats, and was really really easy too do loved it.  Currently any item I try to link ends up gray with a black background and says allakazam is busy or item dosn't exist, and will say that even if I change it to search on wowhead or buffed.   I'm not the smartest person on how to fix this lol 

Same issue here. Thanks.

Advertisement: