News:

Want to get involved in developing SMF? Why not lend a hand on our GitHub!

Main Menu

Removing thread without post counts going down

Started by Tristan Perry, April 20, 2004, 01:21:45 PM

Previous topic - Next topic

bulliedog

Sort of.  I guess what I am saying is that it seems to me that a good way to manage it would be to have post count decrease only when the topic is deleted from the recycle board.  That way, topics that are removed from the normal boards don't affect post count until you later decide as moderator that the the topic was truly garbage and delete it from the recycle board. 

Hopefully this is a more clear example of what I thought the recycle bin did:

Step 1. You delete a post, and it checks to see if it should use the recycle bin - it should.
Step 2. Nothing happens to post count at this time since the post is still on the forum (in recycle board)
Step 3. You decide to delete the post (from the recycle board) -- this decreases the poster's post count.
Step 3. The message gone.


[Unknown]

But, what if...

  - you use the recycle bin only for admins, and you don't want your moderators getting confused when they delete people's posts?
  - you want to (like we do here) use the recycle bin to just BULK STORE all the deleted posts until they are reviewed for important information or possible legal problems?
  - you turn off the recycle bin feature and delete it?

-[Unknown]

Jack.R.Abbit™

I can see both sides to this.  So you use the "count post" setting of what ever the recycle bin board is.  If you think the moderators will get confused and that is more important than maintaining people's true post count (or you just use it for bulk storage), then set the recycle bin to not count posts.  Otherwise, you set it to count posts, maintain true post count and deal with moderator confusion another way...

Scenerio #1
Step 1. You delete a post, and it checks to see if it should use the recycle bin - it should.
Step 2. It checks to see if post in the recycle bin should count - it should
Step 3. Nothing happens to post count at this time since the post is still on the forum (in recycle board)
Step 4. You decide to delete the post (from the recycle board), it checks to see if recycle bin posts counted, they do so decreases the poster's post count.
Step 5. The message gone

Scenerio #2
Step 1. You delete a post, and it checks to see if it should use the recycle bin - it should.
Step 2. It checks to see if post in the recycle bin should count - it should not
Step 3. Post count is reduced
Step 4. You decide to delete the post (from the recycle board), it checks to see if recycle bin posts counted, they don't, so don't decrease the poster's post count (it already was).
Step 5. The message gone.

Scenerio #3
Step 1. You delete a post, and it checks to see if it should use the recycle bin - it should not.
Step 3. Post count is reduced
Step 3. The message gone.

Scenerio #4
Step 1. You delete a post, and it checks to see if it should use the recycle bin - it should.
Step 2. It checks to see if post in the recycle bin should count - it should
Step 3. Nothing happens to post count at this time since the post is still on the forum (in recycle board)
Step 4. You decide to delete the recycle board, it checks to see if recycle bin posts counted, they did so decrease the poster's post count. (Wouldn't this happen anytime you removed a board anyway?)
Step 5. The recycle bin and all messages gone

Scenerio #5
Step 1. You delete a post, and it checks to see if it should use the recycle bin - it should.
Step 2. It checks to see if post in the recycle bin should count - it should not
Step 3. Post count is reduced
Step 4. You decide to delete the delete the recycle board, it checks to see if recycle bin posts counted, they don't, so don't decrease the poster's post count (it already was).
Step 5. The recycle bin and all messages gone

EG

Is there an updated function for this on SMF 1.1.2

I dont want people's post count to be reduced by deleted topics or posts....

(I have a vague memory, there was a switch for this somewhere in the admin panel.. but cant find it now :-\)

RemoveTopic.php

// Decrease the post counts.
if ($decreasePostCount)
{
$requestMembers = db_query("
SELECT m.ID_MEMBER, COUNT(*) AS posts
FROM ({$db_prefix}messages AS m, {$db_prefix}boards AS b)
WHERE m.ID_TOPIC $condition
AND b.ID_BOARD = m.ID_BOARD
AND m.icon != 'recycled'
AND b.countPosts = 0
GROUP BY m.ID_MEMBER", __FILE__, __LINE__);
if (mysql_num_rows($requestMembers) > 0)
{
while ($rowMembers = mysql_fetch_assoc($requestMembers))
updateMemberData($rowMembers['ID_MEMBER'], array('posts' => 'posts - ' . $rowMembers['posts']));
}
mysql_free_result($requestMembers);
}


cant identify the false true thing in this file now.... and dont want to mess around with it :-\

codenaught

Still need help with this?

Maybe this is what you are looking for? Post Count Changes.
Dev Consultant
Former SMF Doc Coordinator

Advertisement: