Quote tags not recognized

[Burpee]

I'm not sure if this should be in converters and importers or in here.

I recently changed from phpBB to SMF.

My problem is that in the majority of the posts on my board the [ quote ] tags are not recognized properly.
When I do however modify the post, it shows the proper [ /quote ] to close it off.
When I save the post then, it suddenly shows the quote properly.

I'm wondering how I could fix this without having to resave 1200 posts. Already looked through the forum maintenance and there is nothing to "repair" this in repair_settings.php either. I have already looked at the MySQL information which is like this:

Code Select Expand

[quote="username"]content[quote][/quote]
Seems okay to me, but I could be mistaken.

[Peter Duggan]

I have already looked at the MySQL information which is like this:

Code Select Expand

[quote="username"]content[quote][/quote]
Seems okay to me, but I could be mistaken.

No, that's wrong... it should be:

(can't get this to show right!)

But you should be able to run a SQL query to change that throughout your forum if they're all the same.

[Peter Duggan]

So are you actually getting the extra quote tag before the closing quote tag or is that just how your post here (like mine) came out despite the code tags? IOW, is it effectively 'open quote, content, open quote, close quote' or 'open quote, content, close quote'?

[Burpee]

The resulting effect in the browser is:
[ quote="username" ] content

So the open-quote is not recognized or something, but the close-quote is?

[[Unknown]]

I'll see if I can find what's wrong.

Edit: Fixed for RC1.

-[Unknown]

[Burpee]

In the meantime, any advice on what I could do to fix this?

[Dietrich]

Yeah, I would like to know this too. The problem is just that most phpBB quotes begin with

Code Select Expand

[quote="nickname"][quote][/quote]Now it would be handy if I can run a query that replaces those tags with a simple

Code Select Expand

[quote][/quote] tag.

[Vitat]

SMF not understand phpBB tags.
Needed some script to implement to phpBB2SMF converter, which change

Code Select Expand

[quote="nickname"]
to

Code Select Expand

[quote author=nickname][/quote]

[[Unknown]]

I'll see if I can find what's wrong.

Edit: Fixed for RC1.

-[Unknown]

As I said, yes it should support quote=.  There was something wrong, but it will in RC1.

-[Unknown]

[packman]

As I said, yes it should support quote=.  There was something wrong, but it will in RC1.

-[Unknown]

Is it the phpbb2smf converter or the main SMF codet that's finxed in RC1, i.e. if I import my phpBB2 database using the current converter, the quotes will all display correctly once I apply the RC1 code, or I would need to import my phpBB2 database using the RC1 converter for it to work properly?

Chris

[Oldiesmann]

The next version of the convertor will be released with RC1, so that's what he means...

[[Unknown]]

Umm, no, it was a bug in the bbc parsing engine of SMF.  Your existing conversion will work properly under RC1.

-[Unknown]

[packman]

Edit: Fixed for RC1.

Quote tags still don't seem to be recognised correctly in RC1. I'm still seeing [ quote="aardvark"] tags with the quoted text not shown as quoted.

The additional [ quote][ /quote] at the end of the quoted text seems to be OK now though.

(I've added an extra space after the tag open bracket to ensure that the text doesn't mess up the display!)

[[Unknown]]

Can you give an example quote that has problems?  See if it parses correctly here?

-[Unknown]

[Burpee]

[ quote="username" ]testing text[ /quote ]

testing text

The problem is that when you create a new post with the same thing, it does work
Old posts however are not "converted" to an actual quote block

My solution was to be found in:
http://www.simplemachines.org/community/index.php?topic=14930.msg125925#msg125925
Using phpMyAdmin

[packman]

When you enter a quote manually in phpBB you use:

[ quote]This is some quoted text[ /quote]

If you select text from a previous post for quoting you get:

[ quote="windy"]Some quoted text from the user called windy[ /quote]

Looking at the post_text field in the phpbb_posts_text table shows that quoted text from a user is stored as:

[ quote:49c994073e="windy"]uploading a new zip[ /quote:49c994073e]

The 49c99.... bit appears to be the same as the 'bbcode_uid' field in the phpbb_posts_text table, but I don't understand the significance of this field/value.

After running the convertor I end up with

[ quote="windy"]This is some quoted text from the user called windy

but there is no trailing [ /quote]

[Oldiesmann]

I've seen that stupid phpBB bug before although it mainly seems to happen on phpNuke sites (annoying, isn't it?). Not sure why it's leaving off the ending quote tag.

[Unknown] - Sorry about that. I didn't pay attention to the date of the post, so I thought you meant it had been fixed for the next version.

[[Unknown]]

SMF doesn't even mess with the

.

-[Unknown]

[packman]

SMF doesn't even mess with the

.

-[Unknown]

Here's an original phpBB2 discussion thread. If you look at the fourth message down (from administrator), you'll see what the quotes look like in phpBB2.

http://www.weather-watch.com/phpBB2/viewtopic.php?t=4880&start=120

Here's the converted thread on my test system...

http://www.marton-blackpool.info/smf/index.php?topic=4880.120

There are many other examples...in fact I don't remember seeing a correctly converted quote. I didn't see any errors during the conversion either.

So something is messing with the quote 

Strangely the messages in SMF have kept their open quote tags but lost the close quote tags.

Chris

[[Unknown]]

Here's an original phpBB2 discussion thread. If you look at the fourth message down (from administrator), you'll see what the quotes look like in phpBB2.

http://www.weather-watch.com/phpBB2/viewtopic.php?t=4880&start=120

Here's the converted thread on my test system...

http://www.marton-blackpool.info/smf/index.php?topic=4880.120

There are many other examples...in fact I don't remember seeing a correctly converted quote. I didn't see any errors during the conversion either.

So something is messing with the quote 

Strangely the messages in SMF have kept their open quote tags but lost the close quote tags.

Chris

Can you try this query in phpMyAdmin?

SELECT post_text, REPLACE(post_text, CONCAT(':', bbcode_uid), '')
FROM phpbb_posts_text
WHERE post_id = 32540
LIMIT 1;

-[Unknown]