Search before and after

[The One]

I am trying to create a mod using the directions given in the package_sdk.
I am searching both before and after and then doing an add in my xml file however I see that the code I am adding is being added twice instead of once.

This is the code I am using in the XML file

Code Select Expand

<operation>
<search position="before"><![CDATA[
// Do some logging, unless this is an attachment, avatar, theme option or XML feed.
if (empty($_REQUEST['action']) || !in_array($_REQUEST['action'], array('dlattach', 'jsoption', '.xml')))
{
// Log this user as online.
writeLog();

// Track forum statistics and hits...?
if (!empty($modSettings['hitStats']))
trackStats(array('hits' => '+'));
}
]]></search>
<search position="after"><![CDATA[
// Is the forum in maintenance mode? (doesn't apply to administrators.)
if (!empty($maintenance) && !allowedTo('admin_forum'))
]]></search>
<add><![CDATA[
        // Perform the Windows Domain user check for the visitor
        domain_userCheck();
]]></add>
</operation>

Any idea how this is happening? And how to rectify it?

[The One]

*bump*
Do mod writers do a search for both "before" and "after" when they make any changes or is it only either one of them?

[KGIII]

(I left your post and removed the one before it - I don't know your answer directly EXCEPT to say that you must be careful of whitespace. No EXTRA spaces at all or the proverbial fecal matter hits the fictional fan.)

[Dannii]

I only ever have seen one search tag used.

[The One]

@KGIII: you can delete my the post after that too (with the  ) as well as this 

[The One]

The package_sdk readme specifically mentions that it is better to use both before and after so that we get to the exact location we need to add code.
So I was assuming everyone does this most of the time and I was missing something?

[B Patterson]

yes, the SDK says it's better to use both, but I had the EXACT same issue as you when I first started developing mods.  Unfortunately it doesn't seem that multiple search items aren't supported.  So you have to search either before or after only.

[Joshua Dickerson]

You should only need one. If you want to make absolutely sure that it is the correct block, try replace.

[Dannii]

I don't think replace will make it any more sure. Just make sure it's unique by searching for the text, it should appear only once. Try and include a comment in your search, they're nearly all unique.

[The One]

Have done that for now.
BTW it would be great if we could do a search for both before and after so that we get the location right. Not sure how easy it is to do this though.