Shoutbox!

[LancelowDowell]

Not sure where this should go, since there really isn't a hack forum anywhere....  but anyways...

Well, I have most of my shoutbox coding done..  It's now functional, just has a few minor tweaks to make it fit on the board better.  You can check it out at http://www.cursedlegacy.net/smf.  I'll be doing a quick write up on how to set it up.  Let me know what you think!

[Peter Duggan]

Did you know that Grudge has already done a shoutbox mod, but the SMF mod site hasn't been fully implemented yet?

[LancelowDowell]

eh, actually i wasn't aware of that....  i still had fun doing in though! :-)

[Grudge]

eh, actually i wasn't aware of that.... i still had fun doing in though! :-)

Heh - always space for more than one mod of the same type Feel free to download my version from my package server if it helps you. Besides - my shoutbox is more a port of Greg Haase's than my own work!

[[Unknown]]

(and who knows, they might be completely different?)

-[Unknown]

[LancelowDowell]

Ok, finally got around to putting this together enough to post....  if you have any questions please let me know!  Also, feel free to hack out the comments I put in, those were just in there for my records.

[[Unknown]]

you'll just have to put a copy of shoutbox.php in the template folders

Actually, you don't even have to do that ^_^.  Just put it in default and it should work for all themes - assuming you edit index.template.php for each.

Hmm, okay.  In your header for shout.php, you use tabs... which doesn't align the *'s properly in my editor.

Code Select Expand

include('Settings.php');
require('SSI.php');
include($sourcedir . '/Subs-Post.php');
include_once($sourcedir . '/Security.php');

Only the second and third should be necessary. (Security and Settings are loaded by SSI.php...)

Code Select Expand

redirectexit('');
Nitpick: I'd recommend just redirectexit();...

Code Select Expand

'$currentDate[0]'
I recommend replacing that with " . time() . ".

Code Select Expand

if($user['id']=="")
{
//do nothing since it's a guest.
}
else
I recommend using instead:

Code Select Expand

if(!$user_info['is_guest'])

And instead of using:

Code Select Expand

$user = ssi_welcome('array');
I would just say:

Code Select Expand

global $user_info, $ID_MEMBER;
And replace:

Code Select Expand

{$user['id']}
With:

Code Select Expand

$ID_MEMBER

And, shoutbox.php might be more efficient if you made this:

Code Select Expand

SELECT userid, shoutDate, pageText
FROM {$db_prefix}shout
order by id desc
limit 10", __FILE__, __LINE__);
Read instead:

Code Select Expand

SELECT s.userid, s.shoutDate, s.pageText, mem.realName
FROM {$db_prefix}shout AS s
LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER = s.userid)
ORDER BY id DESC
LIMIT 10", __FILE__, __LINE__);

And then remove:

Code Select Expand

$shoutUser = db_query("
SELECT realName
FROM {$db_prefix}members
WHERE ID_MEMBER=" . $row["userid"] . "
limit 1", __FILE__, __LINE__);

$row2 = mysql_fetch_array($shoutUser);

And make:

Code Select Expand

$row2['realName']
Instead:

Code Select Expand

$row['realName']

I know I nitpick a lot, but I do it equally to everyone - just ask Grudge ^_^.

-[Unknown]

[LancelowDowell]

actually for some reason I had to run the include on settings and security...  I didn't play with it a whole lot, but I couldn't get it to work unless I included those files...

Thanks for the comments though.  Most of that stuff I didn't know about, like the user id and such.  I'll have to change the sql statement as well...  not a big deal having 2 statements vs 1, but every little bit helps.

[[Unknown]]

Thanks for the comments though.  Most of that stuff I didn't know about, like the user id and such.  I'll have to change the sql statement as well...  not a big deal having 2 statements vs 1, but every little bit helps.

Actually, it's 1 + n where n is the number of shouts.... that's a bit more, isn't it?

You need to include Security.php, really?  Strange, I'll see if I can look into that.

-[Unknown]

[LancelowDowell]

hmm, I just commeted that out, and it's working fine now....  I can't recall what was excatly happening that cause me to add that, but if it's working fine now....

[LancelowDowell]

I do need settings though... I get this error when I comment out settings.  Looks like it can't find subs-post since it doesn't have the sourcedir from settings.

Notice: Undefined variable: sourcedir in /u/htdocs/ribcra/smf/Sources/shout.php on line 19
Warning: shoutbox(/Subs-Post.php) [function.shoutbox]: failed to create stream: No such file or directory in /u/htdocs/ribcra/smf/Sources/shout.php on line 19
Warning: shoutbox() [function.shoutbox]: Failed opening '/Subs-Post.php' for inclusion (include_path='.:/usr/local/lib/php') in /u/htdocs/ribcra/smf/Sources/shout.php on line 19

[[Unknown]]

Try this instead:

global $sourcedir;

-[Unknown]

[LancelowDowell]

Hmm, I also tried your change for the guest thing, but it didn't pick up that I was a guest.  It still posted the shout with no user name.

[LancelowDowell]

eh, nm, i think i see what i did wrong....

[[Unknown]]

Okay, well, interesting.  Here, try the attached - does it work?

-[Unknown]

[LancelowDowell]

worked for a normal insert, but when I was logged in as a guest, it didn't run redirectexit(); because of the return command.  So it just hung the page...  so I replaced the return; with a redirectexit(); and looks a bit better now.

[LancelowDowell]

also, just a question since I couldn't find it on my digging through code...  where is the text processor for output?  It runs the preparse and sets up the user's text, but I couldn't find any of the functions to do the reverse...

[[Unknown]]

For output?  You mean the one that parses smileys and bbc?

It's doUBBC() in Subs.php, use it like so:

echo doUBBC($string, $useSmileys);

Where $string is the string to parse, and $parseSmileys is true or false, whether you want them parsed or not.

-[Unknown]

[LancelowDowell]

ah, cool.  thanks

[LancelowDowell]

Just a few updates I did to it....  I cleaned up the html a little bit, I had a small type that was causing some screwy things.  I also fixed it up so that when a guest is logged in, it won't display the text box.  Next in line will be an archive and basic stats....