The Rules

Started by Deprecated, August 25, 2008, 05:42:14 PM

Previous topic - Next topic

BillyBob31

Quote from: Sabre™ on October 13, 2008, 10:11:01 PM
Ok buddy :)
Just to test, can you add the attached file to your language folder.
Now check your admin panel for any change

If that doesnt help, then can you answer these 3 questions?  Just to get up to speed.

1)You have manually installed this mod yes?
2)You have double checked the Modifications.english.php in your languages file?
3)Your code isnt in one line, as the parser on the download page often copies as?

Cheers :)

Ok I added that file and then went and switched back to my camo theme. Now when I go to Admin > Current Theme the rules tab shows. When I go to anything else the rules tab goes away. When I do that url you gave me for the rules thing I still see those few check boxes and empty type areas but no words.

1)Yes
2)Yes
3)Correct

P.S.
Now after adding that file I will recheck the files with the manual install process again for the 5th time and see if anything changes.

Deprecated

#161
Your problem is in the language strings. I think it's pointless to check or recheck any other files.

Here is another idea. If you have a Modifications.english-utf8.php file, add the language strings to that file. If you have no such file just make a copy of your Modifications.english.php file and name it with the -utf8 added. Do leave the original file too.

Another thing you can try is to put the language strings in your index.english.php file. Try this in your default theme (languages directory). Or, try it in your theme's equivalent file if it has one.

Eva

Quote from: Sabre™ on October 11, 2008, 07:28:14 PM
@ Eva

Try doing [THIS].
It's from a couple pages back.

Good luck :)

Quote from: Bancherd on October 11, 2008, 07:09:05 PM
....... could also do the same for Apache Errors Handler.., but need to find the equivalent for "WTF"..  Haha  :D

PMSL

This worked for me!
Thank you very much  :)
Also thank you for your kind words about our site. It's nice to have fans even if they're hundreds of miles away  ;D

Regards,
Eva

Deprecated

More like thousands of miles away.

Eva, I hate to tell you this but I've incorporated that fix in the package and uploaded a new version of The Rules. You should use the new version instead of having manual edits because mod packages are easier to install, remove and maintain. For your own sake you should take those manual edits out of your file, then download and install the new version of The Rules.

I'm sure that the new version will install and work correctly on both your test forum and your production forum.

Here is the new version of the mod package:

http://custom.simplemachines.org/mods/index.php?mod=1343

BillyBob31

#164
Quote from: Deprecated on October 14, 2008, 09:20:55 AM
Your problem is in the language strings. I think it's pointless to check or recheck any other files.

Here is another idea. If you have a Modifications.english-utf8.php file, add the language strings to that file. If you have no such file just make a copy of your Modifications.english.php file and name it with the -utf8 added. Do leave the original file too.

Another thing you can try is to put the language strings in your index.english.php file. Try this in your default theme (languages directory). Or, try it in your theme's equivalent file if it has one.

I have these 2 files in my themes > camo > languages

Settings.english.php
Modifications.english-uft8.php

This is what is in my Modifications.english-uft8.php

<?php

$txt
['the_rules_not_configured'] = 'This feature has not yet been configured by the administrator.';
$txt['agreement'] = 'Agreement';
$txt['rules_enable_guest_access'] = 'Enable guest access:';
$txt['the_rules_display_name'] = 'Display name of rules page:';
$txt['the_rules_agreement_display_name'] = 'Display name of agreement page:';
$txt['mods_cat_rules'] = 'The Rules';
$txt['rules'] = 'Rules';
$txt['rules_title']='The Rules';
$txt['rules_title_rules'] = 'Rules';
$txt['the_rules_text'] = 'Text to display:';
$txt['additional'] = 'Additional';
$txt['the_rules_additional_display_name'] = 'Display name of additional page:';
$txt['the_rules_additional_text'] = 'Additional text to display:';
$txt['the_rules_enable_additional'] = 'Enable display of additional page:';
$txt['rules_title_additional'] = 'Additional';
$txt['rules_title_agreement'] = 'Agreement';
$txt['the_rules_enable_agreement'] = 'Enable display of agreement.txt page:';
$txt['the_rules_edit_name'] = 'Edit agreement.txt';

?>


Deprecated

In your Camo theme languages directory copy your Modifications.english-utf8.php and rename the copy to Modifications.english.php

Also verify that your Modifications.english-uft8 has the .php on the end which I presume was just an oversight that you didn't type it that way.

BillyBob31

#166
Now I have these 3 files in my themes > camo > languages

Settings.english.php
Modifications.english-uft8.php
Modifications.english.php

Sweet now as far as I can tell it fully works. Think I am gonna do your update you added the other day.

Deprecated

Okay, so as far as I know you are fixed up and the mod now works to your satisfaction. Good! :)

As far as your problem regarding "not writable," that is unrelated to my modification and is off topic, so I will appreciate if you could start a topic in the 1.x or 2.x support board where I am sure they can fix you up. I would prefer that The Rules topic will be easier for other people to use if we keep it focused on supporting the mod package.

As far as the new version, it fixes only one thing, that in 1.1.6 the Rules tab did not highlight. If your tab highlights when you select it then you don't need the fix. If that is the case then just keep it in mind if you ever remove the package, to use the new version next time you install.

BillyBob31

Ok sweet yea all works greet. And to the off topic part, I removed it (sorry about that bro).

Deprecated

Nothing to worry about. I just wanted to make sure the off-topic went to the topic where it would be on-topic. :D

I'm glad we fixed you up and I wish you the best of luck on your upcoming camping trip. ;) ;) ;) ;) ;)

Sabre™

Great job guys
Wonder why it wasnt taking the file from the default lang dir ??
Oh well, good to see it was up n running!!   Until you deleted it that is!! LOL

Good work peeps :)
Do NOT give admin and/or ftp details to just anybody, see if they are trust worthy first!!  Do your homework ;)


Deprecated

I'm sure it was theme related. I'm planning my first theme now, and after I've got it running and posted at the theme site maybe I'll be better able to help people with theme problems.

Eva

Quote from: Deprecated on October 14, 2008, 09:34:21 AM
Eva, I hate to tell you this but I've incorporated that fix in the package and uploaded a new version of The Rules. You should use the new version instead of having manual edits because mod packages are easier to install, remove and maintain. For your own sake you should take those manual edits out of your file, then download and install the new version of The Rules.

I'm sure that the new version will install and work correctly on both your test forum and your production forum.

Here is the new version of the mod package:

http://custom.simplemachines.org/mods/index.php?mod=1343

I know that I should uninstall the current version and install the new one but because this mod was the 5th I installed and now I have almost 20mods installed I can't uninstall it without having to manually edit the code anyway so it was easier just to add just one word to one file than having to look for the code that actually fails to uninstal and then reinstalling the package again.
Don't worry I know what I'm doing  :)

Thanx again for all the support!  O:)

Deprecated

I just wanted you to get the best possible advice. I used to manually edit my forum's code but in only a week or so I realized that my notes were getting so massive that if I had to reinstall I would probably have to figure it out all over again. In the industry we call this software configuration management.

I know not everybody can do this or those who can aren't willing, but since then I've put every mod in a package after I got it working. I do my mods one at a time on my test site(s), then when they are perfected I apply them to my production sites. (BTW that's how I get so many mod packages.)

So I can take one of my sites and strip off 20-30 mod packages in about 10 minutes, and then put them back in another 10 minutes if I don't have to upload them too. If you've seen a casino dealer manually shuffle a deck of cards, my installing/removing mod packages is about like that. I know my mod packages all play together fairly so it doesn't even matter which order they are installed, although I like to put in first the ones most likely to stay the longest.

Maybe we need to teach you to write mods, or you can just take apart a few and figure it out for yourself like I did. The end result is that you know exactly what changes have been applied to your forum(s), and you can add/remove/change your mods almost effortlessly. When a new SMF version comes out you just test each mod one at a time against your test site, apply the ones that are compatible to your production site after upgrading it. You have total control of your software configuration.

With manual edits you are subject to human error so it's sometimes difficult to do it the same way twice.

The Saviour

My hat's off to Deprecated for the support you offer with your mods.

I wish everyone, who coded, was as diligent as you.

All my best!

Steve

Deprecated

Thank you Steve. I'm a perfectionist and a professional developer. I put in the same attention to detail here that I do on my day job. I'm trying to make my mods as perfect as they can possibly be, and I want to set an example for others to follow. It's not that I'm trying to make them look bad as much as I'm trying to show them how they can be better so that they can bring up the quality of their work too. I hope the other mod authors have noticed my work, and I hope they will take apart my packages and get some good ideas they can use in their own modification packages.

And truth be known I'd be as embarrassed as hell if somebody took apart my packages and saw what I've seen in theirs. I've taken apart many dozens of packages, and even often modify other authors' packages before installing them on my own forums because they weren't up to my standards sufficiently for me to run them on my own production forums.

Another thing, much of my mod package support work involves finding out why my users can't install my packages, and in about 25% of the cases it turns out that some other author's sloppy work has stepped on my search target and ruined it by screwing up the formatting. What I mean is that after their modification is installed the modified file no longer meets SMF coding guidelines! Work this sloppy is inexcusable. Not only does it look shoddy but it breaks other mod packages. It's a shame I can't track them down and tell them to fix their packages, but besides the time involved there is also the likely outcome of making enemies, and I don't want to be enemies with the other mod package authors. I figure that's between them and their users and the Customization Team, and not any of my own business except when I become one of their users by installing their packages.

I like to think that some day in the future things will be better. Like maybe in the year 2000 or something. ;)

The Saviour

Deprecated...

Thanks for explaining that...I'm sure others will read this "blurb" and also compliment you on the support you give to your own mods.

As far as coding, SMF should follow more strict guidelines when it comes to mod development and submission.

If the submitted mod does not adhere to these guidelines, then it should be "nixed" until it does.

Gwydion Frost

Query: I have need of more than 3 pages, so is there a way to get 5 more additional pages listing?

Deprecated

Gwydion, I am considering upgrades to this package. One suggestion is to have a configuration setting to change the "RULES" tab to whatever the user wants (without editing language files) and I think that's  very good idea. I expect to add that shortly. At the same time I'll look at it and see if I can add some more pages for you. :)

Gwydion Frost

Actually, its funny that you say that, because "Rules" was being changed to "Legal" on my website... so, yeah.

Which is why I need the 5 additional pages on top of the 3 you already have in the mod. ;)

Advertisement: