template messed up in Ban area with safari

Started by Beagleboys, December 01, 2009, 09:32:04 AM

Previous topic - Next topic

Beagleboys

Version(s) of SMF 2.0 RC2
Setup:
installed mods:

QuoteCustom Copyright   1.2   [ Disinstalla ]
2.   View IP Permissions   1.0   [ Disinstalla ]
3.   PortaMx v0.971-1 upgrade   0.971-1   [ Disinstalla ]
4.   Custom BBCode   2.00   [ Disinstalla ]
5.   SMF Staff Page   1.6   [ Disinstalla ]
6.   reCAPTCHA for SMF   0.9.7   [ Disinstalla ]
7.   Sitemap   2.1.0   [ Disinstalla ]
8.   Toksta Integration   1.0   [ Disinstalla ]
9.   Wysiwyg Quick Reply RC2   RC2   [ Disinstalla ]
10.   Aeva ~ Auto-Embed Video & Audio   7.0   [ Disinstalla ]
11.   Custom Tab   1.2   [ Disinstalla ]
12.   RSS Feeder   1.1.4   [ Disinstalla ]
13.   Pretty URLs   1.0RC   [ Disinstalla ]
List any Themes you have installed
none except default

List any non-English Language packs you have installed
Italian

Are you using UTF-8?
no
Any other related information?
Browser: Safari
QuoteMozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_2; it-it) AppleWebKit/531.21.8 (KHTML, like Gecko) Version/4.0.4 Safari/531.21.10
Server Software: Linux
Apache/IIS version?:
PHP version?: 5.2.11
Database type and version: 5.0.82sp1-log

Where the Error Occurred
Admin panel>Ban user

How to Reproduce this Error?:
just entering in the panel with safari

Additional Information?
panel completly messed up(look attached image)

Code of template:(not edited)
<?php
// Version: 2.0 RC2; ManageBans

function template_ban_edit()
{
global $context, $settings, $options, $scripturl, $txt, $modSettings;

echo '
<div id="manage_bans">

<h3 class="catbg"><span class="left"></span>
'
, $context['ban']['is_new'] ? $txt['ban_add_new'] : $txt['ban_edit'] . ' \'' . $context['ban']['name'] . '\'', '
</h3>'
;

if ($context['ban']['is_new'])
echo '
<div class="information">'
, $txt['ban_add_notes'], '</div>';

echo '
<div class="windowbg">
<span class="topslice"><span></span></span>
<div class="content">
<form action="'
, $scripturl, '?action=admin;area=ban;sa=edit" method="post" accept-charset="', $context['character_set'], '" onsubmit="if (this.ban_name.value == \'\') {alert(\'', $txt['ban_name_empty'], '\'); return false;} if (this.partial_ban.checked &amp;&amp; !(this.cannot_post.checked || this.cannot_register.checked || this.cannot_login.checked)) {alert(\'', $txt['ban_restriction_empty'], '\'); return false;}">
<dl class="settings">
<dt>
<strong>'
, $txt['ban_name'], ':</strong>
</dt>
<dd>
<input type="text" name="ban_name" value="'
, $context['ban']['name'], '" size="50" class="input_text" />
</dd>
<dt>
<strong>'
, $txt['ban_reason'], ':</strong><br />
<span class="smalltext">'
, $txt['ban_reason_desc'], '</span>
</dt>
<dd>
<input type="text" name="reason" value="'
, $context['ban']['reason'], '" size="50" class="input_text" />
</dd>
<dt>
<strong>'
, $txt['ban_notes'], ':</strong><br />
<span class="smalltext">'
, $txt['ban_notes_desc'], '</span>
</dt>
<dd>
<textarea name="notes" cols="50" rows="3">'
, $context['ban']['notes'], '</textarea>
</dd>
</dl>
<fieldset class="ban_settings align_left">
<legend>
'
, $txt['ban_expiration'], '
</legend>
<input type="radio" name="expiration" value="never" id="never_expires" onclick="fUpdateStatus();"'
, $context['ban']['expiration']['status'] == 'never' ? ' checked="checked"' : '', ' class="input_radio" /> <label for="never_expires">', $txt['never'], '</label><br />
<input type="radio" name="expiration" value="one_day" id="expires_one_day" onclick="fUpdateStatus();"'
, $context['ban']['expiration']['status'] == 'still_active_but_we_re_counting_the_days' ? ' checked="checked"' : '', ' class="input_radio" /> <label for="expires_one_day">', $txt['ban_will_expire_within'], '</label>: <input type="text" name="expire_date" id="expire_date" size="3" value="', $context['ban']['expiration']['days'], '" class="input_text" /> ', $txt['ban_days'], '<br />
<input type="radio" name="expiration" value="expired" id="already_expired" onclick="fUpdateStatus();"'
, $context['ban']['expiration']['status'] == 'expired' ? ' checked="checked"' : '', ' class="input_radio" /> <label for="already_expired">', $txt['ban_expired'], '</label>
</fieldset>
<fieldset class="ban_settings align_right">
<legend>
'
, $txt['ban_restriction'], '
</legend>
<input type="radio" name="full_ban" id="full_ban" value="1" onclick="fUpdateStatus();"'
, $context['ban']['cannot']['access'] ? ' checked="checked"' : '', ' class="input_radio" /> <label for="full_ban">', $txt['ban_full_ban'], '</label><br />
<input type="radio" name="full_ban" id="partial_ban" value="0" onclick="fUpdateStatus();"'
, !$context['ban']['cannot']['access'] ? ' checked="checked"' : '', ' class="input_radio" /> <label for="partial_ban">', $txt['ban_partial_ban'], '</label><br />
<input type="checkbox" name="cannot_post" id="cannot_post" value="1"'
, $context['ban']['cannot']['post'] ? ' checked="checked"' : '', ' class="ban_restriction input_radio" /> <label for="cannot_post">', $txt['ban_cannot_post'], '</label> (<a href="', $scripturl, '?action=helpadmin;help=ban_cannot_post" onclick="return reqWin(this.href);">?</a>)<br />
<input type="checkbox" name="cannot_register" id="cannot_register" value="1"'
, $context['ban']['cannot']['register'] ? ' checked="checked"' : '', ' class="ban_restriction input_radio" /> <label for="cannot_register">', $txt['ban_cannot_register'], '</label><br />
<input type="checkbox" name="cannot_login" id="cannot_login" value="1"'
, $context['ban']['cannot']['login'] ? ' checked="checked"' : '', ' class="ban_restriction input_radio" /> <label for="cannot_login">', $txt['ban_cannot_login'], '</label><br />
</fieldset>
<br class="clear_right" />'
;

if (!empty($context['ban_suggestions']))
{
echo '
<fieldset>
<legend>
'
, $txt['ban_triggers'], '
</legend>
<dl class="settings">
<dt>
<input type="checkbox" name="ban_suggestion[]" id="main_ip_check" value="main_ip" class="input_check" />
<label for="main_ip_check">'
, $txt['ban_on_ip'], '</label>
</dt>
<dd>
<input type="text" name="main_ip" value="'
, $context['ban_suggestions']['main_ip'], '" size="50" onfocus="document.getElementById(\'main_ip_check\').checked = true;" class="input_text" />
</dd>'
;

if (empty($modSettings['disableHostnameLookup']))
echo '
<dt>
<input type="checkbox" name="ban_suggestion[]" id="hostname_check" value="hostname" class="input_check" /></td>
<label for="hostname_check">'
, $txt['ban_on_hostname'], '</label>
</dt>
<dd>
<input type="text" name="hostname" value="'
, $context['ban_suggestions']['hostname'], '" size="50" onfocus="document.getElementById(\'hostname_check\').checked = true;" class="input_text" />
</dd>'
;

echo '
<dt>
<input type="checkbox" name="ban_suggestion[]" id="email_check" value="email" class="input_check" />
<label for="email_check">'
, $txt['ban_on_email'], '</label>
</dt>
<dd>
<input type="text" name="email" value="'
, $context['ban_suggestions']['email'], '" size="50" onfocus="document.getElementById(\'email_check\').checked = true;" class="input_text" />
</dd>
<dt>
<input type="checkbox" name="ban_suggestion[]" id="user_check" value="user" class="input_check" />
<label for="user_check">'
, $txt['ban_on_username'], '</label>:
</dt>
<dd>'
;

if (empty($context['ban_suggestions']['member']['id']))
echo '
<input type="text" name="user" id="user" value="" size="40" class="input_text" />'
;
else
echo '
'
, $context['ban_suggestions']['member']['link'], '
<input type="hidden" name="bannedUser" value="'
, $context['ban_suggestions']['member']['id'], '" />';
echo '
</dd>'
;

if (!empty($context['ban_suggestions']['message_ips']))
{
echo '
</dl>
<div>'
, $txt['ips_in_messages'], ':</div>
<dl class="settings">'
;

foreach ($context['ban_suggestions']['message_ips'] as $ip)
echo '
<dt>
<input type="checkbox" name="ban_suggestion[ips][]" value="'
, $ip, '" class="input_check" />
</dt>
<dd>
'
, $ip, '
</dd>'
;
}

if (!empty($context['ban_suggestions']['error_ips']))
{
echo '
</dl>
<div>'
, $txt['ips_in_errors'], '</div>
<dl class="settings">'
;

foreach ($context['ban_suggestions']['error_ips'] as $ip)
echo '
<dt>
<input type="checkbox" name="ban_suggestion[ips][]" value="'
, $ip, '" class="input_check" />
</dt>
<dd>
'
, $ip, '
</dd>'
;
}

echo '
</dl>
</fieldset>'
;
}

echo '
<input type="submit" name="'
, $context['ban']['is_new'] ? 'add_ban' : 'modify_ban', '" value="', $context['ban']['is_new'] ? $txt['ban_add'] : $txt['ban_modify'], '" class="button_submit" />
<input type="hidden" name="old_expire" value="'
, $context['ban']['expiration']['days'], '" />
<input type="hidden" name="bg" value="'
, $context['ban']['id'], '" />
<input type="hidden" name="'
, $context['session_var'], '" value="', $context['session_id'], '" />
</form>
</div>
<span class="botslice"><span></span></span>
</div>'
;

if (!$context['ban']['is_new'] && empty($context['ban_suggestions']))
{
echo '
<form action="'
, $scripturl, '?action=admin;area=ban;sa=edit" method="post" accept-charset="', $context['character_set'], '" style="padding: 0px;margin: 0px;" onsubmit="return confirm(\'', $txt['ban_remove_selected_triggers_confirm'], '\');">
<table class="table_grid" width="100%">
<thead>
<tr class="catbg">
<td width="65%" align="left">'
, $txt['ban_banned_entity'], '</td>
<td width="15%" align="center">'
, $txt['ban_hits'], '</td>
<td width="15%" align="center">'
, $txt['ban_actions'], '</td>
<td width="5%" align="center"><input type="checkbox" onclick="invertAll(this, this.form, \'ban_items\');" class="input_check" /></td>
</tr>
</thead>
<tbody>'
;
if (empty($context['ban_items']))
echo '
<tr class="windowbg2">
<td colspan="4">('
, $txt['ban_no_triggers'], ')</td>
</tr>'
;
else
{
foreach ($context['ban_items'] as $ban_item)
{
echo '
<tr class="windowbg2" align="left">
<td>'
;
if ($ban_item['type'] == 'ip')
echo '<strong>', $txt['ip'], ':</strong>&nbsp;', $ban_item['ip'];
elseif ($ban_item['type'] == 'hostname')
echo '<strong>', $txt['hostname'], ':</strong>&nbsp;', $ban_item['hostname'];
elseif ($ban_item['type'] == 'email')
echo '<strong>', $txt['email'], ':</strong>&nbsp;', $ban_item['email'];
elseif ($ban_item['type'] == 'user')
echo '<strong>', $txt['username'], ':</strong>&nbsp;', $ban_item['user']['link'];
echo '
</td>
<td class="windowbg" align="center">'
, $ban_item['hits'], '</td>
<td class="windowbg" align="center"><a href="'
, $scripturl, '?action=admin;area=ban;sa=edittrigger;bg=', $context['ban']['id'], ';bi=', $ban_item['id'], '">', $txt['ban_edit_trigger'], '</a></td>
<td align="center" class="windowbg2"><input type="checkbox" name="ban_items[]" value="'
, $ban_item['id'], '" class="input_check" /></td>
</tr>'
;
}
}

echo '
</tbody>
</table>
<div class="align_left">
[<a href="'
, $scripturl, '?action=admin;area=ban;sa=edittrigger;bg=', $context['ban']['id'], '"><strong>', $txt['ban_add_trigger'], '</strong></a>]
</div>
<div class="align_right">
<input type="submit" name="remove_selection" value="'
, $txt['ban_remove_selected_triggers'], '" class="button_submit" />
</div>
<br class="clear" />
<input type="hidden" name="bg" value="'
, $context['ban']['id'], '" />
<input type="hidden" name="'
, $context['session_var'], '" value="', $context['session_id'], '" />
</form>'
;

}

echo '
</div>
<br class="clear" />
<script type="text/javascript" src="'
, $settings['default_theme_url'], '/scripts/suggest.js?rc2"></script>
<script type="text/javascript"><!-- // --><![CDATA[
var fUpdateStatus = function ()
{
document.getElementById("expire_date").disabled = !document.getElementById("expires_one_day").checked;
document.getElementById("cannot_post").disabled = document.getElementById("full_ban").checked;
document.getElementById("cannot_register").disabled = document.getElementById("full_ban").checked;
document.getElementById("cannot_login").disabled = document.getElementById("full_ban").checked;
}
addLoadEvent(fUpdateStatus);'
;

// Auto suggest only needed for adding new bans, not editing
if ($context['ban']['is_new'] && empty($_REQUEST['u']))
echo '
var oAddMemberSuggest = new smc_AutoSuggest({
sSelf: \'oAddMemberSuggest\',
sSessionId: \''
, $context['session_id'], '\',
sSessionVar: \''
, $context['session_var'], '\',
sSuggestId: \'user\',
sControlId: \'user\',
sSearchType: \'member\',
sTextDeleteItem: \''
, $txt['autosuggest_delete_item'], '\',
bItemList: false
});

function onUpdateName(oAutoSuggest)
{
document.getElementById(\'user_check\').checked = true;
return true;
}
oAddMemberSuggest.registerCallback(\'onBeforeUpdate\', \'onUpdateName\');'
;

echo '// ]]></script>';
}

function
template_ban_edit_trigger()
{
global $context, $settings, $options, $scripturl, $txt, $modSettings;

echo '
<div id="manage_bans">
<form action="'
, $scripturl, '?action=admin;area=ban;sa=edit" method="post" accept-charset="', $context['character_set'], '">
<h3 class="catbg"><span class="left"></span>
'
, $context['ban_trigger']['is_new'] ? $txt['ban_add_trigger'] : $txt['ban_edit_trigger_title'], '
</h3>
<div class="windowbg">
<span class="topslice"><span></span></span>
<div class="content">
<fieldset>
<legend>
'
, $txt['ban_triggers'], '
</legend>
<dl class="settings">
<dt>
<input type="radio" name="bantype" value="ip_ban"'
, $context['ban_trigger']['ip']['selected'] ? ' checked="checked"' : '', ' class="input_radio" />
'
, $txt['ban_on_ip'], '
</dt>
<dd>
<input type="text" name="ip" value="'
, $context['ban_trigger']['ip']['value'], '" size="50" onfocus="selectRadioByName(this.form.bantype, \'ip_ban\');" class="input_text" />
</dd>'
;
if (empty($modSettings['disableHostnameLookup']))
echo '
<dt>
<input type="radio" name="bantype" value="hostname_ban"'
, $context['ban_trigger']['hostname']['selected'] ? ' checked="checked"' : '', ' class="input_radio" />
'
, $txt['ban_on_hostname'], '
</dt>
<dd>
<input type="text" name="hostname" value="'
, $context['ban_trigger']['hostname']['value'], '" size="50" onfocus="selectRadioByName(this.form.bantype, \'hostname_ban\');" class="input_text" />
</dd>'
;
echo '
<dt>
<input type="radio" name="bantype" value="email_ban"'
, $context['ban_trigger']['email']['selected'] ? ' checked="checked"' : '', ' class="input_radio" />
'
, $txt['ban_on_email'], '
</dt>
<dd>
<input type="text" name="email" value="'
, $context['ban_trigger']['email']['value'], '" size="50" onfocus="selectRadioByName(this.form.bantype, \'email_ban\');" class="input_text" />
</dd>
<dt>
<input type="radio" name="bantype" value="user_ban"'
, $context['ban_trigger']['banneduser']['selected'] ? ' checked="checked"' : '', ' class="input_radio" />
'
, $txt['ban_on_username'], '
</dt>
<dd>
<input type="text" name="user" id="user" value="'
, $context['ban_trigger']['banneduser']['value'], '" size="50" onfocus="selectRadioByName(this.form.bantype, \'user_ban\');" class="input_text" />
</dd>
</dl>
</fieldset>
<input type="submit" name="'
, $context['ban_trigger']['is_new'] ? 'add_new_trigger' : 'edit_trigger', '" value="', $context['ban_trigger']['is_new'] ? $txt['ban_add_trigger_submit'] : $txt['ban_edit_trigger_submit'], '" class="button_submit" />
</div>
<span class="botslice"><span></span></span>
</div>
<input type="hidden" name="bi" value="'
. $context['ban_trigger']['id'] . '" />
<input type="hidden" name="bg" value="'
. $context['ban_trigger']['group'] . '" />
<input type="hidden" name="'
. $context['session_var'] . '" value="' . $context['session_id'] . '" />
</form>
</div>
<br class="clear" />
<script type="text/javascript" src="'
, $settings['default_theme_url'], '/scripts/suggest.js?rc2"></script>
<script type="text/javascript"><!-- // --><![CDATA[
var oAddMemberSuggest = new smc_AutoSuggest({
sSelf: \'oAddMemberSuggest\',
sSessionId: \''
, $context['session_id'], '\',
sSessionVar: \''
, $context['session_var'], '\',
sSuggestId: \'username\',
sControlId: \'user\',
sSearchType: \'member\',
sTextDeleteItem: \''
, $txt['autosuggest_delete_item'], '\',
bItemList: false
});

function onUpdateName(oAutoSuggest)
{
selectRadioByName(oAutoSuggest.oTextHandle.form.bantype, \'user_ban\');
return true;
}
oAddMemberSuggest.registerCallback(\'onBeforeUpdate\', \'onUpdateName\');
// ]]></script>'
;
}

?>

Norv

Please try (./Themes/default/ManageBans.template.php):

Code (find) Select

<input type="checkbox" name="ban_suggestion[]" id="hostname_check" value="hostname" class="input_check" /></td>


Code (replace) Select

<input type="checkbox" name="ban_suggestion[]" id="hostname_check" value="hostname" class="input_check" />
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

Beagleboys

Now works! Thanks! Problem solved. (i guess that will not cause problem with other browsers?)

Norv

Quote from: Beagleboys on December 01, 2009, 10:31:08 AM
Now works! Thanks! Problem solved. (i guess that will not cause problem with other browsers?)

No, it was a bug.
Thank you for your report. :)
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

Advertisement: